x64 crashes when network drive not connected

[daniel_m]

Update: XYplorer starts fine when the active tab is a local drive. It crashes when I switch to a tab pointing to a disconnected network drive. The settings "Assume that server / mapped network drives are available" don't make a difference.


At least that's what I think is happening. My NAS was switched off, and starting XYplorer x64, it crashed before it could show any window. Now that the NAS is running again, XYplorer starts as expected.

Sorry, more network shenanigans?

Event Viewer says:

Faulting application name: XYplorer.exe, version: 27.90.0.9, time stamp: 0x12345678
Faulting module name: srvcli.dll, version: 10.0.19041.3636, time stamp: 0xf756190e
Exception code: 0xc0000005
Fault offset: 0x00000000000080a1
Faulting process ID: 0x34ac
Faulting application start time: 0x01dbf9becbf9d791
Faulting application path: (redacted)\XYplorer\XYplorer.exe
Faulting module path: C:\Windows\System32\srvcli.dll

[phred]

Is this enabled? If not, make it so.
Config > General > Safety Belts, Network > Network > Assume that mapped network drives are available.

[daniel_m]

Unfortunately, the Safety Belts don't make a difference. But I did some more troubleshooting and updated the OP.

[admin]

Don't have a NAS for testing, but generally I can't reproduce a crash when starting on an unavailable network path.

[daniel_m]

Hm, I tried several times now, and XY x64 crashes consistently when I unplug the network cable and try to access that network drive. So, it's not crashing on start-up, it's crashing when trying to access the disconnected network drive.

[admin]

No. Neither Win8.1 nor Win11. :\

[daniel_m]

No. Neither Win8.1 nor Win11. :\

Was this addressed at me? I forgot to mention that I am on Windows 10 (Pro).

I just tested this with a VirtualBox Windows 11 Pro guest, mapping a shared folder as a network drive. When I rename that folder on the host (while the guest is running and not accessing the drive), and I try to access the network drive with XYplorer on the guest, XYplorer crashes (using my custom settings, as well as a fresh installation). Trying to access the network drive with Windows Explorer, I get the expected "Location is not available" error without a crash.

Could shared folders in VirtualBox be an easy and convenient way for you to test network drives?

[admin]

See signature.

[daniel_m]

See signature.

I see ... and updated my profile (location and signature).
That said, as long as an issue/bug gets recognised, it doesn't matter if it takes longer to fix it because you might have other priorities. XYplorer crashing isn't exactly great, but people owning a NAS probably rarely disconnect it? Still, would a VM be a good (as in easy and inexpensive) way to test mapped network drives for you?

[admin]

Oh, I can test mapped network drives without problems, I just don't get the crash.

[daniel_m]

Ah. That's weird. But thanks for checking. I'll do some more testing with different betas and try x86 too.

[daniel_m]

Alright, here are results from testing a fresh copy of XYplorer. There was one sure way to reproduce a crash on Windows 10 and 11:

1) Make a new folder on a mapped network drive in XYplorer (fresh installation with default settings).
2) Enter the folder.
3) Shift-delete the folder in Windows Explorer.

=> The folder remains visible in XYplorer and clicking on it crashes XYplorer

crash.gif (638.84 KiB) Viewed 915 times

Remarks:

• The folder has to be deleted with "shift + del", even though Windows always deletes files from network drives "permanently", and the deletion dialogues for "del" and "shift + del" look identical!
• Several ways to access the non-existant folder in XYplorer lead to a crash: E.g. clicking on the folder in the tree pane, the breadcrumb bar, or refreshing the view (F5).
• Refreshing the tree (F4) makes XYplorer detect the folder missing, and jump to the parent folder without crashing.
• There are other ways to make a folder, e.g. in Windows Explorer instead of XYplorer, but they don't always lead to a crash.
• The bug does not occur on a local drive or a USB drive, at least not with the XYplorer default settings.
• When creating a new subfolder or a file within the deleted folder, XYplorer does not crash. It seems to tell the file system to create "\\network-path\New folder\New Text File.txt" as if "New folder" still existed, and the file system probably creates a new folder named "New folder", thus preventing a crash.
• With my settings, XYplorer actually shows an "Access is denied" error in the file pane, after the folder was shift-deleted in Windows Explorer. But it still crashes when trying to interact with the deleted folder as described above. This one might warrant its own bug report because it happened in the old x86 XYplorer too, but it never bothered me much. Now, I suspect that this could be connected the the current crashing bug. Even though I have auto-refresh enabled, including on network locations, the old x86 XYplorer (often) wouldn't remove a folder in the current view/path after it got deleted (within XYplorer itself). It would still be visible in the tree, and the file pane would show an "Access is denied" error (possibly the response from Samba being asked for a non-existant folder). Navigating to a different folder would work fine. Trying to interact with the deleted folder would then make that folder disappear, instead of crashing.
• I noticed something with the breadcrumb bar, and will write another comment soon ...

[daniel_m]

Okay, the breadcrumb bar was a false alarm. I got confused by it remembering deleted folders and thought that's why it could be connected to the crashing issue. E.g. creating "E:\New folder", navigating there, going back to E:\ will show "E: > New folder" in the breadcrumb bar, with "New folder" being grayed out. After deleting "New folder", the breadcrumb bar remains unchanged, showing "E: > New folder" with "New folder" still grayed out. But clicking onto "New folder" only shows "Location currently not available" instead of crashing.

The only weirdness I found is that XYplorer keeps the "New folder" for a network drive when navigating to another drive and back. Doing this on a local drive, navigating to a different drive and back, the "New folder" will be removed (although the breadcrumb bar still remembers the "New folder" and will show it again when creating a "New folder").

Sorry for this info dump...

[admin]

That helped! Should be fixed in next beta, thanks!

[daniel_m]

No more crashes indeed, thanks
I am always amazed at how quickly you pump out new builds.

Are you planning on doing more in the matter of shift-deleted folders? While XYplorer doesn't crash any more, the shift-deleted folder is still treated as if it existed. It does not get removed from the tree, and the only clue of it not existing is the error message in the file pane ("The system cannot find the path specified"). Refreshing with F5 does not remove the folder either when the deleted folder is the active folder. Only when navigating to another folder/drive does pressing F5 remove the deleted folder.

Again, using "shift + del" (in Windows Explorer) makes all the difference, with a "normal" deletion working as expected. I can only imagine that this issue is actually a bug in Windows handling "del" and "shift + del" differently, even though they both delete files permanently on network drives.

shift-delete.gif (784.94 KiB) Viewed 876 times

While we are discussing network shenanigans, I finally found out what was causing deleted folders to not get removed from the view:
"WatchDuringFileOp = 1"

I don't know why this tweak was set to 1 in my configuration, as I don't remember ever having touched it. And the "WatchIt" list is empty, so WatchDuringFileOp should not even do anything anyways?
This time around, the weirdness happens when the current folder gets "non-shift" deleted from the XYplorer tree on a network location. The file pane will show "Access is denied" indefinitely. Interacting with the deleted folder, or refreshing (F5), makes the error message change to "The system cannot find the path specified". Only then will XYplorer recognise the folder as deleted and remove it from the tree:

WatchDuringFileOp.gif (159.34 KiB) Viewed 876 times

I hope this is of interest to you. It might not affect anyone besides me, and I don't even need WatchDuringFileOp, but if the code for this tweak can affect other parts of XYplorer or if it is related to the detection of deleted folders on network drives, it could be beneficial to look at. Otherwise, I am very happy that the network crashes are gone