Repeat request now a plea

Features wanted...
admin
Site Admin
Posts: 64886
Joined: 22 May 2004 16:48
Location: Win8.1, Win10, Win11, all @100%
Contact:

Re: Repeat request now a plea

Post by admin »

Stefan wrote:1)
> (where, by the way, the caption
"Run" was changed to "Click").

Shouldn't this caption named at least "Left-Click"
to be associated with the Left-Click box in the edit dialog?


2)
just an note from an test,
This didn't work for me, the MSG shows just '$Icon' and not the path to the icl
and so the icon assignment didn't work too:

Code: Select all

 $Icon = "E:\a\xyplorer\Tools\ICONS\bird.icl"; 
"show icl path" msg $Icon;
"Go C:|"$Icon" /3"|1" goto "C:\";  //shown bold
"Go D:|"$Icon" /8"|2" goto "D:\";  //shown checked
"Go E:|"$Icon" /23"|3" goto "E:\";  //shown bold and checked
This works in AB:
::$Icon = "E:\a\xyplorer\Tools\ICONS\bird.icl"; msg $Icon;

Maybe it's by design?
1) Click defaults to Left-Click
2) A multi-script resource is just a collection of scripts; it's pre-parser.

jacky
XYwiki Master
Posts: 3106
Joined: 23 Aug 2005 22:25
Location: France
Contact:

Re: Repeat request now a plea

Post by jacky »

admin wrote:Indeed. That's because of the way I patch the original script to get a merged menu (I guess you have noted in Step mode that I introduced two new SCs to make it work... :wink: ). One day this will be optimized. :)
Two? Actually no, I noticed the userbutton command to left-click/right-click/edit indeed, but nothing else, and I'm too lazy to go look for the other one... ;)

Noticed something else with this whole ctxt menu thing, an actual bug this time: Let's say you have a script file (in your Scripts folder) and you put it as context menu of a CTB (file:filename). Then, if this script uses the command self things get messed up: 'file' returns an empty string, and 'path' returns the location of the running EXE and not the script file, etc (as if it wasn't a script file but an inline script?), which basically means no way to read the script file itself, open an INI in the same folder, etc -- i.e. the menu shows, but the script(s) don't work from there :?
Proud XYplorer Fanatic

admin
Site Admin
Posts: 64886
Joined: 22 May 2004 16:48
Location: Win8.1, Win10, Win11, all @100%
Contact:

Re: Repeat request now a plea

Post by admin »

jacky wrote:
admin wrote:Indeed. That's because of the way I patch the original script to get a merged menu (I guess you have noted in Step mode that I introduced two new SCs to make it work... :wink: ). One day this will be optimized. :)
Two? Actually no, I noticed the userbutton command to left-click/right-click/edit indeed, but nothing else, and I'm too lazy to go look for the other one... ;)

Noticed something else with this whole ctxt menu thing, an actual bug this time: Let's say you have a script file (in your Scripts folder) and you put it as context menu of a CTB (file:filename). Then, if this script uses the command self things get messed up: 'file' returns an empty string, and 'path' returns the location of the running EXE and not the script file, etc (as if it wasn't a script file but an inline script?), which basically means no way to read the script file itself, open an INI in the same folder, etc -- i.e. the menu shows, but the script(s) don't work from there :?
Yes, I noticed that too. Next version will work much better (also with Labels :D ).

EditToolbar is the other command. :)

admin
Site Admin
Posts: 64886
Joined: 22 May 2004 16:48
Location: Win8.1, Win10, Win11, all @100%
Contact:

Re: Repeat request now a plea

Post by admin »

Muroph wrote:
admin wrote:Combining load with a merged menu would be too much work for now, but I'm working on a special syntax to read a file before creating menu. Something like file:XYplorer Automatic Updater.
this doesn't work with one of my scripts (specifically, the comments script), nor does pasting the whole script in the CTB "right-click" field.
that script generates the menu using variables, so it MUST execute some commands BEFORE displaying the menu (using a load command).
all i get on the context menu is one item with the main subscript's caption.
clicking on that item will load the real menu.
i believe this would also happen with any script that tries to use the new checked and disabled flags, since they, too, have to be applied by the script before the menu is loaded.

it works well with "normal" scripts, tho.
thanks! :D
It should work with all scripts in the next version...

aurumdigitus
Posts: 1075
Joined: 30 May 2008 21:02
Location: Lake Erie

Re: Repeat request now a plea

Post by aurumdigitus »

Site Admin wrote:Your plea softened my heart. I added a button.
With celerity what a mighty tree has grown from a small planted seed. :!:

jacky
XYwiki Master
Posts: 3106
Joined: 23 Aug 2005 22:25
Location: France
Contact:

Re: Repeat request now a plea

Post by jacky »

admin wrote:Yes, I noticed that too. Next version will work much better (also with Labels :D ).
Does; great work! :D
admin wrote:EditToolbar is the other command. :)
Of course, silly me! Now with all that we're almost to the point where a script could define/add a new CTB to one's toolbar... :wink:
Stefan wrote:E:\a\xyplorer\Tools\computer.icl /3
So this syntax (with the index) doesn't work for scripts menus, only CTBs? Any reason why?
Also, if possible, I guess it'd be nice to have a way to access XY's own icons (e.g. we could use "xytb /qfv" to use the icons for TB button QFV)
Proud XYplorer Fanatic

Muroph
Posts: 561
Joined: 21 Aug 2007 16:13

Re: Repeat request now a plea

Post by Muroph »

admin wrote:It should work with all scripts in the next version...
i still can't make it work. :(
i think the reason is this:

Code: Select all

If the file contains only one script, it is not executed directly
      (as it would be in a "non-Right-Click" load statement) but shown
      in the menu.
it does contain only one script, and it's that script that creates the menu.

i'll see if i can do anything about it.
My shared scripts:
TeraCopy Integration, Tag Manager, Comments Menu, Text Replacer, Image and Media Tools, Checksum Calculator, Video Calculator
only 5 URLs are allowed on the sig...

admin
Site Admin
Posts: 64886
Joined: 22 May 2004 16:48
Location: Win8.1, Win10, Win11, all @100%
Contact:

Re: Repeat request now a plea

Post by admin »

jacky wrote:
Stefan wrote:E:\a\xyplorer\Tools\computer.icl /3
So this syntax (with the index) doesn't work for scripts menus, only CTBs? Any reason why?
Also, if possible, I guess it'd be nice to have a way to access XY's own icons (e.g. we could use "xytb /qfv" to use the icons for TB button QFV)
this syntax is not even officially supported :wink:

"xytb /qfv" or so, yes that's doable. It will even make a little more sense once I have added the new SC Button which allows you to press buttons without touching them, even when they are not part of the current toolbar! :mrgreen:

jacky
XYwiki Master
Posts: 3106
Joined: 23 Aug 2005 22:25
Location: France
Contact:

Re: Repeat request now a plea

Post by jacky »

admin wrote:this syntax is not even officially supported :wink:
Oh... that would explain why I found no mention of it in the changelog then :idea: Well, it could be unofficially supported within script files/menus as well... ;)
Proud XYplorer Fanatic

serendipity
Posts: 3360
Joined: 07 May 2007 18:14
Location: NJ/NY

Re: Repeat request now a plea

Post by serendipity »

jacky wrote:
admin wrote:this syntax is not even officially supported :wink:
Oh... that would explain why I found no mention of it in the changelog then :idea: Well, it could be unofficially supported within script files/menus as well... ;)
Yes, I would use this too.

Muroph
Posts: 561
Joined: 21 Aug 2007 16:13

Re: Repeat request now a plea

Post by Muroph »

Muroph wrote:i'll see if i can do anything about it.
well, i managed to make it worse.
the standard commands disappeared from the context menu.
now i can't even edit that CTB anymore. :|
My shared scripts:
TeraCopy Integration, Tag Manager, Comments Menu, Text Replacer, Image and Media Tools, Checksum Calculator, Video Calculator
only 5 URLs are allowed on the sig...

admin
Site Admin
Posts: 64886
Joined: 22 May 2004 16:48
Location: Win8.1, Win10, Win11, all @100%
Contact:

Re: Repeat request now a plea

Post by admin »

Muroph wrote:
Muroph wrote:i'll see if i can do anything about it.
well, i managed to make it worse.
the standard commands disappeared from the context menu.
now i can't even edit that CTB anymore. :|
Ah, please send me the button definition. Grab it from the INI section [CustomButtons].

admin
Site Admin
Posts: 64886
Joined: 22 May 2004 16:48
Location: Win8.1, Win10, Win11, all @100%
Contact:

Re: Repeat request now a plea

Post by admin »

aurumdigitus wrote:
Site Admin wrote:Your plea softened my heart. I added a button.
With celerity what a mighty tree has grown from a small planted seed. :!:
Absolutely! :D My current favorite feature. Thanks for the inspiration.

Muroph
Posts: 561
Joined: 21 Aug 2007 16:13

Re: Repeat request now a plea

Post by Muroph »

admin wrote:Ah, please send me the button definition. Grab it from the INI section [CustomButtons].
no need to anymore, i found the problem.
my script ended with an open comment block (i.e. a /* without */).
the standard icons came back after fixing that.

no luck making the script's menu load, tho.
My shared scripts:
TeraCopy Integration, Tag Manager, Comments Menu, Text Replacer, Image and Media Tools, Checksum Calculator, Video Calculator
only 5 URLs are allowed on the sig...

admin
Site Admin
Posts: 64886
Joined: 22 May 2004 16:48
Location: Win8.1, Win10, Win11, all @100%
Contact:

Re: Repeat request now a plea

Post by admin »

Muroph wrote:
admin wrote:Ah, please send me the button definition. Grab it from the INI section [CustomButtons].
no need to anymore, i found the problem.
my script ended with an open comment block (i.e. a /* without */).
Anyway, this should not happen anymore with the recent release.

Post Reply