Find Files

jacky · Post by **jacky** » 08 Sep 2006 01:19

jacky wrote:hmm.. Yeah seems that the history needs to have a Back and then Forward to actually "go back", sounds like a bug to me

The new F7 trick is great. But I stil agree with me

and think that when we start a search, the History should also be updated, so that doing "Back" would do the same. (and I could do it with the TB button!

)
ie. I start in D:\ then go in D:\Folder then go to E:\SomewhereElse and then start a search. In the history, last location was D:\Folder when, I think, it should be E:\SomewhereElse !

Thus, hitting back would really get us back and not forgetting our actual last location.
Right now when we go to our next location, let's say F:\Last, then the history is updated. Yeah, but as stated before, it means that to go back we have to hit Back, and then hit Forward to actually have only "gone Back" where we were, as the History got updated late !!

I think it means, update the history when we "leave" the location for a tab in Finding mode (could be the same tab or another, could be a new search or not), not when we go to another Browsing location. I mean after all, yes the location is still on the tab (if we use another one for results, or in its Browsing mode), but when we change the active tabs it's the same (ie all locations are still there on other tabs), but then the History is updated!

Post by **admin** » 08 Sep 2006 08:36

RalphM wrote:
admin wrote:Well, I said F3, F7, F3, F7..., not F7, F3, F7, F3...

F3: search the current location
F7: go back to the last browsed location

F3 results always in find mode
F7 results always in browse mode
And never leave the tab in find mode or you loose this functionality
When switching to a find tab, the search location doesn't get the focus in the tree, so with F7 you end up browsing the location of your last visited browse tab
That's true even with "Synchronize tree with search location" switched on, so I'd say it's a bug.
And on a side note: You end up with two browse tabs pointing to the same folder

Hm, yes, damn it, you're right. There's something to be done.

So what should F7 do? Let's try a new definition: F7 goes back to the previous state. What's a state? Three properties:
- State 1: a location; a tab; a mode (browse or find)
- Action: click or press anything -> enter State 2:
- State 2: a location; a tab; a mode (browse or find)
Any one, two, or three properties may have changed by that one action. Whatever happened, F7 should bring you back to State 1 (so, it could even trigger a search!). Okay?

RalphM · Post by **RalphM** » 08 Sep 2006 09:11

admin wrote:Hm, yes, damn it, you're right. There's something to be done.

So what should F7 do? Let's try a new definition: F7 goes back to the previous state. What's a state? Three properties:
- State 1: a location; a tab; a mode (browse or find)
- Action: click or press anything -> enter State 2:
- State 2: a location; a tab; a mode (browse or find)
Any one, two, or three properties may have changed by that one action. Whatever happened, F7 should bring you back to State 1 (so, it could even trigger a search!). Okay?

Doesn't it make sense to solve the bug rather by just focussing the folder of the search location in the tree properly ("Synchronize tree with search location").
I'd say that would do the trick...

Post by **admin** » 08 Sep 2006 14:35

jacky wrote:
jacky wrote:hmm.. Yeah seems that the history needs to have a Back and then Forward to actually "go back", sounds like a bug to me
The new F7 trick is great. But I stil agree with me and think that when we start a search, the History should also be updated, so that doing "Back" would do the same...

I will not add searches to the history. It will remain a history of browsing locations. However, I solved the issue at hand like this:

Code: Select all

    * History: if currently in find mode, then clicking "back" or 
      "forward" will not move in history but re-enter browse mode at the 
      current history position.

jacky · Post by **jacky** » 08 Sep 2006 16:59

admin wrote:I will not add searches to the history. It will remain a history of browsing locations.

Oh I never wanted you to add searches to the history, hell no!

But, that when we start a search, the location we were in just before we started the search be added then (ie when we start the search) instead of when we "open" another browse location.

Try this:
1. go to Folder1
2. go to Folder2
3. start a search in Folder3 (eg. Ctrl+G, :Folder3?* /)
4. look at the history. Last location is Folder1. I say no, it should be Folder2 !! Right now, hitting "Back" means going to Folder1 and having Folder2 then added to the History, making it available by hitting hit Forward!

That simply does not make sense!! And, to me, is a bug.
And I don't think your fix would work right, since as I understand it, now hitting back we get me to Folder3. Well, no. I was never in Folder3 (as a browse location), but in Folder2! Let me go back in Folder2 please!

Post by **admin** » 08 Sep 2006 17:05

jacky wrote:Let me go back in Folder2 please!

But that's what my fix does! Wait till you see it...

Post by **admin** » 09 Sep 2006 13:27

RalphM wrote:
admin wrote:Well, I said F3, F7, F3, F7..., not F7, F3, F7, F3...

F3: search the current location
F7: go back to the last browsed location

F3 results always in find mode
F7 results always in browse mode
And never leave the tab in find mode or you loose this functionality
When switching to a find tab, the search location doesn't get the focus in the tree, so with F7 you end up browsing the location of your last visited browse tab
That's true even with "Synchronize tree with search location" switched on, so I'd say it's a bug.
And on a side note: You end up with two browse tabs pointing to the same folder

I completely rewrote F7. It's much better now, but surely you'll find something that's bugging you...

RalphM · Post by **RalphM** » 09 Sep 2006 21:02

Well F7 still does the trick only, if you stay within the same tab, but after you switched to another tab, it switches between that tab and the find in the first tab. Quite as expected I guess.
Since the config option "Synchronice tree with search location" works as expected now, one is just one click away from browsing the search location again, which sounds fair to me, since I'm rather the mouse person anyway. If there might be further complaints about F7, the keyboard people will have 'em I think.

Post by **admin** » 09 Sep 2006 21:16

RalphM wrote:Well F7 still does the trick only, if you stay within the same tab, but after you switched to another tab, it switches between that tab and the find in the first tab. Quite as expected I guess.

Exactly. What "trick" are you referring to? I can't see any bug here anymore.

jacky · Post by **jacky** » 09 Sep 2006 22:26

admin wrote:
jacky wrote:Let me go back in Folder2 please!
But that's what my fix does! Wait till you see it...

Yes it does! Great work, once again!

RalphM · Post by **RalphM** » 09 Sep 2006 22:54

admin wrote:Exactly. What "trick" are you referring to? I can't see any bug here anymore.

I was talking about the trick of switching between find and browse mode of the location defined in "Search location", but as mentioned, I'm fine with the current way it works.