XYplorer Beta Club

serendipity wrote:I think left click should be made to work like how other apps have it (undo last action). To undo something i dont want to click twice, i.e first click will pop up the the list and second click will undo. I would prefer that action to be assigned to right-click. my 2 cents.

Agreed, but having it undo the next-to-last (when last can't be undone) without any warning is what I see as a defect in WE as one may think they are undoing something else, like the actual last.

But having that warning be optional is also a valid request, I guess.

Okay I now have a dropdown "On Undo" with the following options:

1 Always prompt before undoing the last action
2 Prompt if the last action cannot be undone (and offer the last action the can be undone)
3 Undo the last action that can be undone (WE style)

Factory default on 2.

Okay everybody?

I'm still thinking about jacky's #4. Since jacky is always right I'm sure I will add that somewhere...

serendipity wrote:I think left click should be made to work like how other apps have it (undo last action). To undo something i dont want to click twice, i.e first click will pop up the the list and second click will undo. I would prefer that action to be assigned to right-click. my 2 cents.

I think you misunderstood me : I meant that a left click on the button should indeed undo the last action without the need for another click. But, if that last action cannot be undone (e.g. delete no recycle) then instead of doing nothing, undoing the action before last, or some (annoying) popup, then the dropdown menu would be shown (as if we had clicked on the little arrow on the side) presenting the list of actions, first of which being our delete, disabled since it cannot be undone.

That way undo is a one-click action, and when it can't be done we are immediately presented with the list of actions and "silently asked" what to do, with the possibility of choosing which action to undo.

jacky wrote:

serendipity wrote:I think left click should be made to work like how other apps have it (undo last action). To undo something i dont want to click twice, i.e first click will pop up the the list and second click will undo. I would prefer that action to be assigned to right-click. my 2 cents.

I think you misunderstood me : I meant that a left click on the button should indeed undo the last action without the need for another click. But, if that last action cannot be undone (e.g. delete no recycle) then instead of doing nothing, undoing the action before last, or some (annoying) popup, then the dropdown menu would be shown (as if we had clicked on the little arrow on the side) presenting the list of actions, first of which being our delete, disabled since it cannot be undone.

That way undo is a one-click action, and when it can't be done we are immediately presented with the list of actions and "silently asked" what to do, with the possibility of choosing which action to undo.

That's pure genius, monsieur.

admin wrote:Okay I now have a dropdown "On Undo" with the following options:
1 Always prompt before undoing the last action
2 Prompt if the last action cannot be undone (and offer the last action the can be undone)
3 Undo the last action that can be undone (WE style)

Factory default on 2.

Okay everybody?

I'm still thinking about jacky's #4. Since jacky is always right I'm sure I will add that somewhere...

I thought about this some more. I think, #3 might not be used that much at all. Consider this:
A) I move GB worth of data somewhere
B) Delete a file without recycling.

The option #3 will simply move back all my data, which is crazy. With unknown consequences lurking around, do you think anyone will ever choose this option? I vote for Jacky's option instead.

serendipity wrote:

admin wrote:Okay I now have a dropdown "On Undo" with the following options:
1 Always prompt before undoing the last action
2 Prompt if the last action cannot be undone (and offer the last action the can be undone)
3 Undo the last action that can be undone (WE style)

Factory default on 2.

Okay everybody?

I'm still thinking about jacky's #4. Since jacky is always right I'm sure I will add that somewhere...

I thought about this some more. I think, #3 might not be used that much at all. Consider this:
A) I move GB worth of data somewhere
B) Delete a file without recycling.

The option #3 will simply move back all my data, which is crazy. Which unknown consequences lurking around, do you think anyone will ever choose this option? I vote for Jacky's option instead.

Yep, right. Interestingly Explorer follows this crazy way...

admin wrote:Interestingly Explorer follows this crazy way...

For me: crazy and silly.

Sometimes in this thread I'm not shure if all noted that there should be 2 functions: "undo last" and "show undo list".
"undo last" should do what it says - never undo second last. But Jackys Idea with showing the list, when "undo last" isn't possible, seems very good to me.

PS: as in serendipity's example of undoing the unexpected thing should strongly be avoided! Exactly what I want to say!

PeterH wrote: But Jackys Idea with showing the list, when "undo last" isn't possible, seems very good to me.

Yes, I agree with the "auto convert to right-click" idea, but would suggest, as jacky did somewhat, that in this case the icon be different so that one can also see via the TB an 'last undo' isn't possible.

j_c_hallgren wrote:

PeterH wrote: But Jackys Idea with showing the list, when "undo last" isn't possible, seems very good to me.

Yes, I agree with the "auto convert to right-click" idea, but would suggest, as jacky did somewhat, that in this case the icon be different so that one can also see via the TB an 'last undo' isn't possible.

Yes, it will get an overlay array like the other buttons that pop a menu on left click.

Now, with jacky's refinement (which does not have to be optional) I see only one option left here for On undo:
[ ] Always prompt before undoing an action (dialog: sure to undo...)

I think this prompt should only come on a left click on the button or on Ctrl+Z, but not when selecting an action via the popup or via the action log dialog.

Out of all the options given in the very first post, I prefer option number three (3), because it offers the most flexibility. While being flexible, the Undo process should not be complicated. I also think that a log of all the "Undoable" operations would be nice (in a form of a slide-out list or a right-click menu of a TB), but being prompted if a user wishes to Undo every time is over the top (unless such prompts can be disabled, should be like that by default).

Question: will Undo be able to undo the last script that I ran or will it undo the last operation of that script? For example, I have a script that extracts files from archives into a new folder, does some renaming, then moving and finally deletion of the original folder so there's lots going on. I'm curious to find out how XY's Undo will handle this situation.

zer0 wrote:Question: will Undo be able to undo the last script that I ran or will it undo the last operation of that script? For example, I have a script that extracts files from archives into a new folder, does some renaming, then moving and finally deletion of the original folder so there's lots going on. I'm curious to find out how XY's Undo will handle this situation.

In theory most file operations should be undoable, no matter whether by script or otherwise. It will take a little to make it perfect though.

admin wrote:In theory most file operations should be undoable, no matter whether by script or otherwise. It will take a little to make it perfect though.

Yes, this is logical. Another question for further clarification: "Will those operations need to be undone individually or will it be possible to undo them all by clicking something like "Undo last script"?" I'd expect the former to be provided out-of-the-box, but with simplicity in mind I'd like to see the latter be added too

zer0 wrote:

admin wrote:In theory most file operations should be undoable, no matter whether by script or otherwise. It will take a little to make it perfect though.

Yes, this is logical. Another question for further clarification: "Will those operations need to be undone individually or will it be possible to undo them all by clicking something like "Undo last script"?" I'd expect the former to be provided out-of-the-box, but with simplicity in mind I'd like to see the latter be added too

No, "Undo last script" would be a very bold promise. On this level Undo is not realistic. You can however use the action log to undo a bunch of sequential actions in one go.

admin wrote:You can however use the action log to undo a bunch of sequential actions in one go.

Have you given any consideration into making it such that we can also generate macros or scripts from the action log? (Assuming you've made it so that it could be detailed enough to do so.)

I think most of us can get by with just scripting it out, but it would provide a unique feature to those less interested in "programming," and would bring that same power to more users.

TheQwerty wrote:

admin wrote:You can however use the action log to undo a bunch of sequential actions in one go.

Have you given any consideration into making it such that we can also generate macros or scripts from the action log? (Assuming you've made it so that it could be detailed enough to do so.)

I think most of us can get by with just scripting it out, but it would provide a unique feature to those less interested in "programming," and would bring that same power to more users.

Any refinements should come at a later stage. It's tough enough to get the basics going, and they are already very hot stuff.