[fixed in 24.50.0204] Custom File Icons not working on all drives

[daniel_m]

I love the Custom File Icons feature for empty folders (*\ /e><xy> /5). For some reason, it only works on two of my local drives, but not on three other local drives and one network drive.

A test with "::fresh;" or using a custom icon didn't make a difference.

Is there anything else I can do to debug this behaviour?

[jupe]

To match network drives too you would have to use /en instead. On the other local disks, are you 100% sure the folders are empty that you are checking, and don't have something like a hidden desktop.ini file.

[daniel_m]

Thanks. Unfortunately, "*\ /en><xy> /5" doesn't work on my mapped network drive either.
And yes, i am 100% sure the folders are empty. I made new folders for testing purposes.

[jupe]

Just out of interest, since you say you tested in fresh with I assume only that single CFI entry enabled, and I am not sure this would even be relevant, but just to give extra info to admin, what file system are the non working disks? Here is a quick script if you want to post the results.

$r = ""; foreach($d, <get drives>) { $r .= $d . get("filesystem", $d) . <crlf>; } text $r;

[daniel_m]

They are all NTFS:

C:\NTFS
D:\NTFS
E:\NTFS
G:\NTFS
H:\NTFS
Q:\NTFS

C, D, E, and G are SATA SSDs, H is a dynamic volume comprised of 2 SATA HDDs, and Q is a mapped network drive.

The custom file icons work on C and H. I don't see a pattern here ...

[admin]

Weird! Is it the same with access denied folders? ("*\ /xn><xy> /5")

[daniel_m]

Access denied folders for the "System Volume Information" folder works on C, D, E, but not on G, H, and Q. I tried to enter this folder on all drives, and XYplorer shows me the expected "Access is denied." error message for all of them.

I created a new folder on H, disabled inheritance, and removed all principals except "system" from the security settings. This folder gets flagged as "access denied folder" (/xn) by XYplorer. This new folder and the System Volume Information folder have the same owner (Administrators) and the same permissions (the only principal is system, which has full control).

Access denied seems to work differently on my network drive. Windows doesn't let me change the security settings for files and folders on this drive. But I can remove read access from within the UI of my NAS. Doing so, I get the expected "Access is denied." error message from XYplorer when I try to open a folder without read access. But the custom file icon for /xn does not work for this folder either.

[admin]

In the next beta, try this script on your folder path and show us the results:

Code: Select all

exist "your_folder_path";

For example:

Code: Select all

exist "C:\Users\Donald\AppData\Local\ElevatedDiagnostics";

[daniel_m]

Thanks for looking into this
I posted the full output of "exist" for working and non-working folder below. The only difference between the different folders (on local drives) is GetFileAttributes:

Not working:
G:\System Volume Information => GetFileAttributes: 0x816 (2070)
H:\System Volume Information => GetFileAttributes: 0x816 (2070)
Q:\New Folder => GetFileAttributes: 0x10 (16) (mapped network drive)

Working:
H:\New Folder => GetFileAttributes: 0x2010 (8208)
C:\System Volume Information => GetFileAttributes: 0x16 (22)
D:\System Volume Information => GetFileAttributes: 0x16 (22)
E:\System Volume Information => GetFileAttributes: 0x16 (22)


Access denied folder icon working for "H:\New Folder":

Code: Select all

XYplorer 24.50.0201  -  Windows 10 Pro N, 64-bit, Version 22H2, Build 19045.2965 (10.0)  -  2023-06-20 14:57:14

Path: H:\New Folder
Real Path: H:\New Folder

ExistFile: False
ExistPath: True
ExistFolder: True
ExistItemFF: True
ExistPathFF: False (Access is denied.)
ExistPathOrFile: True
ExistPathOrFileShell: True
ExistDrive: True
ExistIcon: True

HasFolderContents: False -  Error 5: Access is denied.

IsNetworkLocation: False
GetDriveType: 3 (DRIVE_FIXED)
GetItemType: 2
GetFileAttributes: 0x2010 (8208)
Owner: 
IsDriveHidden: False/False, ShowHiddenDrives: 0, HideDrivesByLetter: 
This path available in Tree: True
Current node available in Tree: True
Watchable: True

LockedTree: 0, MiniTree: 0, MiniTreeVerifyOnSelect: 0, TreeSkipVerifyOnSelect: 0, FilenamesCaseSensitive: 0

FastNetworkEnumeration: 1, AssumeServersExist: 1, PrecheckServers: 0, CacheServers: 1
CheckServerMethod: 0, CheckServer3: 0, NetworkCapsCheck: 0, ShowAllServers: 0, ShowHiddenShares: 0

No access denied folder icon shown for "H:\System Volume Information":

Code: Select all

XYplorer 24.50.0201  -  Windows 10 Pro N, 64-bit, Version 22H2, Build 19045.2965 (10.0)  -  2023-06-20 14:57:53

Path: H:\System Volume Information
Real Path: H:\System Volume Information

ExistFile: False
ExistPath: True
ExistFolder: True
ExistItemFF: True
ExistPathFF: False (Access is denied.)
ExistPathOrFile: True
ExistPathOrFileShell: True
ExistDrive: True
ExistIcon: True

HasFolderContents: False -  Error 5: Access is denied.

IsNetworkLocation: False
GetDriveType: 3 (DRIVE_FIXED)
GetItemType: 2
GetFileAttributes: 0x816 (2070)
Owner: 
IsDriveHidden: False/False, ShowHiddenDrives: 0, HideDrivesByLetter: 
This path available in Tree: True
Current node available in Tree: True
Watchable: True

LockedTree: 0, MiniTree: 0, MiniTreeVerifyOnSelect: 0, TreeSkipVerifyOnSelect: 0, FilenamesCaseSensitive: 0

FastNetworkEnumeration: 1, AssumeServersExist: 1, PrecheckServers: 0, CacheServers: 1
CheckServerMethod: 0, CheckServer3: 0, NetworkCapsCheck: 0, ShowAllServers: 0, ShowHiddenShares: 0

No access denied folder icon shown for "Q:\New Folder":

Code: Select all

XYplorer 24.50.0201  -  Windows 10 Pro N, 64-bit, Version 22H2, Build 19045.2965 (10.0)  -  2023-06-20 15:00:40

Path: Q:\New Folder
Real Path: Q:\New Folder

ExistFile: False
ExistPath: True
ExistFolder: True
ExistItemFF: True
ExistPathFF: False (An unexpected network error occurred.)
ExistPathOrFile: True
ExistPathOrFileShell: True
ExistDrive: True
ExistIcon: True

HasFolderContents: False -  Error 59: An unexpected network error occurred.

IsNetworkLocation: True
GetDriveType: 4 (DRIVE_REMOTE)
GetItemType: 2
GetFileAttributes: 0x10 (16)
Owner: 
IsDriveHidden: False/False, ShowHiddenDrives: 0, HideDrivesByLetter: 
This path available in Tree: True
Current node available in Tree: True
Watchable: True
Mapped: \\192.168.1.250\VoidZ2

LockedTree: 0, MiniTree: 0, MiniTreeVerifyOnSelect: 0, TreeSkipVerifyOnSelect: 0, FilenamesCaseSensitive: 0

FastNetworkEnumeration: 1, AssumeServersExist: 1, PrecheckServers: 0, CacheServers: 1
CheckServerMethod: 0, CheckServer3: 0, NetworkCapsCheck: 0, ShowAllServers: 0, ShowHiddenShares: 0

[admin]

The 3rd one is "Error 59: An unexpected network error occurred." That explains it, and can fix that.

But the 2nd one looks totally normal. Sure it does not work?

* * *

What about Empty Folders that don't work?

[admin]

I have a different idea now. What is the normal icon (non Custom File Icons) for these folders? Is it maybe not the default folder icon?

[daniel_m]

Yes, I double and triple checked. But, I will try the #1 IT advice: Switching the computer off and on again ... and report back.

Regarding empty folders:

Working:
H:\New Folder-01 => GetFileAttributes: 0x2010 (8208)
H:\_BluetoothExchangeFolder\New Folder => GetFileAttributes: 0x10 (16)
C:\New Folder => GetFileAttributes: 0x2010 (8208)
C:\PerfLogs => GetFileAttributes: 0x2010 (8208)

Not working:
G:\New Folder => GetFileAttributes: 0x2810 (10256)
G:\Games\GOG\!Downloads\temp => GetFileAttributes: 0x2810 (10256)
E:\Games\Steam\steamapps\temp\310560 => GetFileAttributes: 0x810 (2064)
D:\New Folder => GetFileAttributes: 0x2810 (10256)

(Same with "::fresh;")

[admin]

Next beta will show the normal icon index in "exist".

* * *

What about this line when Empty Folder does not work?

Code: Select all

HasFolderContents: False -  Error 59: An unexpected network error occurred.

[admin]

Do you get any Custom File Icons on these drives?

[daniel_m]

Sorry, I forgot to add that I did not customise icons in Windows, and I don't use any other custom icons in XYplorer.

For an empty folder on my network drive with read access for XYplorer, I get "HasFolderContents: False" without any unexpected network errors.

Rebooting did not change anything.

I will try out more custom file icons (have to learn how first ) and try out the next beta, and report back afterwards.