Click rename behavior when giving focus back to XYplorer window

[elqasar2]

So clicking on white space should deselect all the selected files but clicking on one of the selected files should NOT deselect all the other files except the one you're clicking on (current behavior)? This is neither intuitive nor consistent...

No, that is not what I said. I suggest re-reading the thread. Stop interfering for no reason and start your own thread for other things.

23.60 and 23.60.0001 made major improvements to long-standing focus-related issues with XYplorer, and if you didn't even notice the improvements (as is evident by you questioning whether they were "worth it") then I can hardly take you seriously when it comes to usability matters.

[admin]

The way it currently works may be undesired but IMO it's not unexpected. It feels right to me.

[elqasar2]

An even better illustration of this problem is if you have multiple files selected, pop the context menu for them, change your mind, and then click on any of the files. Desired behavior would be to go back to having the files still selected. What happens in 23.60.0006 is that just the file you clicked on becomes selected.

Thank you Don for mostly implementing in 23.60.0008 what I was asking for here in this thread. Despite Evolve being so vehemently opposed at the time. Now the behavior I was wanting, which is for the selection to be maintained when clicking back on a single file is at least maintained when clicking away from a menu or when giving focus back to the list.

It's still not clear to me why we can have this new behavior when clicking away from a menu, but not when clicking away from a context menu (whether that context menu be triggered directly on a file or triggered on the whitespace in the list). In my mind, the behavior should be consistent for menu and context menu, but anyway what was done in 23.60.0008 was an improvement and I'll take what I can get.

Just to make it even more clear, here is the current situation in 23.60.0008:

When a single file is selected:

Action: Click on any menu (e.g. Tools, Window, etc.) and then close the menu by clicking on the single file that was selected.
Result: File stays selected (as expected and desired by me).

Action: Right click in whitespace to pop a context menu and then close the menu by clicking on the single file that was selected.
Result: Inline rename (undesired). I would prefer that the file stays selected.

When multiple files are selected:

Action: Click on any menu (e.g. Tools, Window, etc.) and then close the menu by clicking on any of the files that were selected.
Result: All the files remain selected (as expected and desired by me).

Action: Right click in whitespace to pop a context menu and then close the menu by clicking on any of the files that were selected.
Result: The multiple selection is lost (undesired). I would prefer that all the files remain selected.


Even shorter summary: I believe that closing a context menu should have the same result as closing a toolbar menu.

[admin]

Agreed. It's not like that in File Explorer. Main menus and context menus are treated differently here.

[elqasar2]

Agreed. It's not like that in File Explorer. Main menus and context menus are treated differently here.

I know. File Explorer does several things differently. But it does them worse. Surely there is the opportunity to do things better in XYplorer.

Already, several of the recent changes in XYplorer make it behave differently (but better) than File Explorer. For example, in File Explorer if you have multiple items selected, then focus on another application, then click back in File Explorer, the multiple selection is lost. That is crap. So in that regard XYplorer now does a much better job than File Explorer, by maintaining the selection. Selections are more "sticky" you could say. Why can't XYplorer also be more "sticky" for selections when it comes to context menus?

[admin]

In case of shell context menus the menu is directly tied to the selection, it is determined by the selection. When the menu is shown I expect to be able to right-click another file to show its menu. So that right-click must be able to change the selection. And if a right-click can do that, the left-click should as well.

[elqasar2]

In case of shell context menus the menu is directly tied to the selection, it is determined by the selection. When the menu is shown I expect to be able to right-click another file to show its menu. So that right-click must be able to change the selection. And if a right-click can do that, the left-click should as well.

OK.

But there is now a new, different issue just introduced in 23.60.0009. When there is nothing selected in the List, and focus is on another application, clicking on a file in the List (to give focus to XYplorer and select that file) only focuses XYplorer. That file doesn't get selected (like it would, for example, if you were in the 2nd Pane and you then clicked across to a file in the 1st Pane when nothing is selected there). You can see the issue in the animated GIF I just posted in another thread, where the first click on the first file is just ignored by XYplorer.

[elqasar2]

Just to add some further clarity to my previous post: Switching between Panes works perfectly and exactly as expected when the XYplorer application window already has focus.

Action: Activate the unfocused Pane by clicking on whitespace
Result: The selection is maintained

Action: Activate the unfocused Pane by clicking on a selected file or group of selected files
Result: The selection is maintained

Action: Activate the unfocused Pane by clicking directly on a non-selected file
Result: That file becomes the new selection

So the above is great, and it's what currently happens when switching between Panes while the XYplorer window has focus. It's also exactly how it used to work when switching focus between an XYplorer Pane and a different application for a few versions prior to v23.60.0009. But unfortunately that became broken in v23.60.0009. Now, when the XYplorer main window doesn't have focus, if you click directly on a non-selected file in one of XYplorer's panes, that file is not selected.

[admin]

OK, I agree.

I changed it and now it's like this:

Code: Select all

      ------------------------------------------------------------------------
      State                   Action             Selections     Item Focus
      ------------------------------------------------------------------------
      Popup Menu Shown        Click Selected     Unchanged      Unchanged
                              Click Unselected   Unchanged      Unchanged
                              Click White        Unchanged      Unchanged
                               
      Focus In Other Control  Click Selected     Unchanged      Clicked One
                              Click Unselected   Clicked One    Clicked One
                              Click White        Unchanged      Unchanged
      
      Focus In Other App      (same as Focus In Other Control)
      
      List Context Menu Shown Click Selected     Clicked One    Clicked One
                              Click Unselected   Clicked One    Clicked One
                              Click White        Lost           Unchanged
      
      Focus In List           (same as List Context Menu Shown)
      ------------------------------------------------------------------------

[elqasar2]

Sounds good!

[elqasar2]

OK, I've tested 23.60.0011 and it's looking very good. 99.99% there. Just one tiny bug I found:

When focus is on another app, and you click directly on a non-selected file in the non-active pane, it doesn't get selected.

[admin]

That 0.01% comes next.

[elqasar2]

I've just installed 23.60.0013 and have only used it for a few seconds, but already I see that when focus is on some other app and then I click a selected file in XYplorer it results in inline rename rather than leaving the selection as is. Think it's best to test the table of possible actions/results discussed yesterday -- already the very first test I did in seconds is discouraging.

btw - it happens only when clicking back to the active pane, not the inactive pane.

edit - and multiple selections in active pane are lost when other app is focused and you then click on one of the selected. Yeah, the whole table of possibilities needs to be tested when switching from XY to other app and then coming back to active pane and inactive pane.

[admin]

No problem, easy fix.