Live Filter Highlight Matches not working

[jupe]

I noticed that the Live Filter Highlight Matches option doesn't seem to be functioning anymore, in addition, when using get('spotpatterns') the live filter query is returned by it when the Highlight Matches option is enabled, I am not sure it should, because you can get the live filter query by other means, but not the manually entered spot patterns.

[highend]

It was last working in 21.30.0022
Couldn't test 0023 + 0024 because of the overflow error
but in 21.30.0025 it isn't working anymore

[admin]

Indeed. That's since 20201209 where I did some reordering for CEA. Fixed in next beta.

[jupe]

Highlight matches seems to work again in 21.40.0001 but what about the spot patterns being overwritten with the live filter query when highlight matches is switched on, is that correct? It makes it so you can no longer easily get the last entered spot pattern if you use live filter afterwards/switch to a live filtered tab.

[admin]

Has it been different before? I don't think so.

[jupe]

No it has probably been like this since Highlight matches was implemented for LF, but does that mean it isn't an issue? It makes get('spotpatterns') pretty useless if you have highlight matches enabled and use the live filter. Anyway I can work around it if you don't see it as being an issue.

[admin]

I agree. (My question was just meant to ensure that it has not been a recent regression.)

Spot patterns are extremely volatile, they are not saved across sessions, tabs, or even list refresh events. Applying a Live Filter currently involves a list refresh, so the spot patterns are gone. Additionally, the Live Filter highlighting uses the same code as the spot patterns, so it overwrites what is returned by get('spotpatterns').

So far the talking to myself. Yes, this can be improved. Maybe spot patterns should survive a Live Filter toggle?

[jupe]

From my point of view, I am not fussed about the visual highlighting of the spot pattern being lost when using LF, but I think you should still be able to retrieve the last used spot pattern with that function instead of the last used LF query, but I realise it may be tricky if live filter highlighting uses the same code, so may not be viable to implement.

[admin]

Oh, I just saw that part is easy. Next version will have it.

[jupe]

Thanks, this works well now.