SC popupnested: comments cause overflow?

[Filehero]

Hi Don,

shouldn't this code work without overflow?

Code: Select all

$menu = <<<MENU
                Top;;:paper;1
                  Sub;;;4
                  Sub
                    Sub2;;*.ini
                    Sub2
                    Sub2;;;2
                Top;;<xy>
              MENU;
  
  // this is a line (end) comment
  /*
  This is a block comment
  */
  text popupnested($menu);
  
  // this is a line (end) comment
  /*
  This is a block comment
  */
  */

[highend]

It's no bug.

You didn't close your heredoc correctly

The closing identifier must begin in the *first* column of the line (no indent!).

Moved to questions and answers...

[Filehero]

It's no bug.

You didn't close your heredoc correctly

Then Don has to correct the help and beta release note from where the uncommented example code has been copied from (note the intended heredoc closure).

Thanks nevertheless.

[highend]

Yeah, viewtopic.php?f=1&t=4&start=3750#p143440

is indeed wrong ("MENU;" isn't correctly indented)

[admin]

I did not want to rewrite the docs, so I was happy to see this is really a bug (and I was happy to fix it).

FYI, closing HEREDOC identifier don't have to be left-aligned since v10.80.0010 - 2012-01-23 17:50.

[Filehero]

FYI, closing HEREDOC identifier don't have to be left-aligned since v10.80.0010 - 2012-01-23 17:50.

4 years, that's quite a piece of time.

Thanks for fixing.