[FIXED] better interaction between BV and Hide-Folders in-List

Things you’d like to miss in the future...
Forum rules
You might want to read this if you're looking for priority service

:info: Please Include The Following Information
1) Your XYplorer Version (e.g., v28.00.0801)
2) Your Windows Version (e.g., Win 11)
3) Your Screen Scaling Percentage (e.g., 125%).

:info: Use Your Profile Or Signature
We strongly recommend adding your Windows Version and Screen Scaling Percentage to the Location field in your Profile or to your Signature. That way, you only have to type them once, and we won't have to search for that vital information.

:info: How To Attach Images
When attaching an Image, please use the Attachment tab at the bottom of your post and click "Add files".
bdeshi
Posts: 4256
Joined: 12 Mar 2014 17:27
Location: Asteroid B-612
Contact:

[FIXED] better interaction between BV and Hide-Folders in-List

Post by bdeshi »

In a Branch View, pressing the Hide Folders in List button hides all folders all right, as well as all items within those folders, kind of defeating the purpose of the flat view.
I wish that button acted more like -- rather, exactly like -- a files-only search (QS's /f switch).

update: affects "Show Folders in List" config too.
Icon Names | Onyx | Undocumented Commands | xypcre
[ this user is asleep ]

TheQwerty
Posts: 4373
Joined: 03 Aug 2007 22:30

Re: better interaction between BV and Hide folders in list

Post by TheQwerty »

Why use that instead of switching to a Files only flat view?

FYI, it was previously mentioned without comment: viewtopic.php?f=2&t=14307

bdeshi
Posts: 4256
Joined: 12 Mar 2014 17:27
Location: Asteroid B-612
Contact:

Re: better interaction between BV and Hide folders in list

Post by bdeshi »

Well for some reason I had the button on my toolbar, then today wanted to hide folders in a flat view, and thought "hey, that's the perfect button for the job!... hmm, where'd all those FILES go?"

Of course I can do a quick search but doesn't that render this button pointless?
Icon Names | Onyx | Undocumented Commands | xypcre
[ this user is asleep ]

TheQwerty
Posts: 4373
Joined: 03 Aug 2007 22:30

Re: better interaction between BV and Hide folders in list

Post by TheQwerty »

Was just curious - I also feel it doesn't work as expected.

History seems to agree...
History wrote:

Code: Select all

v6.10.0072 - 02.08.07 17:41
. . .
    ! Menu View | Show Items | Show Folders in List: in Find mode, 
      folders were not recursed when they were hidden by an unchecked 
      "Show Folders in List". Fixed.
      The same bug was in effect for folders hidden by an unchecked 
      "Show Hidden Files and Folders" and "Show System Files and 
      Folders": they were not recursed if hidden. Fixed: now they are 
      recursed and matching contents are displayed in the result listing 
      even if the containing folders themselves are not displayed.

bdeshi
Posts: 4256
Joined: 12 Mar 2014 17:27
Location: Asteroid B-612
Contact:

Re: better interaction between BV and Hide folders in list

Post by bdeshi »

Ok, so this was fixed way back but got unfixed at some point.
Hadn't checked the equivalent menu items.

[moved to bug reports]
Icon Names | Onyx | Undocumented Commands | xypcre
[ this user is asleep ]

TheQwerty
Posts: 4373
Joined: 03 Aug 2007 22:30

Re: better interaction between BV and Hide-Folders in-List

Post by TheQwerty »

Well that was long before Branch View was introduced so the expected behavior was likely never there for BV and thus it would be a wish. :P

It matters not though.

admin
Site Admin
Posts: 67248
Joined: 22 May 2004 16:48
Location: Win8.1, Win10, Win11, all @100%
Contact:

Re: better interaction between BV and Hide-Folders in-List

Post by admin »

It would be easy to do for me, but the results are a bit weird. Folders with a HIDDEN attribute (and "Show hidden files and folders" = OFF) would then be missing from the Branch View. IMO this looks strange, even stranger than the same picture in a normal non-indented search result (where this actually is possible today):
HiddenFolderInBV.png
The last foo folder is HIDDEN. But its contents are not. Do we want this? (I could live with it. It's consistent with search results, and it would fix this thread's bug.)
To see the attached files, you need to log into the forum.

bdeshi
Posts: 4256
Joined: 12 Mar 2014 17:27
Location: Asteroid B-612
Contact:

Re: better interaction between BV and Hide-Folders in-List

Post by bdeshi »

admin wrote:Folders with a HIDDEN attribute (and "Show hidden files and folders" = OFF) would then be missing from the Branch View. IMO this looks strange, even stranger than the same picture in a normal non-indented search result (where this actually is possible today)
Looks okay. The items themselves are not hidden and are listed. Logical. Also, outside of searches, you can manually go to a hidden folder from the AB and view items within.

Maybe you could add a config option "Hide items in hidden folders" in (Tree and List or Find Files & Branch View).
Icon Names | Onyx | Undocumented Commands | xypcre
[ this user is asleep ]

admin
Site Admin
Posts: 67248
Joined: 22 May 2004 16:48
Location: Win8.1, Win10, Win11, all @100%
Contact:

Re: better interaction between BV and Hide-Folders in-List

Post by admin »

I do it. But not another option. We have enough of them. :)

LittleBiG
Posts: 1848
Joined: 08 Apr 2011 12:57
Location: Win10x64

Re: better interaction between BV and Hide-Folders in-List

Post by LittleBiG »

Actually the only point in making a folder hidden to hide its content. So I don't think you should do any changes here.

Edit: it would be like hiding a book by erasing its title, but leave it on the table.

Edit2: The hidden folder wouldn't be hidden any more, because the name is in the path column. Nonsense.
Last edited by LittleBiG on 20 Sep 2016 11:47, edited 1 time in total.

admin
Site Admin
Posts: 67248
Joined: 22 May 2004 16:48
Location: Win8.1, Win10, Win11, all @100%
Contact:

Re: better interaction between BV and Hide-Folders in-List

Post by admin »

Kind of true, but what about the consistency with Find Files (which hides folders but not their contents for almost 10 years)?

LittleBiG
Posts: 1848
Joined: 08 Apr 2011 12:57
Location: Win10x64

Re: better interaction between BV and Hide-Folders in-List

Post by LittleBiG »

I am sorry but hidden folder and hiding a folder are two different things.

Should I elaborate? When I hide a folder from FindFiles is because I don't want to clutter my view. Exclude is for hiding folder with its content in FindFiles

admin
Site Admin
Posts: 67248
Joined: 22 May 2004 16:48
Location: Win8.1, Win10, Win11, all @100%
Contact:

Re: better interaction between BV and Hide-Folders in-List

Post by admin »

What's your opinion on the OT?

LittleBiG
Posts: 1848
Joined: 08 Apr 2011 12:57
Location: Win10x64

Re: better interaction between BV and Hide-Folders in-List

Post by LittleBiG »

I wouldn't make Branch View and Find Files consistent in this regard, because the intention of usage is different. The first one gives rather structure, the second one gives a simple list of files and folders. So in the first case if we want to exclude the folders from the equation, we need to remove them with contents. In the case of Find Files, we don't.

Add: I like the current way of working in the MBV and Hide folders button.

bdeshi
Posts: 4256
Joined: 12 Mar 2014 17:27
Location: Asteroid B-612
Contact:

Re: better interaction between BV and Hide-Folders in-List

Post by bdeshi »

LittleBiG wrote:Actually the only point in making a folder hidden to hide its content. So I don't think you should do any changes here.
Don will in fact have to change something here because currently, a search does list content of hidden folders, regardless of the "show hidden f&f" setting.
Icon Names | Onyx | Undocumented Commands | xypcre
[ this user is asleep ]

Post Reply