Filter bug

Gandolf · Post by **Gandolf** » 23 Jun 2007 07:03

Show all files. Pick a file and "Filter by Selected Extension(s)". It shows only files with that extension. Now click on "Filter by Selected Extension(s)" and it shows all files. I think it should not change the display.

Post by **admin** » 23 Jun 2007 10:01

Gandolf wrote:Show all files. Pick a file and "Filter by Selected Extension(s)". It shows only files with that extension. Now click on "Filter by Selected Extension(s)" and it shows all files. I think it should not change the display.

This is a feature. If the same filter is set again it works like a toggle on/off.

Gandolf · Post by **Gandolf** » 23 Jun 2007 10:30

O.K. I can accept that it is a toggle and don't mind it working that way, although I'm not convinced it is logical.

However, in that case (at the risk of starting another discussion) is there some way to change the description of what it does to make it more obvious?

"Toggle Filter by Selected Extension(s)" perhaps?

It would also appear that it is not a common known feature since I can't see it mentioned in the help file or the Wiki.

Post by **admin** » 23 Jun 2007 10:53

Gandolf wrote:O.K. I can accept that it is a toggle and don't mind it working that way, although I'm not convinced it is logical.

However, in that case (at the risk of starting another discussion) is there some way to change the description of what it does to make it more obvious?

"Toggle Filter by Selected Extension(s)" perhaps?

The toggle is just a little (but very useful!) service in case you do something otherwise completely useless: set a filter that is already set. In all other cases there is no toggle hence the caption should not be changed.

Without this toggle-service: Why would you repeat the same filter again, anyway? Or: What did you expect to happen?

Gandolf · Post by **Gandolf** » 23 Jun 2007 14:36

admin wrote:The toggle is just a little (but very useful!) service in case you do something otherwise completely useless: set a filter that is already set...

Now that I've started to examine further I'm not convinced it is useful, and I can see a problem with the toggle action that I don't like.

A large number of files are displayed.
They are filtered to show only JPG's but because a lot of tabs are open I can see that a filter is set, but not what it is.
I select "Filter by Selected Extension(s)". Nothing changes in the visible list of files, because of the sort order the names of the non-JPG files are off the screen. I know the indication in the tab header changes and the status bar information changes, but the list appears to be the same. I have Filtered by Selected Extension so I don't really expect the filter to have been cleared.

If I now select all the files and delete them everything would be deleted, not just the JPG's.

This is similar to what prompted me to report it as a bug except that originally because of the file names I did see a change in the list of files.

admin wrote:...What did you expect to happen?

I would expect nothing to happen, the same as if I apply a filter that is already applied.

jacky · Post by **jacky** » 23 Jun 2007 15:44

Gandolf wrote:
admin wrote:...What did you expect to happen?
I would expect nothing to happen, the same as if I apply a filter that is already applied.

I'd agree with Gandolf here, this doesn't seem logical to me that setting a VF for currently selected extension would actually remove the current VF! Doesn't matter if it was the same one.

As he said, at times one might wanna apply a VF even though that VF is actually already applied, just because it can't be seen on Tabs and you wanna make sure the right VF is set (or you didn't even checked and forgot a VF was already set, you just wanted to set it up)

Besides, this is actually already how it works everywhere else when setting a VF, it sets it, or does nothing if it's already there: "Set a VF", Go to, AB, Catalog....
So having this only feature works differently really sounds unexpected to me, too.

Post by **j_c_hallgren** » 23 Jun 2007 16:25

But if we wanted to toggle the VF, wouldn't we be using THAT command instead? The blue down arrow icon on toolbar or Cntl+Shft+J keys, right?

I'm with jacky and Gandolf on this...if I do the same filter cmd again, I'd expect no changes to occur...

Post by **admin** » 23 Jun 2007 17:29

Okay, I'm convinced. I should/could have known better before because I've always been against smartness in software:

Code: Select all

v5.40.0029 - 23.11.06 12:49
    + Added a smart (sorry!) toggle to "Filter by Selected Extension(s)" 
      [Ctrl+Alt+J]: if the current VF is exactly the same as the new one 
      would be, VF is turned off. So using [Ctrl+Alt+J] two times 
      brings you back to unfiltered view.

XYplorer Beta Club

Filter bug

Filter bug

Re: Filter bug