Redundant delete confirmation

Things you’d like to miss in the future...
Post Reply
zer0
Posts: 2673
Joined: 19 Jan 2009 20:11

Redundant delete confirmation

Post by zer0 »

I discovered the most blatant bug today: it is easily possible to create orphaned delete confirmations.

- Create a dummy text file
- Press delete but do not click on either yes/no
- Switch to a different app
- Go back into XY and press delete again but now click yes
- Minimise other windows to display the original delete confirmation and click yes
- Boom, it will obviously error out by saying that the file cannot be found since you deleted it already

Solution: either make the confirmation prompt modal or clean the orphans once the real one has been confirmed.
Reporting a bug? Have a wish? Got a question? Use search - View roadmap - FAQs: Forum + XY site
Windows 7/10
Always using the latest stable two-decimal build

admin
Site Admin
Posts: 60617
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Redundant delete confirmation

Post by admin »

Untick this and you are protected from yourself:
Configuration | File Operations | Miscellaneous | File operation progress dialog modeless

zer0
Posts: 2673
Joined: 19 Jan 2009 20:11

Re: Redundant delete confirmation

Post by zer0 »

admin wrote:Untick this and you are protected from yourself:
Configuration | File Operations | Miscellaneous | File operation progress dialog modeless
That makes the dialog stick, but it does not prevent multiple dialogues from being created by a user, so there is a possibility that orphans will exist.
Reporting a bug? Have a wish? Got a question? Use search - View roadmap - FAQs: Forum + XY site
Windows 7/10
Always using the latest stable two-decimal build

admin
Site Admin
Posts: 60617
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Redundant delete confirmation

Post by admin »

How?

zer0
Posts: 2673
Joined: 19 Jan 2009 20:11

Re: Redundant delete confirmation

Post by zer0 »

admin wrote:How?
By pressing "Delete" again. Unchecking that setting just causes the delete yes/no dialog to still be in your face. However, pressing Delete again generates a new dialogue on top of the original one. If you click yes on the new pop-up, then the original one is orphaned (vice versa if you do it on the first one). Clicking no on the orphan dismisses it quietly, but clicking yes pops up an error message (since you deleted the file already so it's not there to delete again).
Reporting a bug? Have a wish? Got a question? Use search - View roadmap - FAQs: Forum + XY site
Windows 7/10
Always using the latest stable two-decimal build

admin
Site Admin
Posts: 60617
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Redundant delete confirmation

Post by admin »

By pressing "Delete" again.
Not possible if the dialog is modal. :?

zer0
Posts: 2673
Joined: 19 Jan 2009 20:11

Re: Redundant delete confirmation

Post by zer0 »

admin wrote:
By pressing "Delete" again.
Not possible if the dialog is modal. :?
I am not known for feats of the impossible, but I have that box unchecked and I can produce this:

Image
Reporting a bug? Have a wish? Got a question? Use search - View roadmap - FAQs: Forum + XY site
Windows 7/10
Always using the latest stable two-decimal build

admin
Site Admin
Posts: 60617
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Redundant delete confirmation

Post by admin »

Well, I can't. You have transmodal superpowers.

TheQwerty
Posts: 4373
Joined: 03 Aug 2007 22:30

Re: Redundant delete confirmation

Post by TheQwerty »

[x] Enable background processing.
Apply to... [x] Delete (runs at once in parallel process)

State of File operation progress dialog modeless does not matter.

XYplorer.exe is likely unaware that XYCopy.exe is waiting on user input and has not performed the desired operation.

admin
Site Admin
Posts: 60617
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Redundant delete confirmation

Post by admin »

OK, that way you can create that situation. But I don't think I have to do anything. Whoever ends up here should know what he has been doing and why. And even if not, nothing bad can happen. So, who cares.

zer0
Posts: 2673
Joined: 19 Jan 2009 20:11

Re: Redundant delete confirmation

Post by zer0 »

admin wrote:OK, that way you can create that situation. But I don't think I have to do anything. Whoever ends up here should know what he has been doing and why. And even if not, nothing bad can happen. So, who cares.
You should care. There is no benefit to letting people generate multiple dialogues that ask the same question, so it should not be permitted. When a question's answer is either yes or no, nothing else should proceed until that question is answered. You're saying "if people want to be stupid, let them be stupid, it's not my problem".
Reporting a bug? Have a wish? Got a question? Use search - View roadmap - FAQs: Forum + XY site
Windows 7/10
Always using the latest stable two-decimal build

admin
Site Admin
Posts: 60617
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Redundant delete confirmation

Post by admin »

It's easy to create the same situation with WE. No wonder, in a multi-tasking system it's totally unsurprising that this can happen; of course, it should be handled gracefully which is done in WE as well as in XY.

Non-issue.

Post Reply