Page 1 of 2

Toggle preview shortcut does not collapse preview

Posted: 12 Oct 2008 19:04
by kartal
Hi

I have assigned shortcut to toggle preview. It works great however invoking the shortcut second time does not collapse the preview bar. I think that collapsing should be the proper behavior since this is called toggle. I normally do not have the bottom bar visible unless I use for search or preview.

Re: Toggle preview shortcut does not collapse preview

Posted: 12 Oct 2008 19:44
by ivan
kartal wrote:Hi

I have assigned shortcut to toggle preview. It works great however invoking the shortcut second time does not collapse the preview bar. I think that collapsing should be the proper behavior since this is called toggle. I normally do not have the bottom bar visible unless I use for search or preview.
Do you mean the Info panel for which the default KS shortcut is F12? If yes, then it works fine for me: press once to show, press again to hide.

Additionally, I'd like to throw 2 more eggs into this basket:
1) When previewing AVI files and then collapsing the Info panel the preview doesn't stop. The video goes away, but the audio keeps playing in the background. This should not be the case and Help file and Wiki do not give any info regarding this.
2) MKV (Matroshka) files aren't supported, but when trying to preview one file I got a message that it's not a previewed format, but for another I got a message that it's too large to be previewed, which suggests that it's possible to do so if only the file was smaller.

Re: Toggle preview shortcut does not collapse preview

Posted: 12 Oct 2008 20:04
by j_c_hallgren
ivan wrote:1) When previewing AVI files and then collapsing the Info panel the preview doesn't stop. The video goes away, but the audio keeps playing in the background. This should not be the case and Help file and Wiki do not give any info regarding this.
2) MKV (Matroshka) files aren't supported, but when trying to preview one file I got a message that it's not a previewed format, but for another I got a message that it's too large to be previewed, which suggests that it's possible to do so if only the file was smaller.
On item 1, I have a vague recollection that playing audio in background is the desired behavior, so as to allow user to play music while doing other tasks.
On item 2, I'm making a guess that file size may be tested first.

Re: Toggle preview shortcut does not collapse preview

Posted: 12 Oct 2008 20:05
by kartal
Yes info panel works fine. I am talking about the preview panel in the info panel. Invoking the preview via shortcut brings the preview pane however calling the shortcut second time to hide the ino-preview pane only unchecks the preview and does nto hide the whole panel.

Re: Toggle preview shortcut does not collapse preview

Posted: 12 Oct 2008 20:22
by ivan
j_c_hallgren wrote:On item 1, I have a vague recollection that playing audio in background is the desired behavior, so as to allow user to play music while doing other tasks.
2 things to say here:
a) For MP3 files this may be the desired behaviour since they are purely audio, but AVIs have a video stream as well and you shouldn't be able to have one without the other.
b) I think the preview mode should not evolve into actual view mode, so when collapsing the Info panel any preview should terminate. After all, you're not minimizing it, you're removing it.
j_c_hallgren wrote:On item 2, I'm making a guess that file size may be tested first.
It appears that you are correct. My thought is that to solve this a check to see what type of file it is should be carried out first.

Re: Toggle preview shortcut does not collapse preview

Posted: 12 Oct 2008 20:33
by ivan
kartal wrote:Yes info panel works fine. I am talking about the preview panel in the info panel. Invoking the preview via shortcut brings the preview pane however calling the shortcut second time to hide the ino-preview pane only unchecks the preview and does nto hide the whole panel.
This is an interesting one. Help file and Wiki seem to have 2 slight different stances on this.
Help file:
Opens the Preview tab (and, if necessary, the Info Panel) for the focused file If the Preview tab is currently selected then Ctrl+Q will close the Info Panel.
Wiki:
Opens the Preview tab and show the Info Panel if needed, and starts the preview for the focused item if selected. If there is currently a preview in progress, it will be stopped and the file will be released. Note that if the Panel is visible, the preview tab active, and no files are selected/previewed then Panel will be hidden.
Observations:
1) How is it possible to open the Preview tab without bringing up the Info panel (both Help file and Wiki seem to point that you can do such)?
2) Help file states that invoking the same KS (Ctrl + Q by default) will close the Info panel, but it does not do so, just stops the preview (of an AVI file I tested).
3) Wiki does not say that Info panel will be closed upon invoking the KS.

Re: Toggle preview shortcut does not collapse preview

Posted: 12 Oct 2008 20:41
by j_c_hallgren
Remember that the wiki is just based on user contributions so at times, it may be more/less current than help file or have different interpretations of the same data. And if you find something in wiki that is incorrect and can be documented as such, you're encouraged to fix it yourself.

Re: Toggle preview shortcut does not collapse preview

Posted: 12 Oct 2008 20:48
by ivan
j_c_hallgren wrote:Remember that the wiki is just based on user contributions so at times, it may be more/less current than help file or have different interpretations of the same data. And if you find something in wiki that is incorrect and can be documented as such, you're encouraged to fix it yourself.
Thank you J C. I certainly won't have a go at jacky :P I just thought that if Don makes tweaks to XY that he documents in the Help file then he might chip in through the Wiki, but I appreciate that he is a busy man...

Re: Toggle preview shortcut does not collapse preview

Posted: 12 Oct 2008 20:59
by j_c_hallgren
ivan wrote:I certainly won't have a go at jacky :P I just thought that if Don makes tweaks to XY that he documents in the Help file then he might chip in through the Wiki, but I appreciate that he is a busy man...
Yes, Don is a busy guy and you're doing your part to cause that :P ...but also, remember that nobody here is perfect! On occasion, Don has done some wiki edits, but it tends to be mostly jacky...I've done some now/then, and others have as well...however, my main contribution is updating/maintaining the blog that mirrors the Beta thread..

Re: Toggle preview shortcut does not collapse preview

Posted: 12 Oct 2008 21:06
by ivan
j_c_hallgren wrote:Yes, Don is a busy guy and you're doing your part to cause that :P ...but also, remember that nobody here is perfect! On occasion, Don has done some wiki edits, but it tends to be mostly jacky...I've done some now/then, and others have as well...however, my main contribution is updating/maintaining the blog that mirrors the Beta thread..
You're right, I contribute a healthy part to keeping Don busy :lol: You're also making other good points. From now on, if I see a discrepancy between the Help file and the Wiki I'll do something about it (already registered an account ;))

Back on topic of this thread now please...

Re: Toggle preview shortcut does not collapse preview

Posted: 12 Oct 2008 21:28
by Muroph
ivan wrote:2) MKV (Matroshka) files aren't supported, but when trying to preview one file I got a message that it's not a previewed format, but for another I got a message that it's too large to be previewed, which suggests that it's possible to do so if only the file was smaller.
there's an ini tweak that makes xy preview mkv files.
i think it's called customextensions or smth like that.
just make sure you have the right codecs.

when you say the file was too large, do you mean the file size or the resolution?

Re: Toggle preview shortcut does not collapse preview

Posted: 12 Oct 2008 21:33
by jacky
ivan wrote:a) For MP3 files this may be the desired behaviour since they are purely audio, but AVIs have a video stream as well and you shouldn't be able to have one without the other.
b) I think the preview mode should not evolve into actual view mode, so when collapsing the Info panel any preview should terminate. After all, you're not minimizing it, you're removing it.
Actually I believe this is expected behavior, hiding the panel doesn't mean ending the preview, so the preview still goes one and the file isn't released. Option to play with panel down applies to audio only, and allows to start playing without showing the Panel.
BTW you're wrong, while often it is said closing the panel, it actually means minimizing, it's never "removed".
ivan wrote:1) How is it possible to open the Preview tab without bringing up the Info panel (both Help file and Wiki seem to point that you can do such)?
No that's not what implied. In "Opens the Preview tab and show the Info Panel if needed" the opening the Preview tab means activating it, if you want. So if Panel was visible but elsewhere it will be activated/opened, and if Panel was hidden it will be made visible.
ivan wrote:3) Wiki does not say that Info panel will be closed upon invoking the KS.
Actually acc. to you it does : "Note that if the Panel is visible, the preview tab active, and no files are selected/previewed then Panel will be hidden." ;)
But that was probably written when to be previewed a file had to be selected, while now you can preview the focused item even when not selected. Maybe it should be adjusted a little, because now Ctrl+Q will only close the Panel when no file are focused (i.e. empty List), so you can't really close the Panel with that command anymore.

Re: Toggle preview shortcut does not collapse preview

Posted: 12 Oct 2008 21:34
by ivan
Muroph wrote:there's an ini tweak that makes xy preview mkv files.
i think it's called customextensions or smth like that.
just make sure you have the right codecs.
This looks like it

Code: Select all

MediaPreviewCustomExtensions=
Muroph wrote:when you say the file was too large, do you mean the file size or the resolution?
XY does not say. The message displayed simply says "File too large to preview". However, I have a feeling it refers to file size. This is because I have another MKV file at almost the same resolution and for that file XY says "Not a previewed format". Difference in size between the 2 files is 3:1 (too large : not a previewed)

Re: Toggle preview shortcut does not collapse preview

Posted: 12 Oct 2008 22:32
by Muroph
hmm...
i've never had problem with the file size before, only resolution, and only with image files. :?
exactly how big is the file you had trouble with?
maybe i have one similar to test here.

Re: Toggle preview shortcut does not collapse preview

Posted: 12 Oct 2008 22:39
by ivan
Muroph wrote:exactly how big is the file you had trouble with?
maybe i have one similar to test here.
My "too big" MKV file is 2.19GB.