Page 2 of 2
Posted: 08 Dec 2007 14:03
by admin
bergfex wrote:admin wrote:Yep, after some practice I crashed it. And fixed it. Nice bug. Thanks!

Yes, it's not easy to crash XY, but I always try my best.
admin wrote:List: app could crash after some repetitive alternate dbl-clicking on items and white space in a certain evil rhythmic pattern that resounded with the system dbl-click time and some other settings. Quite difficult to do. And now even more difficult since it's fixed.
Maybe more difficult, but not impossible:
1. The same as above with the three folders "a", "b" and "c". But now there is a folder "d" inside the folder "c".
2. I double-click on "c" (the name, not the icon) and later inside the folder on empty space > crash
Yes, indeed! But this time I terminally fixed it. I think.

Posted: 08 Dec 2007 15:39
by Gandolf
Have I caught you out with an English expression you haven't heard? "FULL STOP" means "nothing more" - "complete" - "that is all". In the context that I used it means that the command Ctrl+T opens a new tab regardless of anything else, or any other conditions (like where focus is).
So, the Ctrl+T and the Enter, as I see it, are two, unrelated, commands. What I, and I believe serendipity, want it to perform the action with a single keystroke as many other file managers do where the directory is opened in the new tab by a single action.
Posted: 08 Dec 2007 15:45
by admin
Gandolf wrote:Have I caught you out with an English expression you haven't heard? "FULL STOP" means "nothing more" - "complete" - "that is all". In the context that I used it means that the command Ctrl+T opens a new tab regardless of anything else, or any other conditions (like where focus is).
So, the Ctrl+T and the Enter, as I see it, are two, unrelated, commands. What I, and I believe serendipity, want it to perform the action with a single keystroke as many other file managers do where the directory is opened in the new tab by a single action.
Okay, you caught me out, FULL STOP!
So you want: when focus in list is on a folder: 1 key to open that folder in new tab. Good. What when focus in list is on a file, or on nothing?
Posted: 08 Dec 2007 16:13
by Gandolf
admin wrote:So you want: when focus in list is on a folder: 1 key to open that folder in new tab. Good. What when focus in list is on a file, or on nothing?
Following the convention of x²:
If focus is on a folder, Ctrl+T opens the focused folder in the new tab.
If focus if on a file, Ctrl+T works as it does at present, i.e. it opens a new tab (with the same contents as the current tab).
If focus if on nothing, do nothing? No, I don't think so. Open a new tab I would think.
However, the convention used in x² is not liked by some people so perhaps separate keystrokes for the two different actions would be preferred, although I like the way x² works because that's what I'm used to. See if others have any comments.
Posted: 08 Dec 2007 17:06
by jacky
Gandolf wrote:If focus is on a folder, Ctrl+T opens the focused folder in the new tab.
If focus if on a file, Ctrl+T works as it does at present, i.e. it opens a new tab (with the same contents as the current tab).
If focus if on nothing, do nothing? No, I don't think so. Open a new tab I would think.
My thoughts on this, although I mostly use the mouse to open new tab, is that :

I don't think Ctrl+T behavior should be changed, it should be another KS/command I would say...

I agree with "on folder: open folder, open file do now", ie clone the tab (same selection, scroll position, etc)

"On nothing" ?? Well, if we're talking focus here, unless the List is empty you always have a focused item. If we're talking selection, I would imagine no selection = open current location, but then what about a multiple selection ? open as many tabs as selected items ?
Posted: 09 Dec 2007 09:47
by Gandolf
If it's another keystroke then logically it should do nothing if focus is on a file, or give a message.
In that case, logically Ctrl+T would do nothing if focus was on a folder, but I assume you would want it to behave as it is.
Focus not selection I think. Selection is too dangerous - dozens of folders selected would open dozens of tabs, not a good idea unless a "do you want to open ..." prompt is displayed.
So, leave Ctrl+T as it is. New keystroke:
Focus on folder, opens the focused folder in the new tab.
Focus on file, opens a new tab (with the same contents as the current tab).
Focus on nothing, opens a new tab (with the same contents as the current tab).
Multiple selection ignored, works with only the focused file.
Posted: 09 Dec 2007 18:47
by Gandolf
admin wrote: + CKS | Miscellaneous | Go To: added new command "Open Folder in New Tab". Exact behavior depends on circumstances:
- Focus on List folder: open that folder in new tab.
- Focus on List file: open file's folder, then focus file.
- Focus on List no item: open current folder in new tab.
- Focus on Tree: open current folder in new tab.
Note that the focused item must be selected, too.
Works in Browse and Find mode (i.e. on Search Results).
Thanks Donald, works very well - assigned to Ctrl+T.
Posted: 10 Dec 2007 00:49
by serendipity
Wow!! Thanks Don, mine is Shift+enter. I can now quickly create and enter a folder:
ctrl+n;shift+enter.