Another crash related to lots of items...

[jacky]

Hey,

So yeah I got another bug that crashes XY. When I delete or move a lot of items I got a runtime error 380 (invalid property value)

I tried to see how/why it happens, and in the end I dont think it's linked to how many items are moved/deleted, but to the focused row.
Meaning, if i select all files from 1st to last and delete them, it will crash (even with a del *.* outside of XY) ; but if I select them from last to first, it won't!!

So it must be when the focused row is on a line > x that it crashes IF there won't be any item left after the operation, and I got it I think. It is linked to the scrollbar. If x (line of the focused row) is > n then it will crash, n being the max number of lines you can have on the window without having the vert scrollbar.

ie. for me, that magic number is 50, because if I have 51 lines I will get a scrollbar (even though I can see 51 lines at one time, scrollbar will go from 1-51 to 2-52, line 52 being an empty one)

[admin]

My dear, today is bug day! But hey, it's also fix day!

Thanks, jacky, your analysis helped a lot although it was not 100% perfect. Here's the truth:

Code: Select all

    ! List view: crash if deleting all items in a folder when vertical 
      scrollbar is visible and top index is > 1, i.e. if the list is 
      scrolled down at least one line. Fixed.

Pretty embarassing bug, if you ask me...

[jacky]

Well, I was pretty close
Another quick fix, Thanks!

And yeah, I'm sure we're both very pleased it's gone