Page 3 of 3

Re: Another 7-zip script

Posted: 03 Mar 2015 12:54
by highend
Line 359:

Code: Select all

$out_item_name = substr(out_item_name, 0, $last_dot_right);
out_item_name isn't a variable (it's missing the preceeding $-sign)...

Re: Another 7-zip script

Posted: 03 Mar 2015 13:04
by bdeshi
line 359, subscript "_get_item_basename"

Code: Select all

         $out_item_name = substr(out_item_name, 0, $last_dot_right);
//                               ^ not a variable
ed. oh, I'm the runner-up. :kidding:

Re: Another 7-zip script

Posted: 03 Mar 2015 13:09
by lukescammell
Thank you both of you, I've updated the script on the previous page. Such a great set of scripting experts here :)

Re: Another 7-zip script

Posted: 03 Mar 2015 13:15
by PeterH
lukescammell wrote:Thank you both of you, I've updated the script on the previous page. Such a great set of scripting experts here :)
Please give info behind The Bug on previous page: (resolved) :biggrin:
(I wasn't sure the red text related to this bug :whistle: )

Thanks :om:

Re: Another 7-zip script

Posted: 03 Mar 2015 13:31
by lukescammell
I've personally commented out lines 343 to 361 now that bug's been fixed, since it kind of conflicts with the whole "1 archive per file" functionality.

For example, if you had file.jpg and file.png selected and ran the "1 archive per file" function you will end up with a single file.7z with both files inside it – not what you were expecting. With the above lines commented out/removed, you end up with file.jpg.7z and file.png.7z

For my own uses, this is a general improvement even on archiving single files and I quite like being able to tell at a glance what type of file has been archived anyway.

Re: Another 7-zip script

Posted: 03 Mar 2015 13:36
by lukescammell
PeterH wrote:
lukescammell wrote:Thank you both of you, I've updated the script on the previous page. Such a great set of scripting experts here :)
Please give info behind The Bug on previous page: (resolved) :biggrin:
(I wasn't sure the red text related to this bug :whistle: )

Thanks :om:
Done.

Just need to get Plastic to update his first post now…