XYplorer Beta Club

jacky wrote:Two more things I'd like to see in script files : ...

admin wrote:

jacky wrote:Two more things I'd like to see in script files : ...

Yes, nice! But I have to postpone this to after Dual Pane. I'm now entering DP meditation mode and this may take a while... and not saying that I like it but it seems to be the only way to get to the top.

"Script"
  abort confirm("Are you sure ?");
  // something terrible

"Script"
  sub (confirm("Are you sure ?")) ? "_script" : "_nothing";
"_script"
  // something terrible
"_nothing"

jacky wrote:

admin wrote:

jacky wrote:Two more things I'd like to see in script files : ...

Yes, nice! But I have to postpone this to after Dual Pane. I'm now entering DP meditation mode and this may take a while... and not saying that I like it but it seems to be the only way to get to the top.

Understood. One thing I'd like you to squeeze in before if that's possible : I'd love a way for a script to abort execution given a certain condition. Something like assert if you want, but without warning to the user or anything. E.g.

Code: Select all

"Script"
  abort confirm("Are you sure ?");
  // something terrible

Right now to do this, we have to for example use sub, calling either the "real" script or an empty one, making things not as easy to work with, or not as nice-looking

Code: Select all

"Script"
  sub (confirm("Are you sure ?")) ? "_script" : "_nothing";
"_script"
  // something terrible
"_nothing"

Ideally, this command abort would also have an extra param: 0 = [Default] abort this script only, 1 = abort the whole script batch (i.e. like assert or when a user press Cancel on input)

    + Scripting got a new command.
      Name:   End
      Action: Terminate a running script.
      Syntax: end condition, [message], [scope=0]
        condition:  if False (0) then script is ended
                    else nothing happens
        [message]:  message before ending
        [scope]:    0: [default] end whole script stack
                    1 (or any other value): end this script
      Examples:
        ::end 1==1; msg "Still here!";  //"Still here!"
        ::end 1==2; msg "Still here!";  //ends silently
        ::end 1==2, "Bye!"; msg "Still here!";  //"Bye!"

admin wrote:Okay, good idea. I did it like this:

Code: Select all

    + Scripting got a new command.
      Name:   End
      Action: Terminate a running script.
      Syntax: end condition, [message], [scope=0]
        condition:  if False (0) then script is ended
                    else nothing happens
        [message]:  message before ending
        [scope]:    0: [default] end whole script stack
                    1 (or any other value): end this script
      Examples:
        ::end 1==1; msg "Still here!";  //"Still here!"
        ::end 1==2; msg "Still here!";  //ends silently
        ::end 1==2, "Bye!"; msg "Still here!";  //"Bye!"

jacky wrote:

admin wrote:Okay, good idea. I did it like this:

Code: Select all

    + Scripting got a new command.
      Name:   End
      Action: Terminate a running script.
      Syntax: end condition, [message], [scope=0]
        condition:  if False (0) then script is ended
                    else nothing happens
        [message]:  message before ending
        [scope]:    0: [default] end whole script stack
                    1 (or any other value): end this script
      Examples:
        ::end 1==1; msg "Still here!";  //"Still here!"
        ::end 1==2; msg "Still here!";  //ends silently
        ::end 1==2, "Bye!"; msg "Still here!";  //"Bye!"

Excellent! Thanks a lot I'll let you slide to the dark side now...

end $name==""; // abort when name is empty

admin wrote:I wonder if it's counter-intuitive to end when the condition is false. I know it seems to match assert which also gets active when the condition is false, but then assert is semantically sort-of-opposed to end. So I would say it better should end when the condition is true, e.g.

Code: Select all

end $name==""; // abort when name is empty

Makes sense?

jacky wrote:

admin wrote:I wonder if it's counter-intuitive to end when the condition is false. I know it seems to match assert which also gets active when the condition is false, but then assert is semantically sort-of-opposed to end. So I would say it better should end when the condition is true, e.g.

Code: Select all

end $name==""; // abort when name is empty

Makes sense?

You know, it's funny because when I first saw the changelog I immediately had the exact same thought, thinking I would have done it to end on true, only to realize that that (a) it matched assert, and (b) it was also matching my example, when used with a confirm("Sure?") ! So I wasn't really sure...

But since either way it's easy enough to "fake" the NOT operator (end confirm("Are you sure?")-1;), it might be better indeed to change that one, yes, seems more logical to read/write "end ([if] condition to end)".

end confirm("Are you sure to continue?") == 0;

admin wrote: I wonder if it's counter-intuitive to end when the condition is false. ...

if $var1 > 5 then     // bad condition?
 { msg "Abend for ..., will clean-up"; // notify
   delete $temp;     // some cleanup
   end;              // stop execution
 };

PeterH wrote:

admin wrote: I wonder if it's counter-intuitive to end when the condition is false. ...

Just another thougt: is it good to create such "complex" command(s), instead of bringing some more basic logic to scripting, like if/then/else, grouping (and loops)? With these easy to understand "basic" language-elements everyone could build his logic flow simply as he wants. Without always reading help for the sequence and meaning of "extended" operands. Like

Code: Select all

if $var1 > 5 then     // bad condition?
 { msg "Abend for ..., will clean-up"; // notify
   delete $temp;     // some cleanup
   end;              // stop execution
 };

admin wrote:Yes, sure. But it's not that easy. I would have done it already if it would be a matter of some hours. Patience...