Column spot patterns are non functional

[jupe]

There seems to be a regression regarding column Spot patterns, eg this used to work:

>>Type:Folder

I had a quick look back and it seems to have stopped somewhere between 24.50 > 24.60.

[admin]

Yep. Should work again in next beta.

[jupe]

I've noticed that they don't seem to work still when a LF is active, eg. for fresh:

goto <xypath>; filter "XY", 8; goto ">>Ext:exe";

I guess the LF Highlight Matches has some causation, but even with it disabled first it doesn't work.

[admin]

Confirmed. Indeed, you cannot use both highlighting, Live Filter and Spot, at the same time. But there was a bug. In the next beta version, Spot works when Live Filter highlighting is disabled.

[jupe]

Obviously I haven't tested the next beta yet, but are they not compatible now because of the Fast LF changes? Because they are working in .0300, it's only the column Spot ptns that aren't, they have always historically been compatible, in a sense that when you use Spot after a LFHiLite that it functioned the same as just running multiple Spot patterns consecutively, ie it changed from one to the next.

[admin]

Hm, I don't think so, but I have no time right now to test. Please check out .0301, upload in a minute.

[jupe]

Checked .0301, and with LFHLite disabled, it does now function correctly, but I went back and checked a few old versions and everything seemed to function ok together up till around this version,

25.00.0200-

WORKING
25.10.0109+

NOT WORKING

Those aren't exact versions it stopped working in, just as far as I narrowed it down to, not sure what caused it, but like I mentioned in my last post, column spot patterns used to be functional with LF HLite enabled. Anyway if you want to leave it as is, no worries.

There was this change:

Code: Select all

v25.00.0214 - 2023-10-28 18:13
    ! Configuration | Find and Filter | Filters & Type Ahead Find | Live Filter Box | 
      Highlight matches: Highlighting was incorrectly applied to the Name column if the 
      filter was actually applied to another column. Fixed. Now it's applied to the 
      filtered column.

I haven't double checked surrounding versions (haven't got them handy) to see if it was the exact cause, there was also quite a few other LF changes around these versions too.

[admin]

I didn't bother to dig out the old versions (so many things have changed since then), but I was able to improve the current behavior.

[jupe]

I noticed that if I filter by Extra column that the LF highlighting is also applied to other columns (it happens under other conditions too, the pattern isn't limited to the intended column), the same happens with just using Spot too. Here is a repro for fresh, (it assumes that one of the date columns will have a 5 in it)

Code: Select all

goto <xypath>; setcolumns("Extra 1", 32); tagitems(1, 5, <pick 1.m>); filter "ex1: 5", 8;

[admin]

Yes, fixed in next beta. (also fixed it for some other contexts)