Page 1 of 2
XYplorer Modern Style: iconized tabs
Posted: 11 Dec 2023 18:31
by Filehero
Hi Don,
I like the Modern Tab Style.
However, with iconized tabs the icons appear a bit off.

- modern_tab_style.png (5.53 KiB) Viewed 2557 times
I think the reason is the fixed (left) padding. Actually, I would like an option to adapt it within a given range (e.g. 1 - 5px).

Re: XYplorer Modern Style: iconized tabs
Posted: 11 Dec 2023 18:43
by klownboy
Yup, same here.

- tab icons off.jpg (9.82 KiB) Viewed 2548 times
Re: XYplorer Modern Style: iconized tabs
Posted: 12 Dec 2023 06:45
by nerdweed
And also for the colored tabs, there's slight pixel dirt on edges. On hover the edges are rounded, otherwise they are sharp. I think they should be rounded throughout
Re: XYplorer Modern Style: iconized tabs
Posted: 12 Dec 2023 11:13
by admin
Iconized fix comes. Not sure about color dirt. Check out the next beta.
Re: XYplorer Modern Style: iconized tabs
Posted: 12 Dec 2023 14:49
by klownboy
Icon and tab alignment looks good from what I can see. Did you end up putting in a gap between tabs on the Windows Style Theme as well? I don't recall seeing a gap previously.
Re: XYplorer Modern Style: iconized tabs
Posted: 12 Dec 2023 14:56
by admin
Got a screenshot?
Re: XYplorer Modern Style: iconized tabs
Posted: 12 Dec 2023 15:10
by klownboy

- Tabs Windows Style Theme.jpg (14.8 KiB) Viewed 2485 times
Re: XYplorer Modern Style: iconized tabs
Posted: 12 Dec 2023 15:16
by admin
Looks ok. What gap? How did it look before?
Re: XYplorer Modern Style: iconized tabs
Posted: 12 Dec 2023 15:54
by klownboy
Yes, it does look fine. I wasn't sure if Windows Style Theme, which I was using before you came up with "Modern", had any gap at all between tabs previously. It's barely noticeable in light mode since it's only a pixel or 2. Don't get me wrong, I've got no problem with it. Maybe someone who hasn't updated can tell us if that's the case.
EDIT: I just went back to 25.30.0005 with Windows Style Theme and it did indeed have a gap. I just didn't remember seeing it, so all is well. Thanks.
Re: XYplorer Modern Style: iconized tabs
Posted: 12 Dec 2023 16:10
by Filehero
Looks really good now.

Re: XYplorer Modern Style: iconized tabs
Posted: 12 Dec 2023 16:43
by nerdweed
The pixel dirt is gone.
So beautiful, so elegant, just looking like a wow.
Re: XYplorer Modern Style: iconized tabs
Posted: 12 Dec 2023 17:45
by admin

Yeah, I love it, too!

Re: XYplorer Modern Style: iconized tabs
Posted: 12 Dec 2023 21:52
by Filehero
Just mirror 2 times - easy.
I "just" made a major dependency upgrade for my vscode xyscript project, countless hours to nail down one compiler error.

Re: XYplorer Modern Style: iconized tabs
Posted: 12 Dec 2023 22:37
by admin
Filehero wrote: ↑12 Dec 2023 21:52
Just mirror 2 times - easy.
No, I went for the real thing. I could now show photos in the hoverbox with rounded corners. But don't worry, I won't.
Re: XYplorer Modern Style: iconized tabs
Posted: 12 Dec 2023 23:29
by Filehero
admin wrote: ↑12 Dec 2023 22:37
No, I went for the real thing.
To get my posting right: it was a (damned lame) joke.
Anyways, I'm still clicking around the new delightful tab style. It looks great - just like a time travel.
Nevertheless, to me there appears some kind of imbalance. Currently I think the lower/upper padding is too big (though I'm not sure yet).

- modern_tab_style_height.png (3.79 KiB) Viewed 2411 times
What do you think about a tweak for the paddings? Something like
; Tweak: tab paddings in pixels for left, top, right, bottom (maximum is 5)
paddingModernTabStyle=5,2,5,2
Edit: deleted unnecessary stuff.