Page 1 of 1
Thumbnail view of CFI icons
Posted: 20 Jun 2023 03:21
by jupe
I noticed that in thumbnail views if a folder has an overlay that it can become cropped, below in the top image, is an example of my Users folder in 64 thumbnail, also the middle image depicts that in larger thumbnail modes, the overlay is incorrectly positioned too, and sometimes depending on thumbnail size the overlay is displayed twice., in fact all the issues vary depending on the actual source icon size.
2023-06-20_110301.png
Re: Thumbnail view of CFI icons
Posted: 20 Jun 2023 13:06
by admin
This is a nasty business. Factors are
1) Windows version,
2) thumbnail size,
3) available sizes in the icon resource,
4) presence of any icon overlays or color modifications (dimmed, ghosted).
The number of possible combinations is huge, and there is an additional factor: Windows smartness (you see this at work with the doubled link overlays -- I did not ask for them).
So we have left the field of controlled logic and are within a chaotic jungle of hits and misses.
Anyway, I think I could improve some minor inconsistencies. But that's tested only for Win8.1 @ 125% and @ 100%.
* * *
Your cropped icons, where do they come from? What's the source of the graphics?
Re: Thumbnail view of CFI icons
Posted: 20 Jun 2023 22:13
by jupe
admin wrote: ↑20 Jun 2023 13:06
Your cropped icons, where do they come from? What's the source of the graphics?
I just extracted the icon from the exe, so it would work at larger thumbnail sizes for that testing. The icon being cropped looks resolved now, and the misplaced overlay is much closer to the corner, but the overlay seems huge now in thumbnail modes, and also still see the double overlay if the icon source is only 32x32, whether ghosted or not. Also the overlay looks like it is drawn underneath a folder if it has a thumbnail image instead of an icon.
2023-06-21_060509.png
Re: Thumbnail view of CFI icons
Posted: 21 Jun 2023 09:48
by admin
Ah, the old problem. But here's the good news: I could see and fix it all in Win10. Should work nicely in next beta.
Re: Thumbnail view of CFI icons
Posted: 21 Jun 2023 18:52
by jupe
I still see issues, the cropping is back at 64 size, below shows it using <xy> as CFI, then on a CSV lnk file, but it happens with CFI disabled too. The double overlay is still visible only sometimes (eg, bottom img), I guess it depends on icon source size, and it's misplaced at larger sizes again. Folders with image thumbnail looks fixed, but there seems to be pixel dirt behind image thumbnails when switching from larger to smaller thumbnail sizes.
2023-06-22_024718.png
Re: Thumbnail view of CFI icons
Posted: 21 Jun 2023 23:14
by jupe
Re: Thumbnail view of CFI icons
Posted: 21 Jun 2023 23:40
by admin
Alright, better it seems. (And although I use Win10 22H2 120dpi as well, it looks totally different here.)
Why are they all ghosted?
Re: Thumbnail view of CFI icons
Posted: 21 Jun 2023 23:57
by jupe
They are ghosted because initially I just tested in my Users Folder for convenience, so I have kept using that location so the screenshots match, therefore they are ghosted because they are hidden, that is why I included the CSV icon which isn't ghosted, to illustrate that it doesn't affect the outcome.
Cropping is better, icons now much larger at 64 though, dbl overlay and overlay position seem wrong to me still, also if icon source is 32x32 it looks like the overlay is drawn twice slightly offset and behind even at 64 size (see exaggerated attached img). Also it seems having the first item selected and toggling CFI the selected icon stays as shell icon. (edit: actually that only happens in vi: folder)
Personally I'm not fussed, because I never have folders or links visible when I use thumbnails anyway, I was just testing recent changes.
Re: Thumbnail view of CFI icons
Posted: 22 Jun 2023 00:23
by admin
I think I will stop here. It's pointless to keep messing around because this is a non-deterministic minefield. Thanks for presenting the victims. All in all, I think it's a little better now than before, for most users.