Page 1 of 1

Tree background color only grayscale in Dark Mode

Posted: 10 Mar 2021 14:09
by JLoftus
Hi Don,

Below are side by side captures of the exact same window with only one change, clicking Dark Mode.

Note in the left image, the tree and catalog have a dark brown background. In dark mode, the catalog and tree background colors appear grayscale regardless of color selection.
(In both cases, the background of catalog items which have an explicit color defined appear correctly.)
2021-03-10_06-56-44.jpg
As a related niggle, note also the line number color is not honored in Dark Mode either.

Dark Mode is just too awesome not to use though :)

Re: Tree background color only grayscale in Dark Mode

Posted: 10 Mar 2021 14:25
by admin
That's by design. Dark Mode dims down colors.

Your setup is particularly unsuitable for Dark Mode since it is dark already (bright text on dark back) in Light mode.

Re: Tree background color only grayscale in Dark Mode

Posted: 10 Mar 2021 14:54
by JLoftus
I know not all color selections are supported/reflected correctly in Dark Mode, it does seem like since DM was introduced, it's gone through a few changes where things that were originally only dimmed now reflect the color chosen in the configuration dialog. Indeed my colors are mostly dark already, however, the frame, toolbar, scrollbars, etc are not, and DM helps with this.

It's confusing to allow choosing colors in the configuration dialog that do not reflect correctly when in DM. These options should be disabled when in DM, or at least have an asterisk noting they may not show properly as chosen, or better yet, actually have them work in DM. Is there some technical reason actual color selections cannot be reflected correctly in DM, or, was that just a design decision? I'm sure most would prefer to have the colors as chosen. Or at least the option to have them reflect as chosen.

Thanks for the reply

Re: Tree background color only grayscale in Dark Mode

Posted: 10 Mar 2021 17:34
by admin
XY's Dark Mode is *smart* and we all know the downsides of smartness in software. Anyway (#1), it was a long way to bring it to the state it's in now. Your dark tree is dark and readable, and overall looks nice (IMO). But, anyway (#2), I will try to improve it yet a little further! :party:

In the next beta, you should see your colors if you untick Configuration | Colors and Styles | Highlights & Dark Mode | Dark mode | Adaptive colors.

Re: Tree background color only grayscale in Dark Mode

Posted: 10 Mar 2021 21:07
by JLoftus
Thanks @Don! This is GREAT! :appl:

At the great risk of looking a gift horse in the mouth, any chance to get line numbers honored too?

Thanks again so much

Re: Tree background color only grayscale in Dark Mode

Posted: 11 Mar 2021 10:09
by admin
Okay (no mention in change log).

Re: Tree background color only grayscale in Dark Mode

Posted: 11 Mar 2021 14:17
by JLoftus
Thank you as always Don!