Page 1 of 1

Hover Box is Not working with non-English WinRAR

Posted: 06 Feb 2020 15:53
by vasya
[XYplorer 20.70.0000]
The XYplorer does not work with another language WinRAR

WinRAR Russian - not working, English - working
Also maybe Japanese WinRAR not working too viewtopic.php?f=2&t=19698
For reproduce attached winrar-x64-550.exe and winrar-x64-550ru.exe (install + portable) https://www.mediafire.com/file/l1cniriraupc4zz/

Image

Here is the difference in files:
Image

Re: Hover Box is Not working with non-English WinRAR

Posted: 06 Feb 2020 17:45
by nas8e9
WinRAR 5.50 is not the most recent stable version. Does updating to 5.80 make a difference?

Re: Hover Box is Not working with non-English WinRAR

Posted: 06 Feb 2020 18:52
by vasya
nas8e9 wrote: 06 Feb 2020 17:45 WinRAR 5.50 is not the most recent stable version. Does updating to 5.80 make a difference?
5.80 exactly the same problem
Problem in the file C:\Program Files\WinRAR\RarLng.dll
Just rename or delete it and XYplorer starts to work properly

Re: Hover Box is Not working with non-English WinRAR

Posted: 06 Feb 2020 19:54
by admin
vasya wrote: 06 Feb 2020 18:52
nas8e9 wrote: 06 Feb 2020 17:45 WinRAR 5.50 is not the most recent stable version. Does updating to 5.80 make a difference?
5.80 exactly the same problem
Problem in the file C:\Program Files\WinRAR\RarLng.dll
Just rename or delete it and XYplorer starts to work properly
:veryconfused: Really? So the problem is solved?

XYplorer does not directly do anything with that file. But something probably needs that file with the correct name. You can't just rename DLLs... :eh:

Re: Hover Box is Not working with non-English WinRAR

Posted: 06 Feb 2020 20:19
by vasya
admin wrote: 06 Feb 2020 19:54 So the problem is solved?
Of course, not.
admin wrote: 06 Feb 2020 19:54 XYplorer does not directly do anything with that file. But something probably needs that file with the correct name. You can't just rename DLLs... :eh:
Renaming the file is reproducing the error.
1. Install non-English WinRAR
2. HoverBox on *.rar is not working
3. Rename RarLng.dll to RarLng1.dll
4. HoverBox on *.rar is working

So temp fix is:
1. copy WinRAR to a new location (for XYplorer private only)
2. rename RarLng.dll
3. open XYplorer.ini
4. add ZipPathUnRAR=C:\WinRAR-XY\UnRAR.exe

Re: Hover Box is Not working with non-English WinRAR

Posted: 07 Feb 2020 14:58
by admin
WinRAR archive contents are retrieved via command line. No idea what RarLng.dll has to do with it. Don't see any way to fix this. So thanks for sharing the work around! :tup:

Re: Hover Box is Not working with non-English WinRAR

Posted: 07 Feb 2020 16:26
by vasya
Second file is C:\Program Files\WinRAR\rar.lng (available in the Japanese installer https://www.winrarjapan.com/download)
like a dll file need to be renamed to work with XY
admin wrote: 07 Feb 2020 14:58 No idea what RarLng.dll has to do with it
RarLng.dll and rar.lng are affect window output for command line
admin wrote: 07 Feb 2020 14:58 WinRAR archive contents are retrieved via command line.
of course, but result is different. (for Japanese WinRAR)
"C:\Program Files\WinRAR\Rar.exe" la "Folder4.rar"

If RarLng.dll and rar.lng are here: (so localization is working)
Image

RarLng.dll and rar.lng are renamed: (so localization is NOT working)
Image

Maybe in your code you are using something like strpos(output, "Attributes"), which will work only in the output without localization

Re: Hover Box is Not working with non-English WinRAR

Posted: 07 Feb 2020 16:46
by admin
Bingo! :appl:

Next version should handle it.