Page 13 of 21

Re: dark theme

Posted: 19 Dec 2018 17:30
by admin
Both things should be fixed.

Re: dark theme

Posted: 19 Dec 2018 21:40
by Filehero
admin wrote: 17 Dec 2018 22:59 1) You are right, I will adjust the grid line luminance.

2) Breadcrumbs. That was a bug! :bug: :tup: :beer:
Thanks for your fixes - it's looking great!
dark_mode_nice.png
dark_mode_nice.png (82.84 KiB) Viewed 2934 times
:beer: :beer: :tup: :tup:

Re: dark theme

Posted: 20 Dec 2018 07:16
by BobCrash
It's been quite entertaining watching the grind to the dark side. Great effort Don, and to all the dedicated gang... So much detail and complexity involved. Looking great so far. I'm getting the tickle to 'cross over' to the darkness.... :ninja: :appl:

Re: dark theme

Posted: 20 Dec 2018 11:10
by bdeshi
The active tab border is too bright.
tabhighlight.png
tabhighlight.png (3.9 KiB) Viewed 2893 times
in fact, how about using the same color as inactive tabs borders? the active tab is already distinct enough.
tabhighlight.png
tabhighlight.png (3.88 KiB) Viewed 2890 times

Re: dark theme

Posted: 20 Dec 2018 11:29
by Leito
SammaySarkar wrote: 20 Dec 2018 11:10 The active tab border is too bright.tabhighlight.png

in fact, how about using the same color as inactive tabs borders? the active tab is already distinct enough.tabhighlight.png
:tup: :tup: :tup:

Re: dark theme

Posted: 20 Dec 2018 11:40
by jupe
I just noticed in Dark Mode that if Tabsets are disabled via:

Configuration | Other | Features | Tabsets

then the label shows but the checkbox is hidden.

2018-12-20_213225.png
2018-12-20_213225.png (5.74 KiB) Viewed 2883 times

Re: dark theme

Posted: 20 Dec 2018 11:54
by admin
SammaySarkar wrote: 20 Dec 2018 11:10 The active tab border is too bright.
I'll dim it a bit.

Re: dark theme

Posted: 20 Dec 2018 12:03
by admin
jupe wrote: 20 Dec 2018 11:40 I just noticed in Dark Mode that if Tabsets are disabled via:

Configuration | Other | Features | Tabsets

then the label shows but the checkbox is hidden.
Ah, good find! There were even some other similar cases. Should all be fixed next.

Re: dark theme

Posted: 20 Dec 2018 19:54
by Leito
admin wrote: 20 Dec 2018 11:54
SammaySarkar wrote: 20 Dec 2018 11:10 The active tab border is too bright.
I'll dim it a bit.
Much better. :tup:
Thanks

Re: dark theme

Posted: 20 Dec 2018 19:58
by Marco
Thanks Don, those bugs that I pointed out are squashed and washed away now :tup:

Could you dim, on Win 8.1, the highlight color as you do on Win 10?

Re: dark theme

Posted: 20 Dec 2018 20:22
by admin
Marco wrote: 20 Dec 2018 19:58 Could you dim, on Win 8.1, the highlight color as you do on Win 10?
:? There are no differences between Win versions. The blue on your screenshot is dimmed.

Re: dark theme

Posted: 20 Dec 2018 20:38
by Marco
So, basically, I should go to the oculist?

Re: dark theme

Posted: 20 Dec 2018 21:13
by admin
These are my highlights in default dark mode (25/15 darkness/contrast) on Win8.1, they are identical to your screenshot.

Re: dark theme

Posted: 20 Dec 2018 22:00
by Leito
Same color as I got on Win 10: #1D73C9 :ugeek:

Re: dark theme

Posted: 20 Dec 2018 22:11
by admin
Leito wrote: 20 Dec 2018 19:54
admin wrote: 20 Dec 2018 11:54
SammaySarkar wrote: 20 Dec 2018 11:10 The active tab border is too bright.
I'll dim it a bit.
Much better. :tup:
Thanks
Still better in v19.40.0189. Now the border matches the color of the tab (if breadcrumb colors are used).