Page 1 of 1

Special rename preview

Posted: 24 Aug 2007 13:06
by Muroph
The last item in the preview list doesn't get renamed.

Would be perfect otherwise.
Nice addition! *thumbs up*

Re: Special rename preview

Posted: 24 Aug 2007 13:36
by admin
Muroph wrote:The last item in the preview list doesn't get renamed.
:? Anybody else?

Posted: 24 Aug 2007 13:38
by serendipity
Works fine here. I tested only batch rename though.

Update: I tested with all possible rename specials but cannot reproduce this.

Posted: 24 Aug 2007 14:07
by Muroph
It's working now.
Weird...
I'd tested with batch and regex rename and it happend with both.
I'll let you know if it happens again.

Posted: 24 Aug 2007 14:31
by admin
Muroph wrote:I'd tested with batch and regex rename and it happend with both.
If the template results in an empty new name, the item will not be renamed, and it will not be listed in the rename preview. Maybe this was the case with you and maybe I should change the latter and list it in the preview as "empty" or "unchanged" or so.

Posted: 24 Aug 2007 14:36
by Muroph
Yup. It happened again.

EDITED
How to reproduce:
-The info panel must be opened in one of the preview modes.
-Auto-refresh must be enabled and updating the contents of the folder (ex: downloading something to the folder).
-Select some files by ctrl+click or shift+click. Select all (ctrl+A) doesn't work.
-If the folder is updated while the rename preview window is opened, the last file you selected will be shown in the info panel preview.
-If you click 'rename now' this file won't be renamed.

I think this is because the info pnl preview is using the file, and a file in use can't be renamed.
Maybe you could disable the i.p. preview while the rename preview window is opened. Or suspend the auto-refresh.

Posted: 24 Aug 2007 14:38
by admin
Just saw a general bug when using the new Change Template button... wait till the next fix, please!

Posted: 24 Aug 2007 16:05
by Muroph
Just a suggestion:
Add an 'Invalid Character' warning on the rename preview for the chars that can't be used on file names. '\ / : * ? " < > |'

Posted: 24 Aug 2007 16:14
by admin
Muroph wrote:Just a suggestion:
Add an 'Invalid Character' warning on the rename preview for the chars that can't be used on file names. '\ / : * ? " < > |'
Just done 30 secs ago! Funky :)

Posted: 24 Aug 2007 17:15
by admin
Muroph wrote:How to reproduce:
...
I think this is because the info pnl preview is using the file, and a file in use can't be renamed.
Maybe you could disable the i.p. preview while the rename preview window is opened. Or suspend the auto-refresh.
Yes. The preview was in fact closed, but too early. The auto-refresh started it again before the rename, using the time-slot offered by the new rename preview. For now, I moved the closing of the panel preview (= unlocking any locked files) down to right before the rename proper. This should do with a high probability.

Dual Pane is here!

Posted: 24 Aug 2007 21:22
by admin
Hey, did you note: with the new Rename Preview XYplorer finally got Dual Pane! :P

Re: Dual Pane is here!

Posted: 25 Aug 2007 06:07
by j_c_hallgren
admin wrote:Hey, did you note: with the new Rename Preview XYplorer finally got Dual Pane! :P
Not quite! :roll: IMHO, it's a bit of a stretch to call that one screen "DP", but I'd agree that it does have two similar looking lists...

Posted: 27 Aug 2007 16:04
by jacky
It seems that we cannot start a renaming anymore if there's one error listed on preview, eg "Exists".

It used to be possible, and I wish it would still be, skipping the items on error. Easier than having to not forget to save the pattern, go unselect the one item that don't belong there, and re-start all over again...

Posted: 27 Aug 2007 16:33
by admin
jacky wrote:It seems that we cannot start a renaming anymore if there's one error listed on preview, eg "Exists".

It used to be possible, and I wish it would still be, skipping the items on error. Easier than having to not forget to save the pattern, go unselect the one item that don't belong there, and re-start all over again...
Okay, I'll enable the button. But you'll get a message box telling you that the items in red will not be renamed. Deal?

Posted: 27 Aug 2007 16:43
by jacky
admin wrote:Okay, I'll enable the button. But you'll get a message box telling you that the items in red will not be renamed. Deal?
Deal! :)