Page 1 of 2

[FIXED] better interaction between BV and Hide-Folders in-List

Posted: 19 Sep 2016 09:17
by bdeshi
In a Branch View, pressing the Hide Folders in List button hides all folders all right, as well as all items within those folders, kind of defeating the purpose of the flat view.
I wish that button acted more like -- rather, exactly like -- a files-only search (QS's /f switch).

update: affects "Show Folders in List" config too.

Re: better interaction between BV and Hide folders in list

Posted: 19 Sep 2016 15:52
by TheQwerty
Why use that instead of switching to a Files only flat view?

FYI, it was previously mentioned without comment: viewtopic.php?f=2&t=14307

Re: better interaction between BV and Hide folders in list

Posted: 19 Sep 2016 16:32
by bdeshi
Well for some reason I had the button on my toolbar, then today wanted to hide folders in a flat view, and thought "hey, that's the perfect button for the job!... hmm, where'd all those FILES go?"

Of course I can do a quick search but doesn't that render this button pointless?

Re: better interaction between BV and Hide folders in list

Posted: 19 Sep 2016 16:42
by TheQwerty
Was just curious - I also feel it doesn't work as expected.

History seems to agree...
History wrote:

Code: Select all

v6.10.0072 - 02.08.07 17:41
. . .
    ! Menu View | Show Items | Show Folders in List: in Find mode, 
      folders were not recursed when they were hidden by an unchecked 
      "Show Folders in List". Fixed.
      The same bug was in effect for folders hidden by an unchecked 
      "Show Hidden Files and Folders" and "Show System Files and 
      Folders": they were not recursed if hidden. Fixed: now they are 
      recursed and matching contents are displayed in the result listing 
      even if the containing folders themselves are not displayed.

Re: better interaction between BV and Hide folders in list

Posted: 19 Sep 2016 17:21
by bdeshi
Ok, so this was fixed way back but got unfixed at some point.
Hadn't checked the equivalent menu items.

[moved to bug reports]

Re: better interaction between BV and Hide-Folders in-List

Posted: 19 Sep 2016 17:26
by TheQwerty
Well that was long before Branch View was introduced so the expected behavior was likely never there for BV and thus it would be a wish. :P

It matters not though.

Re: better interaction between BV and Hide-Folders in-List

Posted: 20 Sep 2016 09:20
by admin
It would be easy to do for me, but the results are a bit weird. Folders with a HIDDEN attribute (and "Show hidden files and folders" = OFF) would then be missing from the Branch View. IMO this looks strange, even stranger than the same picture in a normal non-indented search result (where this actually is possible today):
HiddenFolderInBV.png
The last foo folder is HIDDEN. But its contents are not. Do we want this? (I could live with it. It's consistent with search results, and it would fix this thread's bug.)

Re: better interaction between BV and Hide-Folders in-List

Posted: 20 Sep 2016 11:21
by bdeshi
admin wrote:Folders with a HIDDEN attribute (and "Show hidden files and folders" = OFF) would then be missing from the Branch View. IMO this looks strange, even stranger than the same picture in a normal non-indented search result (where this actually is possible today)
Looks okay. The items themselves are not hidden and are listed. Logical. Also, outside of searches, you can manually go to a hidden folder from the AB and view items within.

Maybe you could add a config option "Hide items in hidden folders" in (Tree and List or Find Files & Branch View).

Re: better interaction between BV and Hide-Folders in-List

Posted: 20 Sep 2016 11:34
by admin
I do it. But not another option. We have enough of them. :)

Re: better interaction between BV and Hide-Folders in-List

Posted: 20 Sep 2016 11:42
by LittleBiG
Actually the only point in making a folder hidden to hide its content. So I don't think you should do any changes here.

Edit: it would be like hiding a book by erasing its title, but leave it on the table.

Edit2: The hidden folder wouldn't be hidden any more, because the name is in the path column. Nonsense.

Re: better interaction between BV and Hide-Folders in-List

Posted: 20 Sep 2016 11:46
by admin
Kind of true, but what about the consistency with Find Files (which hides folders but not their contents for almost 10 years)?

Re: better interaction between BV and Hide-Folders in-List

Posted: 20 Sep 2016 11:48
by LittleBiG
I am sorry but hidden folder and hiding a folder are two different things.

Should I elaborate? When I hide a folder from FindFiles is because I don't want to clutter my view. Exclude is for hiding folder with its content in FindFiles

Re: better interaction between BV and Hide-Folders in-List

Posted: 20 Sep 2016 11:55
by admin
What's your opinion on the OT?

Re: better interaction between BV and Hide-Folders in-List

Posted: 20 Sep 2016 12:45
by LittleBiG
I wouldn't make Branch View and Find Files consistent in this regard, because the intention of usage is different. The first one gives rather structure, the second one gives a simple list of files and folders. So in the first case if we want to exclude the folders from the equation, we need to remove them with contents. In the case of Find Files, we don't.

Add: I like the current way of working in the MBV and Hide folders button.

Re: better interaction between BV and Hide-Folders in-List

Posted: 20 Sep 2016 12:52
by bdeshi
LittleBiG wrote:Actually the only point in making a folder hidden to hide its content. So I don't think you should do any changes here.
Don will in fact have to change something here because currently, a search does list content of hidden folders, regardless of the "show hidden f&f" setting.