XYplorer Beta Club

The option "Cache network servers between sessions" is not persisted to the ini file correctly when I click "Save Settings Now". It is read back though if you manually change the ini file.

blackbit wrote:The option "Cache network servers between sessions" is not persisted to the ini file correctly when I click "Save Settings Now". It is read back though if you manually change the ini file.

Indeed! This button is very misleading: it does not save the current state of the config interface but the current state of the actually active config; any still pending (not OKed) changes are not saved.

I should remove this button. Any objections anywhere?

Maybe it's a better idea to just 'OK' the settings, and then write them to file...

blackbit wrote:Maybe it's a better idea to just 'OK' the settings, and then write them to file...

But: when you then "Cancel" the dialog, you don't get what you expect (namely cancel).

Then, maybe rename the button to "OK and save settings to file". And also close the dialog after pressing it...

blackbit wrote:Then, maybe rename the button to "OK and save settings to file". And also close the dialog after pressing it...

Sounds good... I'll think about it...

admin wrote:Indeed! This button is very misleading: it does not save the current state of the config interface but the current state of the actually active config; any still pending (not OKed) changes are not saved.

I should remove this button. Any objections anywhere?

First off; that's what it does!!
Then yeah, very misleading it is, indeed. And then, how come it's disabled when "Save Settings on Exit" is enabled ?? I used to think it was somehow only there for people that don't save on exit, so they could easilly save the new settings after they changed them, which made sense IF the button actually saved them!
But it means one would change its config, click Save Now since he doesn't save on exit. Then later on exit/restart XY, and all its config is lost??
That, I think, would really not be liked and be seen as a bug, no?

So, wouldn't it be better to rename it to "Apply", since it seems to be what it actually does.

In such case, if one presses "Apply" then it is understood that hitting Cancel afterwards will only cancel whatever changes have been made AFTER the button "Apply" was pressed, if any.

And since we're dealing here with "Save Settings on Exit" disabled, maybe a button to "Save Settings Now" which would actually save them to the INI would be a nice thing, and/or adding on the Config TB button ctxt menu a submenu with the File/Configuration File menu ?

jacky wrote:

admin wrote:Indeed! This button is very misleading: it does not save the current state of the config interface but the current state of the actually active config; any still pending (not OKed) changes are not saved.

I should remove this button. Any objections anywhere?

First off; that's what it does!!
Then yeah, very misleading it is, indeed. And then, how come it's disabled when "Save Settings on Exit" is enabled ?? I used to think it was somehow only there for people that don't save on exit, so they could easilly save the new settings after they changed them, which made sense IF the button actually saved them!
But it means one would change its config, click Save Now since he doesn't save on exit. Then later on exit/restart XY, and all its config is lost??
That, I think, would really not be liked and be seen as a bug, no?

So, wouldn't it be better to rename it to "Apply", since it seems to be what it actually does.

In such case, if one presses "Apply" then it is understood that hitting Cancel afterwards will only cancel whatever changes have been made AFTER the button "Apply" was pressed, if any.

And since we're dealing here with "Save Settings on Exit" disabled, maybe a button to "Save Settings Now" which would actually save them to the INI would be a nice thing, and/or adding on the Config TB button ctxt menu a submenu with the File/Configuration File menu ?

Removing it would be simpler, or?

PS: the natural sequence for those folks that do NOT auto-save on exit should be (a) make changes (b) OK them and go back to the main window (c) see whether all works satisfactory (d) save to config using the file menu. Or?

admin wrote:Removing it would be simpler, or?

Simpler for you, yeah sure!

admin wrote:PS: the natural sequence for those folks that do NOT auto-save on exit should be (a) make changes (b) OK them and go back to the main window (c) see whether all works satisfactory (d) save to config using the file menu. Or?

hmm... I don't know, I'm not one of them. But I think that if I were, I'd like a button on Config window to do "Save Settings Now", for once I've set things up I can save them now, making sure I won't forget later on.
Sure, maybe i want to try them out first, but then there's always the File/Configuration File menu !


Okay I just got it right now! So ok the button doesn't do a "Apply" at all, I read that wrong, all apologies.
So yeah, it is very misleading. I can see why one would want to save the settings he just tweaked, but not why he would save what they were before, and then press Ok to apply new ones. Very unnatural thing here don't you think?
I can see one wanting to save them before changing anything, but that should go through the File menu, not a button on Config, methinks.

Ok, last offer Yeah that button has to go, kill it. But, maybe have instead, next to "OK" button, a checkbox: "Save Settings on OK"
That way one can still cancel, apply settings, and apply them & save them in a row. Besides, it could be useful for "save on exit" folks as well

jacky wrote:Ok, last offer Yeah that button has to go, kill it. But, maybe have instead, next to "OK" button, a checkbox: "Save Settings on OK"
That way one can still cancel, apply settings, and apply them & save them in a row. Besides, it could be useful for "save on exit" folks as well

Thanks for the offer, but no. The button is gone for good.