Page 1 of 2

quicksearch() obeys visual filter?

Posted: 28 Dec 2015 15:35
by highend
quicksearch() doesn't find files that are hidden by an active visual filter.

I understand that this makes sense for commands that actually list pane contents like (listpane())
but is it really intended / necessary for quicksearch()? That makes it a bit unpredictable for multi-search
locations...

Re: quicksearch() obeys visual filter?

Posted: 28 Dec 2015 17:16
by admin
Oh, I totally agree with you: quicksearch() should NOT obey to visual filter! Change coming...

Re: quicksearch() obeys visual filter?

Posted: 28 Dec 2015 17:18
by highend
:tup:

Re: quicksearch() obeys visual filter?

Posted: 28 Dec 2015 18:17
by highend
Confirmed fixed with v16.10.0202

Re: quicksearch() obeys visual filter?

Posted: 17 Dec 2017 07:38
by jupe
I am experiencing a similar issue to this, most likely I am just doing something wrong but confirmation would be appreciated. I usually always have folders hidden in the list and switch them on manually if need be, for example's sake if I perform a

Code: Select all

text quicksearch("/dn", "m:\");
by my understanding of the help file it should find all folders in the root of m:, which is the result I get, but only if I perform it with folders visible in the GUI, so if folders are set via "#496 View | Show Items | Show Folders in List" to not visible I don't get a return, is that the expected result from my input?

Re: quicksearch() obeys visual filter?

Posted: 17 Dec 2017 10:09
by highend
Imho quicksearch() should be unaffected of any hide <anything> setting. As a scripting
command it doesn't know about all states of what is currently active (and even if it
were aware of them it should ignore them)

Re: quicksearch() obeys visual filter?

Posted: 17 Dec 2017 13:12
by admin
Unfortunately I have to agree. This will be a lot of work... :ninja:

PS: Done, wasn't that much after all. 8)

Re: quicksearch() obeys visual filter?

Posted: 17 Dec 2017 16:10
by jupe
Wow! Thanks :tup:

Re: quicksearch() obeys visual filter?

Posted: 22 Jan 2018 10:09
by admin
From now on (v18.60.0208 - 2018-01-22 10:06) you have to use the "a" flag with QuickSearch() to ignore any GUI settings that hide files.

Re: quicksearch() obeys visual filter?

Posted: 22 Jan 2018 16:46
by admin
admin wrote:From now on (v18.60.0208 - 2018-01-22 10:06) you have to use the "a" flag with QuickSearch() to ignore any GUI settings that hide files.
But was it the right thing to do? Generally I think scripting should work independently of any GUI settings, so maybe I should remove that sentence "It works 100% identical to GUI Quick Search apart from not affecting the GUI", or change it to "99%". And make the "a" flag the default.

??? :eh:

Re: quicksearch() obeys visual filter?

Posted: 22 Jan 2018 17:03
by highend
99%, otherwise I need to revise all scripts that I wrote after v18.60.0208 :mrgreen:

Re: quicksearch() obeys visual filter?

Posted: 22 Jan 2018 17:05
by Filehero
admin wrote:And make the "a" flag the default.??? :eh:
This.

There should always be an option to uncouple things. For example, with all copy-related commands I‘m most of the times happy that the defaults are following the custom copy GUI settings.

Re: quicksearch() obeys visual filter?

Posted: 22 Jan 2018 17:40
by admin
I think it would be easier to understand if I reverse the logic then and call the flag "h" (= hide what's hidden in the GUI) or "v" (= visible only = show only what's visible in the GUI). And don't pass any default flags. OK?

"h" or "v"? :eh:

Re: quicksearch() obeys visual filter?

Posted: 22 Jan 2018 18:10
by Filehero
admin wrote:"h" or "v"? :eh:
Personally, I don't care. For the most cases I'll have to rtfm anyhow. :mrgreen:

For the rest I think "v" is easier to remember.

Ok, I'll remove all the "a" additions again. :mrgreen:

Re: quicksearch() obeys visual filter?

Posted: 22 Jan 2018 18:46
by zakhar
Sorry, I come from here
viewtopic.php?f=2&t=18370&p=155541#p155541
I think, for a user it should do absolutely no matter,
if it is a switch or a flag, an "a" or "h" or some thing else, that is default or not, and if it underlies any theory, logic or not.
But it should be !regulable! in a clear way.
That, what is chosen in "v18.60.0208 - 2018-01-22 10:06" - an "a" flag, is one of this clear ways.