XYplorer Beta Club

128 = Return selected index. If nothing is selected, 0 (zero) is returned.

     $options = "One|Two|Three";
     $index = inputselect("Select an option:<crlf>", "$options", "|" ,128, "None", 420, 265, "Your options");
       if ($index == "0") {echo Index: $index}
       if ($index == "1") {echo Index: $index}
       if ($index == "2") {echo Index: $index}
       if ($index == "-1") {msg "You haven't selected an option...aborting!"; end 1;}

SammaySarkar wrote:hmmm... that 128 flag also returns an extra space; it returns " 0", ..., " n" instead of "0", ..., "n".
(huh, a source code typo?)

klownboy wrote:Help file for: inputselect (header, listdata, [separator="|"], [style=1], [cancel], [width=600], [height=400], [windowcaption])
states,

128 = Return selected index. If nothing is selected, 0 (zero) is returned.

This statement is incorrect. When using return index "128", if the 1st item is selected, the return is "0", 2nd is "1", and 3rd item selected returns "2". If nothing is selected the return is "-1". Which makes sense since it can't be "0" (zero) as stated since if the first item is selected the return is "0".

Edit: To make it easier to eval...

Code: Select all

     $options = "One|Two|Three";
     $index = inputselect("Select an option:<crlf>", "$options", "|" ,128, "None", 420, 265, "Your options");
       if ($index == "0") {echo Index: $index}
       if ($index == "1") {echo Index: $index}
       if ($index == "2") {echo Index: $index}
       if ($index == "-1") {msg "You haven't selected an option...aborting!"; end 1;}

Thanks,
Ken

admin wrote:I think it was never intended to return the index 0-based. So the Help file is right but the code is wrong. Good find, thanks!

TheQwerty wrote:

admin wrote:I think it was never intended to return the index 0-based. So the Help file is right but the code is wrong. Good find, thanks!

Sorry, I missed the cutoff for v14.50.0300, but for InputSelect...

Either style 128 needs to respect style 2 and return a list of the the checked items' indexes, or it needs to be documented that it will completely ignore the checkboxes and return the "selected" item's index.

It's rather obvious but it might also be worth mentioning that combining styles 16 and 128 will give you headaches.

admin wrote:

TheQwerty wrote:Either style 128 needs to respect style 2 and return a list of the the checked items' indexes, or it needs to be documented that it will completely ignore the checkboxes and return the "selected" item's index.

It's rather obvious but it might also be worth mentioning that combining styles 16 and 128 will give you headaches.

style 2: I find the current behavior totally natural and expected. No need for docs.
style 16: The same. No headaches here.

"Styles 2+128" Echo InputSelect('Style is 2+128 so the checkboxes are ignored.', '+A|B|+C|D',, 2+128);
"Styles 16+128" Echo InputSelect('Style is 16+128 and since the user can reorder items, changing their indexes, the returned value is worthless.', 'A|B|C|D',, 16+128);

return The selected list item. If checkbox style then the checked items are returned, separated by separator.