XYplorer Beta Club

TheQwerty wrote: foreach aborts unexpectedly after handling a token containing an odd number of quotes:

Code: Select all

$test = 'a|b"c|d|e|f|g';
  $c = GetToken($test, 'Count', '|');
  $i = 0;
  foreach($line, $test) { $i++; }

  Echo "Iterated over $i lines.<crlf>Expected: $c";

Separator makes no difference - I ran into it parsing output from GetSectionList with its default CRLF.

admin wrote:Indeed, thanks! Fix coming...

FYI, any quotes within the ListOfTokens in a Foreach statement are (now) seen as normal characters. They have no special "quoting function". This was not 100% implemented before the fix.

$test = '|a||b"c||d|';

  $a = FormatList($test, 'e', '|');
  $an = GetToken($a, 'Count', '|');

  $e = Trim(RegexReplace($test, '\|\|+', '|'), '|', 'LR');
  $en = GetToken($e, 'Count', '|');

  Echo "Remove empties from: $test<crlf>Expected: $e  [$en tokens]<crlf>Actual: $a  [$an tokens]";

TheQwerty wrote:

admin wrote:Indeed, thanks! Fix coming...

FYI, any quotes within the ListOfTokens in a Foreach statement are (now) seen as normal characters. They have no special "quoting function". This was not 100% implemented before the fix.

Foreach is much better now!

But, take a look at FormatList, it also seems to have a less than 100% quote handling implementation:

Code: Select all

$test = '|a||b"c||d|';

  $a = FormatList($test, 'e', '|');
  $an = GetToken($a, 'Count', '|');

  $e = Trim(RegexReplace($test, '\|\|+', '|'), '|', 'LR');
  $en = GetToken($e, 'Count', '|');

  Echo "Remove empties from: $test<crlf>Expected: $e  [$en tokens]<crlf>Actual: $a  [$an tokens]";

PeterH wrote:A new one: in ReplaceList()

There's something I'd call a bug in ReplaceList(): if the searchlist contains only 1 element it's not found. If there are at least 2 elements it's OK.

Example:

Code: Select all

  $a = 'abcd123';
  $r = 'a';
  $s = 'a1';
  $y = ReplaceList($a, $r); // the 'a' is not found: no action
  $z = ReplaceList($a, $s); // 'a' and '1' are found and deleted
  Text "'$y', '$z'";

I don't think it's OK this way.