Page 3 of 21
Re: SimpleUpdater - Rev. 10.40 / 2012/12/17
Posted: 19 Dec 2012 05:32
by serendipity
Marco wrote:Serendipity, do you have any clue?
I will go into this tomorrow more carefully. Was busy all day.
Maybe create a loop to make sure file exists and only then read it?
Re: SimpleUpdater - Rev. 10.40 / 2012/12/17
Posted: 19 Dec 2012 07:09
by Marco
I start to think that Win 8 could be the problem, something changed with cscript probably. There are no significant changes in the script before the line of code that fails.
The best steps he can try are:
-load SU 10.40
-execute the script up to line of code 75 included: line 75 should generate the $command variable
-inspect the content of $command and copy it from "cscript" onwards ("cmd /c " is useless in this test)
-open a command prompt (Win+R)
-paste that command and execute
If there's an error in the CLI we can spot it out.
The waiting loop is a fine idea, but wait() is not supported yet, and I don't want to use unsupported thing. Petition for Don?
Re: SimpleUpdater - Rev. 10.40 / 2012/12/17
Posted: 19 Dec 2012 08:59
by Filehero
Hi Marco, hi serendipity,
thanks for your support.
I will try the steps you've listed. But it could take some time because I#m very buy right now (X-mas horror, you know..).
Cheers,
Filehero
Marco wrote:
The best steps he can try are:
-load SU 10.40
-execute the script up to line of code 75 included: line 75 should generate the $command variable
-inspect the content of $command and copy it from "cscript" onwards ("cmd /c " is useless in this test)
-open a command prompt (Win+R)
-paste that command and execute
Re: SimpleUpdater - Rev. 10.40 / 2012/12/17
Posted: 19 Dec 2012 10:30
by admin
"I'm very buy right now" is a nice typo!
Re: SimpleUpdater - Rev. 10.40 / 2012/12/17
Posted: 19 Dec 2012 12:56
by Marco
Filehero wrote:Hi Marco, hi serendipity,
thanks for your support.
I will try the steps you've listed. But it could take some time because I#m very buy right now (X-mas horror, you know..).
Cheers,
Filehero
X-mas awesomeness you mean, right?
Re: SimpleUpdater - Rev. 10.40 / 2012/12/17
Posted: 19 Dec 2012 16:53
by Filehero
Back from buying tons of awesomenesses.
(well, the show goes on soon...)
I'm pretty sure I got it:
If I pasted the
cscript-statement into the standard shell invoked by running "cmd" without elevated privileges the prompt says something like '"cscript" is mispelled or unkown".
Once I repeated he same using an admin shell, the
cscript was processed and the updater continued until I got a popup saying "At least one copy of XYCopy is running....script will abort", but I suspect this is a different story.
So, I've just added "Path=C:\Windows\System32\" to the environment of my working account (which is not the admin one), and
IT WORKED!
But before I'm gonna be tricked I want make sure I did run the correct script: SimpleUpdater 10.40 has exactly 486 lines of code, right?
Never occurred on Win 7 to me, strange. Have no idea yet wether that's a specific setup/installation problem of my machine/account or a general one.
Thanks again for helping me and putting the right pointer.
Cheers,
Filehero
Re: SimpleUpdater - Rev. 10.40 / 2012/12/17
Posted: 19 Dec 2012 18:22
by Marco
Yes, 10.40 is 486 lines long.
Well, good to hear you find the cause. If someone else runs Win 8 we could see if it is generalized or not.
Re: SimpleUpdater - Rev. 10.40 / 2012/12/17
Posted: 19 Dec 2012 18:40
by serendipity
Marco wrote:
The waiting loop is a fine idea, but wait() is not supported yet, and I don't want to use unsupported thing. Petition for Don?
Actually I meant using the "exists" command (to check if the file becomes available) combined with "wait" command.
If you are comfortable with "wait" then we can use "run" command which has wait built-in, something like this for example:
Code: Select all
run "cmd /c ping -n 5 127.0.0.1",,2,0; msg "OK";
waits about 5 seconds until OK pops up.
btw, glad that Filehero figured the underlying problem.
Re: SimpleUpdater - Rev. 10.40 / 2012/12/17
Posted: 20 Dec 2012 08:06
by Marco
Eventually the timing/wait thing is not the problem, so I'm ok with leaving Wait() inside the vbs file.
Should changes be made, I don't like using ping either
It always seems something clumsy, not elegant to me. A dedicated function would be perfect. (Don, it's Xmas...)
I wonder if I should expand all the run commands to include full paths of the called exes.
Re: SimpleUpdater - Rev. 10.40 / 2012/12/17
Posted: 20 Dec 2012 15:31
by serendipity
Your are right, for now just leave it the way it is. after all is working fine.
Re: SimpleUpdater - Rev. 10.40 / 2012/12/17
Posted: 20 Dec 2012 19:40
by Marco
Ok, I basically replaced all the instances of "cscript" with "C:\Windows\System32\cscript.exe".
It works on my 7 x64; should work on 8 x64; should work on every other system. Please let me know if there's some incompatibility.
Re: SimpleUpdater - Rev. 10.40 / 2012/12/17
Posted: 20 Dec 2012 21:06
by serendipity
Marco wrote:Ok, I basically replaced all the instances of "cscript" with "C:\Windows\System32\cscript.exe".
It works on my 7 x64; should work on 8 x64; should work on every other system. Please let me know if there's some incompatibility.
Better would be to use %winsysdir%\cscript.exe.
Some might have Windows directory on other drives.
Re: SimpleUpdater - Rev. 10.40 / 2012/12/17
Posted: 20 Dec 2012 21:17
by Marco
Right.
Re: SimpleUpdater - Rev. 10.40 / 2012/12/17
Posted: 20 Dec 2012 21:41
by Filehero
Marco wrote:Right.
Works.
My most used XYScript!
Cheers,
Filehero
Re: SimpleUpdater - Rev. 10.40 / 2012/12/17
Posted: 20 Dec 2012 22:01
by serendipity
Marco wrote:Right.
Thanks Marco! working fine here too.