XYplorer Beta Club

PeterH wrote:Is there a lack of logic (or naming)?

Code: Select all

    + SCs listfolder enhanced: The "filesonly" argument is now called
      "flags" and has additional binary values that can be summed up
      (bitwise OR-ed) as desired.
      Syntax: listfolder([path=<curpath>], [pattern=*], [flags], _
                  [separator="|"])
        flags: (binary field)
          0: show folders and files, return full paths [default]
          1: show only files
          2: show only folders
          4: return the names without paths

If 1 shows files and 2 shows folders - shouldn't 3 show list+folders?
(And 0 show neither!)

If it would be named
1: don't show (=suppress) folders
2: don't show (=suppress) files
3: would suppress all, and 0 show all - as it seems to be coded now

admin wrote:"suppress all" would not be extremely useful...

admin wrote:Yes, 3 works as well for "show folders and files". I kept 0 for backward compatibility.

PeterH wrote:

admin wrote:"suppress all" would not be extremely useful...

Sure
But that's normal: not every logical combination must be useful

admin wrote:Yes, 3 works as well for "show folders and files". I kept 0 for backward compatibility.

A half OK for that: if 3 does show both, it's correct for the or-interpretation of "show ...", i.e. "show both". But still or-ing 2 times "not show" would mean show nothing...

So for reaching your desired compatibility it would have been better to come from the suppress-side of life?
0 = suppress nothing
1 = suppress a
2 = suppress b
3 = not extremely useful but logical in its meaning.

And, not fitting very bad with this:
4 = suppress path

Stefan wrote:This leads me to some questions:
..
2) Will recursive option come next?
..

Stefan wrote:$FolderList = folderreport(type="dirs", "r", "C:\Temp", "r")

Type: dirs: recursive list of all subfolders

admin wrote:

Stefan wrote:$FolderList = folderreport(type="dirs", "r", "C:\Temp", "r")

Type: dirs: recursive list of all subfolders

Good idea, done!

v9.90.0205 - 2011-02-04 12:38
    * SC folderreport enhanced:
        type:
          dirs: List of subfolders (like a flat Tree structure).

C:\Temp\_kunde
C:\Temp\adag

C:\Temp\aktuelle
C:\Temp\aktuelle VirenDefs

C:\Temp\FileGen
C:\Temp\FileGen1
C:\Temp\FileGen2

C:\Temp\adag
C:\Temp\_kunde

C:\Temp\aktuelle VirenDefs
C:\Temp\aktuelle

C:\Temp\FileGen1
C:\Temp\FileGen2
C:\Temp\FileGen

v9.90.0206 - 2011-02-04 19:10
    ! Folder Reports: Minor sorting bug since v9.90.0204. Fixed.

admin wrote:Complex reasons:

This case was a bug. I just fixed it:

The other cases .... Cannot be fixed.

$FolderList = "C:\Temp<crlf>" . folderreport("dirs", "r", "C:\Temp", "r"); 
//have to add the top-most folder to the report my own


  $LOOP=1;
  $ARRAY="";
  $Find="";


  while(true)
  {
   
    $Fold = gettoken($FolderList, $LOOP, "<crlf>");
    If ($Fold==""){break;}
    If ($LOOP > 100){break;} //limited for test only
    
     
    //do something for each folder, f.ex.:
    // msg $Fold,1;
    
    
    //my example code, list all *VBS files:
    $Find =  listfolder($Fold, "*.vbs", "1", "<crlf>");
    if ($Find != "")
    {
      $ARRAY = $ARRAY . $Find . "<crlf>";
      // msg $Fold,1;
      $Find =  "";
    }
    
   
  incr $LOOP;
  If ($LOOP > 99000){break;} //just have this idea to break an infinity loop in case of coding mistake 
  }
   
  text $ARRAY;
   
   

admin wrote:What do you want to prove with your test script?

admin wrote:I don't see why IF (exists() != 2) should not work.

admin wrote:Is it a junction?

C:\Temp>dir /AD
Datenträger in Laufwerk C: ist SYSTEM
Volumeseriennummer: 1234-5678

Verzeichnis von C:\Temp

09.02.2011 10:11 <DIR> .
09.02.2011 10:11 <DIR> ..
06.01.2010 10:30 <VERBINDUNG> adag
04.06.2010 06:48 <DIR> aktuelle
11.05.2010 15:00 <DIR> aktuelle VirenDefs
06.01.2010 14:47 <VERBINDUNG> cdag
21.05.2010 12:03 <DIR> FileGen
21.05.2010 12:03 <DIR> FileGen1
04.02.2011 13:05 <DIR> FileGen2

H:\a\Sysinternals>junction.exe c:\temp\adag

Junction v1.05 - Windows junction creator and reparse point viewer
Copyright (C) 2000-2007 Mark Russinovich
Systems Internals - http://www.sysinternals.com

c:\temp\adag: MOUNT POINT
   Substitute Name: Volume{007807e3-f90d-11de-b292-005056c00008}\

The context menu of Junctions 
has a special submenu Junction Target with these extra commands:

       Go to Junction Target
       Copy Junction Target Name