Ok, like everyone else here i started to look, so I'll give my 2 cents as well
- I agree with jc, no need for "Press", just leave "New Shortcut Key"
- It would be better if it was clean when we do not press a valid shortcut, eg don't let "Ctrl+Alt+???" when keys are released, clear it up (less confusing I think)
- A few keys behaves in ways they shouldn't I think:
F10 affects the focus, gives it to the menu (in this case the system/window ctxt menu, doen't popup but pressing down afterwards will have it shown)
Enter and Esc are accelerators for the Ok/Cancel buttons unless focus is on the textbox, bad thing, should behave the same on List too IMO (you can remove the accelerators here, no biggy & safer anyways)
- When pressing an already assign shortcut, it says to which command it is assigned to. That's cool. Even better would be a link/button there to "Go there", that would bring us to that category/command. Would also be a cool way of searching for shortcuts/commands...
- Speaking of which, pressing a key when the List has focus brings us to the first item starting with that letter, classic 'find as you type' feature. Only I'm not really sure it's that useful here but it actually is confusing, because it does it also when holding Ctrl for example.
So select a command, press Ctrl+O and you're moved to another command (eg. Open...)
- Just a note, you probably know it already but, with the popup the menu shortcuts (Rename Special, etc) it might beeps depending on the shortcut used. eg; Ctrl+R beeps, Ctrl+Alt+R doesn't
- Do you have to change the List visible area when a shortcut is assigned/removed, tis a little confusing at times, I think
- I understand the shortcuts list is alpha-sorted. Why not, but it could be nice to let us choose which one we want as "default" (ie shown in menus) Because one might use 2 shortcuts for one feature, but the first one in order might not be the one most likely to be used/easier to remember/shorter (as in in characters, for menu's width)
- Pressing keys to define a shortcut works on textbox & List, but it's always lost after we add one (focus gone), maybe you could reset it back so it's easier to assign a few shortcuts/replace a shortcut to the same command? Have it back to the list sounds the best to me, so after click on the button one can set a new shortcut or move to a next command using arrow keys.
- For the same reasons, I would probably recommand to change the tab order, to have List, Assign, Remove. So one can select a command on list using arrow keys, press the shortcut, Tab, Enter to assign it, and with the focus back automatically arrow keys allow to move on to the next command.
- As jc mentionned, Reset/Remove All buttons should make clear (in their confirmation popup) that it's a global thing, not limited to one category.
- Again like jc, I think it all shortcuts were aligned the same no matter how long the commands captions are would probably look better/less confusing.
I would also vote for having something that says "there's more than one shortcut assigned", eg add ", ..." if there are others
