Page 19 of 21
Re: SimpleUpdater — Rev. 10.67 / 2015/06/14
Posted: 01 Dec 2015 08:08
by bdeshi
oblivion wrote:SU still didn't work properly after I'd told XY just to use its own copy routines. I thought I'd broken something and was ashamed...
Fact is SU always uses the system-default copy handler, because the script offloads copy jobs to a vbscript, which is oblivious to XY's copy settings. AFAIK.
Re: SimpleUpdater — Rev. 10.67 / 2015/06/14
Posted: 08 Dec 2015 12:20
by Marco
Yes, SammaySarkar explained it right. SU is definitely sequential/synchronous in its workflow, so offloading file operations to TC will cause race conditions and similar issues.
Re: SimpleUpdater — Rev. 10.67 / 2015/06/14
Posted: 11 Dec 2015 16:01
by oblivion
Marco wrote:Yes, SammaySarkar explained it right. SU is definitely sequential/synchronous in its workflow, so offloading file operations to TC will cause race conditions and similar issues.
So if I understand what you've said here, if Windows does the copy part of the process everything will be nicely queued and nothing will happen until the copy's completed but if Teracopy does it the script thinks it can carry on as if the copy was complete when it hasn't started yet. That probably explains things -- the error was some sort of file not found thing, so if the script does "copy newxy to oldxy" then "delete newxy" there's every chance that the delete operation will have happened before the copy has got around to starting.
Thanks, that makes sense. I can live without Teracopy being the default.
Re: SimpleUpdater — Rev. 10.67 / 2015/06/14
Posted: 25 May 2016 22:22
by LittleBiG
Updater is broken from 16.80.0006. I can see superfluous "s in the menu and during the update check I get "incorrect filename" error.
Re: SimpleUpdater — Rev. 10.67 / 2015/06/14
Posted: 26 May 2016 00:19
by Marco
Confirmed. Something changed in how SC global is parsed. I'll file a bug report.
Meanwhile I suggest not to update to 16.80.0006 and onwards.
Re: SimpleUpdater — Rev. 10.67 / 2015/06/14
Posted: 26 May 2016 00:22
by PeterH
Could it be related to the changed precedence of the concat-character '.'?
Re: SimpleUpdater — Rev. 10.67 / 2015/06/14
Posted: 26 May 2016 00:28
by Marco
PeterH wrote:Could it be related to the changed precedence of the concat-character '.'?
It's related to this,
http://www.xyplorer.com/xyfc/viewtopic. ... 00#p138900
Basically, whitespaces after the first whitespace following the equal sign are considered part of the variable, and so are enclosing double quotes, and this makes (in my/LittleBiG's case) file paths invalid.
It's not related to the concat operator per se, but surely touching it led to a chain reaction.
Re: SimpleUpdater — Rev. 10.67 / 2015/06/14
Posted: 26 May 2016 00:53
by PeterH
Meanwhile I saw your bug report: seems you are right
Re: SimpleUpdater — Rev. 10.67 / 2015/06/14
Posted: 26 May 2016 11:07
by Marco
Fixed in 16.80.0008
Re: SimpleUpdater — Rev. 10.67 / 2015/06/14
Posted: 28 May 2016 20:01
by LittleBiG
Still not perfect. Do you have any advice?
Re: SimpleUpdater — Rev. 10.67 / 2015/06/14
Posted: 31 May 2016 12:45
by Marco
Do know that it's on my list. I had some really, really busy days.
It's an effect of the change of precedence of the dot operator. The script works just fine, only that message is blank. I'll (hopefully) upload a beta fix soon.
Re: SimpleUpdater — Rev. 10.67 / 2015/06/14
Posted: 31 May 2016 13:46
by bdeshi
Line 194.
Find
Code: Select all
if (confirm((("$major_changelog" == "1" AND compare("$major_version", "<xyver>", "v") == "1") OR "$beta_changelog" == "1")?"":"$str00500_yLb2oLZnSvh3<crlf>"."$str00600_yLb2oLZnSvh3") == "0")
Replace
Code: Select all
if (confirm(((("$major_changelog" == "1" AND compare("$major_version", "<xyver>", "v") == "1") OR "$beta_changelog" == "1")?"":"$str00500_yLb2oLZnSvh3<crlf>")."$str00600_yLb2oLZnSvh3") == "0")
ed. Whoo, no offense but parsing ((nested conditions)) AND ternaries (in (one line))) is tough if you didn't brew it yourself...
ed2. I'm still not 100% sure this is the correct "patch"...
Re: SimpleUpdater — Rev. 10.67 / 2015/06/14
Posted: 01 Jun 2016 18:19
by Marco
Yes Sammay, your patch is correct
I must confess that I had to recall what exactly I wanted to achieve with that ternary
I'll upload the final tonight.
Re: SimpleUpdater — Rev. 10.67 / 2015/06/14
Posted: 01 Jun 2016 18:30
by bdeshi
Marco wrote:I must confess that I had to recall what exactly I wanted to achieve with that ternary
Maybe you thought about alternating between "A new version of XYplorer is available." or "A new beta version of XYplorer is available."? This whole line goes missing currently.
Re: SimpleUpdater — Rev. 10.68 / 2016/06/01
Posted: 01 Jun 2016 18:47
by Marco
More or less.
The script workflow is:
-show changelogs (if changelogs are enabled)
-ask the user if he wants to update (if such prompt is enabled)
If changelogs are actually shown (and they're only shown when there's a new version) then the user knows that there's a new build available, so there's no point in saying "Hey there's a new version. Wanna update?". I'll just say "Wanna update?". However, if changelogs are disabled, I'll go with the full phrase.
I know, subtleties
