Page 12 of 21

Re: dark theme

Posted: 18 Dec 2018 18:57
by Marco
Another small glitch: turn Dark mode on and off, and I can see those leftovers. The "Dark border (1 px)" disappears.

Re: dark theme

Posted: 18 Dec 2018 22:35
by admin
Confirmed. Fixed soon.

Re: dark theme

Posted: 19 Dec 2018 07:42
by vrtarifaachen
admin,
This may be an obvious question, but should title bar & menu bar be white like this?
Image

Re: dark theme

Posted: 19 Dec 2018 08:08
by admin
Windows controls these colors. Can't do anything.

(AFAIK. You never know what you can do in the future...)

Re: dark theme

Posted: 19 Dec 2018 08:09
by vrtarifaachen
I forgot to mention - I have dark mode for windows 10. And my theme is set to dark gray

Image

Re: dark theme

Posted: 19 Dec 2018 08:09
by vrtarifaachen
admin wrote: 19 Dec 2018 08:08 Windows controls these colors. Can't do anything.

Sorry forgot to mention - It IS set to dark in windows. This is puzzling!

See pic :
Image

I understand windows controls these colors, but do you know where they come from?

Re: dark theme

Posted: 19 Dec 2018 08:11
by admin
vrtarifaachen wrote: 19 Dec 2018 08:09
admin wrote: 19 Dec 2018 08:08 Windows controls these colors. Can't do anything.

Sorry forgot to mention - It IS set to dark in windows. This is puzzling!
Well, that looks like another Win10 bug then...

Are you saying that all windows apart from XYplorer are black now?

Re: dark theme

Posted: 19 Dec 2018 08:12
by vrtarifaachen
admin wrote: 19 Dec 2018 08:11
vrtarifaachen wrote: 19 Dec 2018 08:09
admin wrote: 19 Dec 2018 08:08 Windows controls these colors. Can't do anything.

Sorry forgot to mention - It IS set to dark in windows. This is puzzling!
Well, that looks like another Win10 bug then...

Are you saying that all windows apart from XYplorer are black now?
Do you know which setting controls this?

This is what i see in settings:
Image

Re: dark theme

Posted: 19 Dec 2018 08:41
by admin
I meant: Are all apps apart from XYplorer black now?

Re: dark theme

Posted: 19 Dec 2018 08:44
by vrtarifaachen
admin wrote: 19 Dec 2018 08:41 I meant: Are all apps apart from XYplorer black now?

No I don’t think so. I am seeing most of my apps with the same

Re: dark theme

Posted: 19 Dec 2018 08:47
by Leito
admin wrote: 19 Dec 2018 08:11 Well, that looks like another Win10 bug then...

Are you saying that all windows apart from XYplorer are black now?
No, not at all.

Current state in Windows 10 1809 is:
  • There is a setting to choose between light and dark theme (Settings → Personalization → Colors → Choose your default app mode)
  • Windows Explorer honor this setting.
  • Most UWP apps honor this setting.
  • But controls (menus, buttons...) on Win32 apps are not affected by this setting.

Re: dark theme

Posted: 19 Dec 2018 16:50
by elqasar2
"Panes, Sync Select..." doesn't look right in dark mode. Black labels next to the checkboxes, on a dark gray background?

I haven't checked every dialog in the application. Maybe there are other places with the same problem.

Re: dark theme

Posted: 19 Dec 2018 16:55
by elqasar2
In Dark mode, the Tree has a bright white border all around it, while the Catalog (and pretty much everything else) has a subtle gray border. Why the inconsistency?

I don't see this problem with a fresh XYplorer, but I do see it with a very slightly customized one. I'm not yet sure which setting is responsible for the bright white border that is visible only around the Tree.

Re: dark theme

Posted: 19 Dec 2018 17:09
by admin
Thanks, fix comes.

Re: dark theme

Posted: 19 Dec 2018 17:27
by elqasar2
admin wrote: 19 Dec 2018 17:09Thanks, fix comes.
For which of the 2 issues, the Dual Pane Select dialog, or the Tree border?

By the way, I've found that I can reproduce the bright white border issue in a fresh XYplorer. All I need to do is enable Windows Theme Style for borders, and then toggle dark mode on and off a few times. Then I see the bright white border.
whiteborder.png
whiteborder.png (47.64 KiB) Viewed 3312 times