Page 11 of 21

Re: dark theme

Posted: 17 Dec 2018 22:31
by Filehero
admin wrote: 16 Dec 2018 12:35 I'm starting to get used to it. After working a longer time with dark, the light mode feels pretty aggressive to the eyes...
Yep, I'm starting to consider it for standard use as well. :)

However, some - well, in fact one - contrasts seems to be overdone when inverted.

My light mode, note the vertical column separator lines in the list appear very faint - which is what I want.
light_mode.png
light_mode.png (21.04 KiB) Viewed 3142 times

Now with dark mode, these lines are a tad too dominant for my liking. Is this color the same as for the inactive tab header borders?
dark_mode.png
dark_mode.png (19.46 KiB) Viewed 3142 times


Another one - breadcrumbs

Pane 1 (top)
Bcrumbs_green_light.png
Bcrumbs_green_light.png (30.34 KiB) Viewed 3142 times
Now in dark mode - knowing the active pane form the inactive one is rather guessing.
Bcrumbs_green_dark.png
Bcrumbs_green_dark.png (31.08 KiB) Viewed 3142 times

Pane 2 (bottom)
Bcrumbs_red_light.png
Bcrumbs_red_light.png (25.93 KiB) Viewed 3142 times
Bcrumbs_red_dark.png
Bcrumbs_red_dark.png (26.93 KiB) Viewed 3142 times
Here it's a bit clearer visually. I wonder, why there shouldn't be colored breadcrumbs in dark mode.



Last utility issue: I had to adapt some colors, mostly desaturation. Of course, it was easy by copying existing ones and deactivate them. Now I wonder how to toggle them easily all at once when flipping GUI mode. Is SC colorfilter() the way to go? I would have to double the color filter definitions in the script, right?

Re: dark theme

Posted: 17 Dec 2018 22:59
by admin
1) You are right, I will adjust the grid line luminance.

2) Breadcrumbs. That was a bug! :bug: :tup: :beer:

3)
Filehero wrote: 17 Dec 2018 22:31Last utility issue: I had to adapt some colors, mostly desaturation. Of course, it was easy by copying existing ones and deactivate them. Now I wonder how to toggle them easily all at once when flipping GUI mode. Is SC colorfilter() the way to go? I would have to double the color filter definitions in the script, right?
Hmm, don't know. I don't script so much... :)

Re: dark theme

Posted: 17 Dec 2018 23:24
by Filehero
admin wrote: 17 Dec 2018 22:59 3)
Filehero wrote: 17 Dec 2018 22:31Last utility issue: I had to adapt some colors, mostly desaturation. Of course, it was easy by copying existing ones and deactivate them. Now I wonder how to toggle them easily all at once when flipping GUI mode. Is SC colorfilter() the way to go? I would have to double the color filter definitions in the script, right?
Hmm, don't know. I don't script so much... :)
Thanks for 1) and 2). :D

As for 3)
If all GUI-defined color filters would have (and show) an explicit ID (e.g., a number), these IDs (numbers) could be passed as a list to SC colorfilter() ... :wink:

Re: dark theme

Posted: 18 Dec 2018 08:36
by Leito
admin wrote: 17 Dec 2018 11:59
Leito wrote: 17 Dec 2018 10:58 All my labelled items are displayed white on [back color] (whereas they're all configured black on [back color] in Configuration):
I could reproduce it now. Interesting case. Anyway, should be fixed next.
Fixed, thanks! :tup:

Re: dark theme

Posted: 18 Dec 2018 12:37
by Leito
Don, could you share your algorithm used to darken colors on the dark mode?
  • Colors and Styles → Colors → Breadcrumb Bar
  • Colors and Styles → Lines, Planes, Dark Mode → Selections in focused controls
  • Colors and Styles → Lines, Planes, Dark Mode → Selections in non-focused controls
  • Information → Tags → Labels
  • ...
I'd like to change those colors on the dark mode, but it's not easy since it isn't WYSIWYG on the Configuration window, thus I'd like to be able to compute colors I need by reversing your algorithm.

Re: dark theme

Posted: 18 Dec 2018 12:48
by admin
Well, I could offer the opposite way: Show them in config as they are in dark mode.

Re: dark theme

Posted: 18 Dec 2018 13:26
by Leito
That would be even better! :tup:

Would you do all the Colors and Styles → Colors section?

Re: dark theme

Posted: 18 Dec 2018 13:39
by admin
Should be. But I'd say this is for phase 2.

Re: dark theme

Posted: 18 Dec 2018 14:12
by Leito
Great, I'll wait for this! :biggrin:

Re: dark theme

Posted: 18 Dec 2018 15:20
by Leito
:bug: Seems like another bug:
  • Set a label to an item in list.
  • Select the item.
  • Lose focus from the tab (change pane or change window).
→ The item text changes from black to white.

Image

If the labelled item isn't selected, its text stays black.

Re: dark theme

Posted: 18 Dec 2018 17:45
by admin
Don't manage to reproduce. :?

Re: dark theme

Posted: 18 Dec 2018 17:51
by admin
Ah, full row select!?!

Re: dark theme

Posted: 18 Dec 2018 17:56
by Leito
admin wrote: 18 Dec 2018 17:51 Ah, full row select!?!
Always :mrgreen:

Re: dark theme

Posted: 18 Dec 2018 18:01
by admin
Wasn't even a dark mode bug. Same problem in light mode. Anyway, fixed!

Re: dark theme

Posted: 18 Dec 2018 18:22
by Leito
Arg, too late, you're too quick to release betas :mrgreen: : I just noticed that the same bug also happens with color filters that have a back color.