Is this how custom copy is supposed to work

[highend]

If this condition is met then there is no other reasonable option than renaming the folder! It would be total rubbish to copy a folder into itself. So I will change the current behavior: In this case the folder is also renamed when "Rename folders on collision" is not ticked.

Isn't the same valid for files if source and destination path is the same (so you would copy a file over itself)? In that case the name collision check could probably be skipped and the copy+suffix created immediately. Or at least could you add an option to do so like "Skip name collision check if source and destination are equal"? It would restore a bit of the simpleness that was there before we had custom copy.

[admin]

If this condition is met then there is no other reasonable option than renaming the folder! It would be total rubbish to copy a folder into itself. So I will change the current behavior: In this case the folder is also renamed when "Rename folders on collision" is not ticked.

Isn't the same valid for files if source and destination path is the same (so you would copy a file over itself)? In that case the name collision check could probably be skipped and the copy+suffix created immediately. Or at least could you add an option to do so like "Skip name collision check if source and destination are equal"? It would restore a bit of the simpleness that was there before we had custom copy.

Yes, almost. It's harder to decide because we have the "on name collision" setting. If the user opts for "Ask" I should probably do what he wants and offer the set of choices we have. Only "Overwrite" and "Overwrite if newer" are clearly nonsense options (when dest and source are same), and currently in these cases the files are skipped without further notice. Should they rather be auto-renamed? Hm, not sure.

[admin]

OK, I made my decision concerning the files:

Code: Select all

    * Backup / Custom Copy: From now on, files that are copied in-place 
      (copied onto themselves) are unconditionally auto-renamed 
      (incremental suffix) IF the setting for "On name collisions" is 
      "Ask" or "Overwrite if newer" or "Overwrite".
      Before, you got a stupid overwrite dialog asking whether you want 
      to overwrite a file with itself.

[highend]

Backup / Custom Copy: From now on, files that are copied in-place
(copied onto themselves) are unconditionally auto-renamed
(incremental suffix) IF the setting for "On name collisions" is
"Ask" or "Overwrite if newer" or "Overwrite".
Before, you got a stupid overwrite dialog asking whether you want
to overwrite a file with itself.

Good change imho.