[fixed in 24.50.0204] Custom File Icons not working on all drives

Things you’d like to miss in the future...
Forum rules
You might want to read this if you're looking for priority service

:info: Please Include The Following Information
1) Your XYplorer Version (e.g., v28.00.0801)
2) Your Windows Version (e.g., Win 11)
3) Your Screen Scaling Percentage (e.g., 125%).

:info: Use Your Profile Or Signature
We strongly recommend adding your Windows Version and Screen Scaling Percentage to the Location field in your Profile or to your Signature. That way, you only have to type them once, and we won't have to search for that vital information.

:info: How To Attach Images
When attaching an Image, please use the Attachment tab at the bottom of your post and click "Add files".
daniel_m
Posts: 239
Joined: 11 Apr 2010 11:47
Location: Windows 10 Pro 22H2, scaling 100%

Re: Custom File Icons not working on all drives

Post by daniel_m »

Alright, I tested the following custom file icons:

Code: Select all

*.txt>ABS96_coloured-folders_icons.dll /10
code\>ABS96_coloured-folders_icons.dll /12
*\ /xn>ABS96_coloured-folders_icons.dll /18
*\ /e>ABS96_coloured-folders_icons.dll /2 //matches all empty folders
I tested a fresh installation of XYplorer 24.50.0201 and only copied the icon DLL into the fresh \Data folder.
  • TXT files get their custom icon on C, H, and Q (network), but not on D, E, and G.
  • The "code" folder gets a custom icon on all drives (local and network).
  • An access denied folder called "access" gets the custom icon on C, H, and Q (network), but not on D, E, and G.
  • An access denied system folder "System Volume Information" gets the custom icon on C, D, E, and Q (network), but not on G ang H.
  • Empty folders get their custom icon on C and H, but not on D, E, G, and Q (network).
I noticed something interesting when creating a new TXT file on D, E, and G: The TXT file gets the correct (custom) icon for a split second, before it gets replaced by the standard icon.
XYplorer x64 (often the latest beta), Windows 10 Pro 22H2, 3840x2160 scaling 100%

admin
Site Admin
Posts: 67226
Joined: 22 May 2004 16:48
Location: Win8.1, Win10, Win11, all @100%
Contact:

Re: Custom File Icons not working on all drives

Post by admin »

daniel_m wrote: ↑20 Jun 2023 17:51 I noticed something interesting when creating a new TXT file on D, E, and G: The TXT file gets the correct (custom) icon for a split second, before it gets replaced by the standard icon.
On a fresh installation (apart from CFI)?

daniel_m
Posts: 239
Joined: 11 Apr 2010 11:47
Location: Windows 10 Pro 22H2, scaling 100%

Re: Custom File Icons not working on all drives

Post by daniel_m »

admin wrote: ↑20 Jun 2023 18:26 On a fresh installation (apart from CFI)?
I tested both "::fresh;", and moving the \Data folder out of the \XYplorer folder. The only customisations were the cfi and the icon DLL.
XYplorer x64 (often the latest beta), Windows 10 Pro 22H2, 3840x2160 scaling 100%

admin
Site Admin
Posts: 67226
Joined: 22 May 2004 16:48
Location: Win8.1, Win10, Win11, all @100%
Contact:

Re: Custom File Icons not working on all drives

Post by admin »

Ultraweird. What's wrong with your machine? ;) Doesn't trigger any idea ATM. :maf:

daniel_m
Posts: 239
Joined: 11 Apr 2010 11:47
Location: Windows 10 Pro 22H2, scaling 100%

Re: Custom File Icons not working on all drives

Post by daniel_m »

I am clueless too. There is no consistency in this mess. Hopefully the next beta can give us some clue ...
XYplorer x64 (often the latest beta), Windows 10 Pro 22H2, 3840x2160 scaling 100%

jupe
Posts: 3569
Joined: 20 Oct 2017 21:14
Location: Win10 22H2 120dpi

Re: Custom File Icons not working on all drives

Post by jupe »

Do colorfilters for empty folders behave the same?, if you want to test you can run this temporary script, just run it again to undo,

colorfilter("B:prop:#empty:2>FFFFFF,0073E6");

daniel_m
Posts: 239
Joined: 11 Apr 2010 11:47
Location: Windows 10 Pro 22H2, scaling 100%

Re: Custom File Icons not working on all drives

Post by daniel_m »

Here is some more debugging information with ::exist from 24.50.0202 (extraction of the No-Install Package into an empty folder). Using a custom icon DLL or the XYplorer icons did not make a difference.
  1. The file attribute C affects (breaks) *\ /xn>, *\ /en>, and *.txt>
  2. The CFI code\> works on all drives, regardless of file attributes.
  3. Only on my network drive, *\> has priority over *\ /xn> and *\ /en>, but not code\>
  4. Edit: *\> doesn't work on drives D, E, and G either. I guess all folders there have the C attribute

*\ /xn>

Code: Select all

Working:
Real Path: C:\access                       Shell Icon: 3    GetFileAttributes: 0x2010 (8208) - DI
Real Path: H:\access                       Shell Icon: 3    GetFileAttributes: 0x2010 (8208) - DI
Real Path: Q:\access                       Shell Icon: 3    GetFileAttributes: 0x10 (16) - D
Real Path: C:\System Volume Information    Shell Icon: 3    GetFileAttributes: 0x16 (22) - HSD
Real Path: D:\System Volume Information    Shell Icon: 3    GetFileAttributes: 0x16 (22) - HSD
Real Path: E:\System Volume Information    Shell Icon: 3    GetFileAttributes: 0x16 (22) - HSD

Code: Select all

Not working:
Real Path: D:\access                       Shell Icon: 55   GetFileAttributes: 0x2810 (10256) - DCI
Real Path: E:\access                       Shell Icon: 55   GetFileAttributes: 0x2810 (10256) - DCI
Real Path: G:\access                       Shell Icon: 55   GetFileAttributes: 0x2810 (10256) - DCI
Real Path: G:\System Volume Information    Shell Icon: 55   GetFileAttributes: 0x816 (2070) - HSDC
Real Path: H:\System Volume Information    Shell Icon: 55   GetFileAttributes: 0x816 (2070) - HSDC

Here is the collected data from other CFIs:

code\>

Code: Select all

Working:
C:\code GetFileAttributes: 0x2010 (8208) - DI
D:\code GetFileAttributes: 0x2810 (10256) - DCI
E:\code GetFileAttributes: 0x2810 (10256) - DCI
G:\code GetFileAttributes: 0x2810 (10256) - DCI
H:\code GetFileAttributes: 0x2010 (8208) - DI
Q:\code GetFileAttributes: 0x10 (16) - D

Not working: none

*.txt>

Code: Select all

Working:
C:\New Text File.txt GetFileAttributes: 0x2020 (8224) - AI
H:\New Text File.txt GetFileAttributes: 0x2020 (8224) - AI
Q:\New Text File.txt GetFileAttributes: 0x20 (32) - A

Not working:
D:\New Text File.txt GetFileAttributes: 0x2820 (10272) - ACI
E:\New Text File.txt GetFileAttributes: 0x2820 (10272) - ACI
G:\New Text File.txt GetFileAttributes: 0x2820 (10272) - ACI

*\ /en>

Code: Select all

Working
C:\empty GetFileAttributes: 0x2010 (8208) - DI
H:\empty GetFileAttributes: 0x2010 (8208) - DI
Q:\empty GetFileAttributes: 0x10 (16) - D

Code: Select all

Not working
D:\empty GetFileAttributes: 0x2810 (10256) - DCI
E:\empty GetFileAttributes: 0x2810 (10256) - DCI
G:\empty GetFileAttributes: 0x2810 (10256) - DCI
Last edited by daniel_m on 20 Jun 2023 22:35, edited 2 times in total.
XYplorer x64 (often the latest beta), Windows 10 Pro 22H2, 3840x2160 scaling 100%

daniel_m
Posts: 239
Joined: 11 Apr 2010 11:47
Location: Windows 10 Pro 22H2, scaling 100%

Re: Custom File Icons not working on all drives

Post by daniel_m »

jupe wrote: ↑20 Jun 2023 21:55 Do colorfilters for empty folders behave the same?, if you want to test you can run this temporary script, just run it again to undo,

colorfilter("B:prop:#empty:2>FFFFFF,0073E6");
Thanks for the suggestion :) . The colour filter works on all drives. Only custom icons are affected.
XYplorer x64 (often the latest beta), Windows 10 Pro 22H2, 3840x2160 scaling 100%

jupe
Posts: 3569
Joined: 20 Oct 2017 21:14
Location: Win10 22H2 120dpi

Re: Custom File Icons not working on all drives

Post by jupe »

It looks like the drives that aren't working are compressed, so for folders they usually get the shell icon always (overrides CFI) with blue arrow overlay on Win10+, are you seeing the blue arrows overlay?

daniel_m
Posts: 239
Joined: 11 Apr 2010 11:47
Location: Windows 10 Pro 22H2, scaling 100%

Re: Custom File Icons not working on all drives

Post by daniel_m »

You are right. I didn't even think about compression when I saw the attribute C. After all, one of the many great features of XYplorer is to not show those damn blue arrows :biggrin:

Donald, do you think this could be fixed? I love CFIs, and foldername\> seems to work fine.
XYplorer x64 (often the latest beta), Windows 10 Pro 22H2, 3840x2160 scaling 100%

admin
Site Admin
Posts: 67226
Joined: 22 May 2004 16:48
Location: Win8.1, Win10, Win11, all @100%
Contact:

Re: Custom File Icons not working on all drives

Post by admin »

Ah, that's what I thought and hoped: Shell Icon: 55 for compressed. I guess I can fix it now. :cup:

...

Should be fixed for compressed folders in the next beta.

admin
Site Admin
Posts: 67226
Joined: 22 May 2004 16:48
Location: Win8.1, Win10, Win11, all @100%
Contact:

Re: Custom File Icons not working on all drives

Post by admin »

daniel_m wrote: ↑21 Jun 2023 00:13 You are right. I didn't even think about compression when I saw the attribute C. After all, one of the many great features of XYplorer is to not show those damn blue arrows :biggrin:
Hmm. I'm not sure if that is not a bug. :) So it does not show that special icon for compressed folders? Works here. :eh:

daniel_m
Posts: 239
Joined: 11 Apr 2010 11:47
Location: Windows 10 Pro 22H2, scaling 100%

Re: Custom File Icons not working on all drives

Post by daniel_m »

Beta 24.50.0203 is working fine for folders, but not for files yet ;)


admin wrote: ↑21 Jun 2023 09:17 Hmm. I'm not sure if that is not a bug. :) So it does not show that special icon for compressed folders? Works here. :eh:
No, for me, XYplorer does not show the blue arrows, while the Windows File Explorer does. But, I cannot rule out that my Windows installation has some setting (registry or group policy) that XYplorer follows, while WFE doesn't. Honestly, the blue arrows overlay is :masked: :blackstorm: . It might be useful if you are looking at a mixture of compressed and non-compressed files. But when you compress a whole drive, it becomes pointless, and it obscure file and folder icons. And you can still activate to show compressed file/folder names in a different colour to easily identify them.
XYplorer x64 (often the latest beta), Windows 10 Pro 22H2, 3840x2160 scaling 100%

admin
Site Admin
Posts: 67226
Joined: 22 May 2004 16:48
Location: Win8.1, Win10, Win11, all @100%
Contact:

Re: Custom File Icons not working on all drives

Post by admin »

daniel_m wrote: ↑21 Jun 2023 15:29 Beta 24.50.0203 is working fine for folders, but not for files yet ;)
You have an example of a file CFI definition that does not work?

daniel_m
Posts: 239
Joined: 11 Apr 2010 11:47
Location: Windows 10 Pro 22H2, scaling 100%

Re: Custom File Icons not working on all drives

Post by daniel_m »

Yes: *.txt>ABS96_coloured-folders_icons.dll /10. That's the one where creating a new TXT file shows the custom icon for a split second, before it gets replaced by a generic blank file item.

Compressed drive, *.txt>ABS96_coloured-folders_icons.dll /10 showing blank file icon:

Code: Select all

CFI disabled:
Shell Icon: 52
Custom File Icon: 52 (enabled)

CFI enabled:
Shell Icon: 52
Custom File Icon: 57 (enabled)

Non-compressed drive, *.txt>ABS96_coloured-folders_icons.dll /10 working:

Code: Select all

CFI disabled:
Shell Icon: 126
Custom File Icon: 126 (enabled)

CFI enabled:
Shell Icon: 126
Custom File Icon: 807 (enabled)
Last edited by daniel_m on 21 Jun 2023 18:33, edited 1 time in total.
XYplorer x64 (often the latest beta), Windows 10 Pro 22H2, 3840x2160 scaling 100%

Post Reply