XYplorer Beta Club

admin wrote: ↑11 Sep 2020 20:47 In the meantime I had a better idea. Instead of that tweak I will simply use the existing command menu "Edit | Find Files..." (Ctrl+F) to pop that little "Find Files" dialog, so one can have both Quick Search and Find Files side by side. Next beta...

Not 100% sure about this (people might actually use Ctrl+F for what it does now). Here are some options I see:
1) Ctrl+F now pops the new Find Files dialog (instead of opening the Find Files tab and placing the cursor into the Name field).
2) A checkbox in config to control the behavior of F3 (Quick Search or Find Files) -- that's what the new FindNameSearchToFindFiles tweak does.
3) A checkbox right on the Quick Search dialog to decide Quick Search or Find Files, remembered across sessions.
4) A checkbox in config to enable option 1).
5) Leave it as it is now: just a tweak.

Opinions?

3) It's clearly visible what mode is used and changeable on the fly

Agree, 3) seems to be the best option.

There is even something cooler than a checkbox: mini toolbar!.

Is the magnifier icon a toggle that switches between those two windows, otherwise I don't get it.

Yes, it's a toggle button: When you press it you go to Find Files mode.

Ok, in other words:
01. In "Find Files" mode: It is just another quick form of the find files GUI (that doesn't get in the way) that allows you to enter a search pattern only, while taking all other settings from the find files tab into account
02. In "Quick Search" mode: Nothing has changed, it's the normal quick search that would require /... arguments (like /excl=, /x, ...) like it has always done

Yep

I'll guess I'll never use it (the find files short form). It would require me to be able to remember every setting / checkmark that is currently active without having the panel open.

Imho something like this would be more desirable:
- It's okay that a toggle between quick search and find files exists (like in your screenshots)
- But:
= The find files mini gui should have one additional toggle
= A toggle to quickly show / hide the find files panel so that you can check if your current search settings are what you need (that spares a few hotkeys to remember/press)
= Additionally it should minimize the find files panel (if it is open) once the search is started

Or alternatively:
Just a checkbox in the find files panel if the panel should be minimized when the search is started (again, remembered across sessions like all other find files panel options).

Or maybe I just don't understand which advantage the current implementation would yield.

Well, I think it's useful for users who always (or in a longer situation) use the same general find settings (apart from the name pattern). It's just quicker that way, and the Info Panel is out of the way.

I see the point in your additional ideas, but I don't like the cluttering that comes with them. So I would implement it like this and then see what happens. If it turns out to be useless I can still throw it away or improve it.

The toggle icon tooltip is wrong / not correctly updated when in find files mode...

highend wrote: ↑12 Sep 2020 13:30 The toggle icon tooltip is wrong / not correctly updated when in find files mode...

When the button has a pressed state it's okay to leave the tooltip as it is.

Is it correct that this new button is visible in all the other dialogs, like eg. Set Visual Filter, Selection Filter, Goto etc...?

jupe wrote: ↑25 Sep 2020 05:44 Is it correct that this new button is visible in all the other dialogs, like eg. Set Visual Filter, Selection Filter, Goto etc...?

No!

I have noticed some weird behavior related to this change. Branch View #311 is normally toggleable on off. Now open the F3 dialog and change to the new find mode and press cancel in the dialog, then try and enter branch view again, it invokes a find panel search instead, using whatever tabs you have set in the find files panel (probz set some non-default tabs there first before testing), also now this "branch view" isn't toggleable anymore.