Page 2 of 2

Re: FavFolder GUI dialog

Posted: 16 Mar 2015 15:17
by bdeshi
here's another version: you can swap locations 1 and 2 now. [Only the xys was changed this time]

Re: FavFolder GUI dialog

Posted: 16 Mar 2015 16:50
by Stef123
Thank you. You seem to be reading my mind, always one step ahead. I was about to ask you about what goes where in DUAL mode - it got a bit confusing, depending on what side was active when I called up the script. So when turning DUAL off with the dialog open, it sometimes took another go-around to keep the wanted side and ditch the other one. Swapping sides on the dialog itself takes care of that.

2 minor issues:
Cancel would be a more fitting name for the Close-button imo. It sits right where you expect OK to be, so if don't press ENTER but use the mouse instead, it is very tempting to miss out on the tiny OK and click the obvious Close button and - contrary to what you'd expect - nothing has happened. Or make Close apply the changes and exit. Everybody knows how to cancel with the x-button anyway.

The active pane loses its focus when running the script. No big deal. Just wondering if you could activate the same pane again that was active at the outset.

Many thanks
Stef

Re: FavFolder GUI dialog

Posted: 16 Mar 2015 18:55
by bdeshi
Stef123 wrote:Thank you. You seem to be reading my mind,
My thoughts exactly! ... err, wrong quotation :kidding:
Stef123 wrote:when turning DUAL off with the dialog open, it sometimes took another go-around to keep the wanted side and ditch the other one. Swapping sides on the dialog itself takes care of that.


2 minor issues:
Cancel would be a more fitting name for the Close-button imo. It sits right where you expect OK to be, so if don't press ENTER but use the mouse instead
That's not my button to fix. Don owns that. Privately. In his source safe. Not allowing us to so much as touch it.
The active pane loses its focus when running the script. No big deal. Just wondering if you could activate the same pane again that was active at the outset.
That shouldn't happen. I swap panes to get the path of the inactive one, but swap back immediately! Just see the #802's near the top of the xys.

Anyways if capturing quick-search or visual-filters as part of locations aren't important to you, find-and-replace first codeblock with the second codeblock in the xys:

Code: Select all

 $favLoc1 = replace(replace(tab('get', 'term'), '<', '<'), '>', '>');
 #802;
 $favLoc2 = replace(replace(tab('get', 'term'), '<', '<'), '>', '>');
 #802;

Code: Select all

 //$favLoc1 = replace(replace(tab('get', 'term'), '<', '<'), '>', '>');
 $favLoc1 = replace(replace(get('path', a), '<', '<'), '>', '>');
 //#802;
 //$favLoc2 = replace(replace(tab('get', 'term'), '<', '<'), '>', '>');
 $favLoc2 = replace(replace(get('path', i), '<', '<'), '>', '>');
 //#802;

Re: FavFolder GUI dialog

Posted: 17 Mar 2015 10:12
by Stef123
Thanks for the hint. I replaced those 2 lines.
When I step through the script the active pane remains the same, just as you said it would. Without stepmode, however, this is not case. Focus gets lost to the other pane. Each and every time. No problem, though, it's just a tab away, just wondering ... :?:
SammaySarkar wrote:
Cancel would be a more fitting name for the Close-button imo.
That's not my button to fix. Don owns that.
No problem as long as I leave my mouse alone and operate the dialog with TAB and SPACE and RETURN. When using the mouse, however, the very standard looking CLOSE button is too irresistible to not click on it. Maybe you could make the OK button bigger, way bigger? To outsize close, to make users think before discarding the dialog without save. Could you intercept close and wedge in the OK function just before it closes?

Re: FavFolder GUI dialog

Posted: 17 Mar 2015 11:40
by bdeshi
Stef123 wrote:Thanks for the hint. I replaced those 2 lines.
When I step through the script the active pane remains the same, just as you said it would. Without stepmode, however, this is not case. Focus gets lost to the other pane. Each and every time. No problem, though, it's just a tab away, just wondering ... :?:
Weird... [ed] hey, go back to the #802 method and try putting wait 1; (or wait 10; or wait 100;) after the first #802;
Stef123 wrote:Maybe you could make the OK button bigger, way bigger? To outsize close, to make users think before discarding the dialog without save.
Sure. Find #submit {position:absolute;right:6px;bottom:6px;height:24px;width:24px} and set "width" to whatever size you want, or a percentage: width:80%
Stef123 wrote:Could you intercept close and wedge in the OK function just before it closes?
Well, i tried and it made XY mad. :evil:

Re: FavFolder GUI dialog

Posted: 17 Mar 2015 13:16
by Stef123
A wait value of 10 did the trick. :tup:
Also cranked up button dimensions to a size that dwarfs the close-button :titter: no way to ever mistake close with OK anymore :P -

Just as big - THANK YOU - and that's meant to be spelled in capitals. Quite happy with it now.
Stef

Re: FavFolder GUI dialog

Posted: 17 Mar 2015 13:47
by bdeshi
Don't mention it, it's my pleasure! :D