Page 8 of 20
Re: Portable file icons
Posted: 25 Apr 2013 20:15
by admin
Borut wrote:Don, maybe two suggestions:
* Maybe it would be a good idea if PFI would be suppressed in the default Icons folder. Reason: I have named some of my icons in such a way - well, you might call it stupid, or intelligent, or logical - that PFI is matching their names too (so I have to keep preview opened, to avoid confusion). (Of course, a general solution would be a list of "off range" directories, but well, that seems far fetched.)
Next version you can exclude the files in the default Icons folder by adding this line to CFI definitions:
Re: Portable file icons
Posted: 25 Apr 2013 20:39
by admin
This new exclusion thing has Boolean power... PFI is reaching (the first level of) perfection. 完全!
Re: Portable file icons
Posted: 25 Apr 2013 20:42
by Enternal
@ FluxTorpedoe
Damn. Those icons look great. Gotta added that to my icon arsenal.
@ Don
What do you think about adding a toolbar button that allows you to easily turn off/on PFI?
Re: Portable file icons
Posted: 25 Apr 2013 20:58
by admin
Enternal wrote:What do you think about adding a toolbar button that allows you to easily turn off/on PFI?
Technically no problem, but I get so many complaints about packed toolbars. And is this really a feature you often turn on and off?
Re: Portable file icons
Posted: 25 Apr 2013 21:03
by Enternal
admin wrote:Enternal wrote:What do you think about adding a toolbar button that allows you to easily turn off/on PFI?
Technically no problem, but I get so many complaints about packed toolbars. And is this really a feature you often turn on and off?
I don't know yet haha. I just thought it up since it's one of those on/off feature. But I do think it could come in handy if you want to quickly see what the original icons are to see what the default application is for that extension on a particular computer.
Re: Portable file icons
Posted: 25 Apr 2013 21:14
by TheQwerty
Enternal wrote:admin wrote:Enternal wrote:What do you think about adding a toolbar button that allows you to easily turn off/on PFI?
Technically no problem, but I get so many complaints about packed toolbars. And is this really a feature you often turn on and off?
I don't know yet haha. I just thought it up since it's one of those on/off feature. But I do think it could come in handy if you want to quickly see what the original icons are to see what the default application is for that extension on a particular computer.
Personally, I don't think it needs a toolbar button or a more accessible toggle.
Don, what's the reasoning of making the Properties tab show the PFI and not the true/original icon?
I'm not sure which makes better sense to me.
Re: Portable file icons
Posted: 25 Apr 2013 21:21
by admin
TheQwerty wrote:Don, what's the reasoning of making the Properties tab show the PFI and not the true/original icon?
I'm not sure which makes better sense to me.
My goal was to make the replacement total (within XYplorer). To see the original icon you can use shell properties from the context menu (or Alt+Enter).
Re: Portable file icons
Posted: 25 Apr 2013 22:08
by admin
40k wrote:Regmos wrote:I think this icon is rather appropriate
1.png
XYScript_Icon.zip
It's silly but I'm so proud to see one of my scripts in somebody else's scripts folder
You have another reason to be proud: You inspired this sensational killer feature!
Re: Portable file icons
Posted: 26 Apr 2013 13:01
by smahesh555
PFI implemented in one day
Don, Was it implemented from scratch or you were working on it before this wish as well ?
Either way as usual .. superb work.
Re: Portable file icons
Posted: 26 Apr 2013 13:04
by admin
Less than 12 hours, from scratch.
(Followed by one week of refinements.)
Re: Portable file icons
Posted: 26 Apr 2013 17:00
by Borut
A small cosmetic issue of no importance, but since everything else is so polished...
If the icon used for the current location is redefined, the tab icon does not change (the one in the tree changes nicely). It is only after changing the location and getting back that the tab icon changes.
BTW, thanks for implementing the exclusion logic.
Have a nice weekend!
Re: Portable file icons
Posted: 26 Apr 2013 17:04
by admin
Really? Works fine here.
Re: Portable file icons
Posted: 26 Apr 2013 23:07
by Borut
Seems to always work fine for tabs with locations on local drives.
With a server location I now (at home) experience the following: Tab icon returns to a standard icon, but not to the newly defined icon. The icons of all tabs seem to be rechecked, but those with network locations seem to be reset to the standard folder icon and not set to the newly defined one.
I think that my experience in the office was a bit different (but am not 100% sure): the tab icon seemed to simply stay unchanged (the previously defined special icon).
Can anyone confirm this?
Re: Portable file icons
Posted: 27 Apr 2013 03:45
by Enternal
That's odd. Mine is working as expected. Borut, could you try listing out steps again to reproduce the problem to make sure that everyone follows the same methods to get to your problem?
Re: Portable file icons
Posted: 27 Apr 2013 07:15
by Borut
Enternal, thank you for checking it.
Oooops, a fresh install seems to work completely as expected. Also when I copy all icons and icons definitions from my productive XYplorer into it, it still seems to work completely as expected (i.e. tab icons with both local and server locations change as expected).
I now have no idea into what direction to investigate this further. I am clueless. Very strange.
