history problem

[tedy]

Finally.
Thanks really!
I'll keep an eye on this for some time to make sure there isn't some hidden bug.

[admin]

Finally.
Thanks really!
I'll keep an eye on this for some time to make sure there isn't some hidden bug.

Actually I rewrote the whole history management code, it was really old and stinking. Now it's much shorter, faster, better.

[tedy]

Another glitch .

Sample folder structure:
D:\Temp
D:\Temp\en

- I'm in D:\
- I go to D:\Temp.
- I go to D:\Temp\en
- I go back to D:\Temp in history.
Now I have the history [D:\] - [D:\Temp] - [D:\Temp\en] - [D:\Temp*current] which is the expected.

- Now I rename en to bg and I have D:\Temp\bg.
I try to go back in history and nothing happens, of course I expected this to happen, the entry D:\Temp\en was just skipped and I'm in the first instance of D:\Temp, that's why nothing actually changed.
XY doesn't check if the target path that it decided to go into is the same as the current one.
I know this is in some sense the expected behavior but it would make more sense to check until a different history entry is reached.
Maybe just you could remove the invalid (non-existing) entries in the process, and any adjacent entry that duplicates.

Thanks.

[admin]

Another glitch .

Sample folder structure:
D:\Temp
D:\Temp\en

- I'm in D:\
- I go to D:\Temp.
- I go to D:\Temp\en
- I go back to D:\Temp in history.
Now I have the history [D:\] - [D:\Temp] - [D:\Temp\en] - [D:\Temp*current] which is the expected.

- Now I rename en to bg and I have D:\Temp\bg.
I try to go back in history and nothing happens, of course I expected this to happen, the entry D:\Temp\en was just skipped and I'm in the first instance of D:\Temp, that's why nothing actually changed.
XY doesn't check if the target path that it decided to go into is the same as the current one.
I know this is in some sense the expected behavior but it would make more sense to check until a different history entry is reached.
Maybe just you could remove the invalid (non-existing) entries in the process, and any adjacent entry that duplicates.

Thanks.

I'm not doing this on purpose. In the age of removeable drives, a non-existing path can become available again later.

[tedy]

I'm not doing this on purpose. In the age of removeable drives, a non-existing path can become available again later.

I see. I remember to have read something about that somewhere here.
Well, then maybe just skip not only non-existing entries but the ones that duplicate the current one? Without removing anything.

[admin]

I'm not doing this on purpose. In the age of removeable drives, a non-existing path can become available again later.

I see. I remember to have read something about that somewhere here.
Well, then maybe just skip not only non-existing entries but the ones that duplicate the current one? Without removing anything.

I think your example is a very rare case. And now, when I think about it, I'd even find it better to not skip unavailable items but show them as unavailable.

[tedy]

Yes, that's what Explorer is doing. A dialog with "Location not available" with a Ok. Very frustrating because this blocks the entire history!
Maybe as a last resort, if you'll show similar message, it would be non blocking, something like a tip or something.. At least it is something because now I feel confused why nothing happens in my case.
Thanks.

[admin]

Yes, that's what Explorer is doing. A dialog with "Location not available" with a Ok. Very frustrating because this blocks the entire history!
Maybe as a last resort, if you'll show similar message, it would be non blocking, something like a tip or something.. At least it is something because now I feel confused why nothing happens in my case.
Thanks.

I was not thinking of a dialog, just the normal non-blocking greyed out list with a message printed on it. Click on an empty CD drive in the tree and you see what I mean.

[tedy]

I was not thinking of a dialog, just the normal non-blocking greyed out list with a message printed on it. Click on an empty CD drive in the tree and you see what I mean.

Excelent . This is good, I didn't even know about that until now.
In Explorer when I click the (empty) DVD drive, it automatically opens its tray which is irritant. Happy to see XY not opening the tray.

[admin]

I was not thinking of a dialog, just the normal non-blocking greyed out list with a message printed on it. Click on an empty CD drive in the tree and you see what I mean.

Excelent . This is good, I didn't even know about that until now.
In Explorer when I click the (empty) DVD drive, it automatically opens its tray which is irritant. Happy to see XY not opening the tray.

Just implemented it. I noted that it always worked like this already when History per Tab was OFF -- an inconsistency which could be called a bug. Fixed.

[tedy]

Thanks But...
It seems it is not fixed yet.
The "Not Available" screen doesn't appear but it seems the history doesn't even skip the invalid path (see screenshot below).
Last time I made a small mistake in the explanation. See point 3. I select D:\Temp in the tree and not going back in history.

To build the tab history, I do:
1. I go to D:\Temp
2. I enter deeper in D:\Temp\other
3. I select in the tree D:\Temp again.
4. We have the history now D:\Temp - D:\Temp\other - D:\Temp
5. I rename other to other_renamed (as seen on the shot)
5. I try to go back in history -> I stay in D:\Temp (nothing changes), but when I open the tab history, I see selected the invalid D:\Temp\other

Screenshot.

[admin]

Thanks But...
It seems it is not fixed yet.
The "Not Available" screen doesn't appear but it seems the history doesn't even skip the invalid path (see screenshot below).
Last time I made a small mistake in the explanation. See point 3. I select D:\Temp in the tree and not going back in history.

To build the tab history, I do:
1. I go to D:\Temp
2. I enter deeper in D:\Temp\other
3. I select in the tree D:\Temp again.
4. We have the history now D:\Temp - D:\Temp\other - D:\Temp
5. I rename other to other_renamed (as seen on the shot)
5. I try to go back in history -> I stay in D:\Temp (nothing changes), but when I open the tab history, I see selected the invalid D:\Temp\other

Screenshot.

Right. But what to do? The path does not even exist in the tree. Where should I go?

[tedy]

Right. But what to do? The path does not even exist in the tree. Where should I go?

Well, I thought it would show the same in the right pane as when I click on an empty DVD drive - "Location Unavailable bla bla" on a darker background..?
You proposed this 1-2 days ago.
And we came up to an agreement that this is more informative than wondering what is happening (nothing) when going back and forth through invalid entries..

[admin]

Right. But what to do? The path does not even exist in the tree. Where should I go?

Well, I thought it would show the same in the right pane as when I click on an empty DVD drive - "Location Unavailable bla bla" on a darker background..?
You proposed this 1-2 days ago.

Yes, but these were things not existing in reality but in the tree.
Now we are talking about things not existing in reality nor in the tree.

[tedy]

Telling the truth I don't understand what exactly you do mean by the last post.
My screenshot shows the history state showing the "current" position flag next to an invalid path. All we talked about is the right pane (Details in this case) to be replaced by the same thing when I click on an empty DVD drive in this exact case. I see D:\Temp but the history state indicate I'm on the invalid D:\Temp\other.