Custom File Icons new switches

[jupe]

I was testing out the new CFI switches, and noticed that in 24.40.0209 all lnk links to normal folders get the Access Denied icon when using /x.

[noembryo]

Same thing here, too.
I must add that for the last couple of months, the .lnk files had the system's folder icon.
Previously they had the same custom icon that all the folders used in my system.
I can't remember the version that changed that though..

[jupe]

@noembryo: Yeah that was a requested and purposeful change, if you are talking about this:

Code: Select all

v24.10.0011 - 2023-02-25 09:28
    ! Custom File Icons: A specific LNK file icon assigned via Shell Context Menu 
      Properties was overwritten by the generic CFI file type icon. It shouldn't be. Fixed.

Maybe it should have only affected file, not folder links, although I can't see the issue you are describing.

[noembryo]

@noembryo: Yeah that was a requested and purposeful change, if you are talking about this:

Code: Select all

v24.10.0011 - 2023-02-25 09:28
    ! Custom File Icons: A specific LNK file icon assigned via Shell Context Menu 
      Properties was overwritten by the generic CFI file type icon. It shouldn't be. Fixed.

Maybe it should have only affected file, not folder links, although I can't see the issue you are describing.

I checked using a backup of 24.20.0300 and it has that problem (a minor annoyance perhaps)
Any folder.lnk file that I create has the default folder icon, although I use a CFI for open/closed folder..
With the current version, it has the "Access denied" icon, like @jupe reported.

[admin]

Coincidentally, I saw both problems this morning while looking at something else before seeing this thread. Should be fixed in the next beta.

[noembryo]

Coincidentally, I saw both problems this morning while looking at something else before seeing this thread. Should be fixed in the next beta.

Fixed.
Thank you..

[jupe]

Not sure if this matters, but while testing .0211, and I know it's only necessary to use one of the switches, but I noticed that if someone has 2 entries, one of each /f /e and no **\ entry then the curfolder in the tree ends up being the shell folder icon for normal folders.

[admin]

Yes, I saw that too. Fix on the way.

[jupe]

Historically when creating a menu or inputsel with a icon reference, I could just use an asterisk as shorthand (which I used extensively) for the default CFI folder icon, but now for inputsel (popupmenu ok) that always returns the Access Denied icon if a /x CFI entry exists. Now I do have the option of changing all my scripts over to use *.<DIR>, but that doesn't work in internal menus such as Favorites Folders captions anyway, whereas asterisk used to, so before I go about changing all the references, or decide to not use the /x CFI, I just thought I'd check if you think it is possible to restore the old behavior, which still works in popupmenu.

Code: Select all

  seticons("+*\ /x><xy>");
  $folders = regexreplace("<pickdirs * <xydata>>", "^(.+?)$", "$1||*.<DIR>");
  $folders = replace($folders, "\Panes||*.<DIR>", "\Panes||*");
  inputselect(, $folders, <crlf>, 1025);

[admin]

Works better in next beta.