Manually edited tags/labels aren't saved to disk

[1024mb]

I've been manually editing some orphans (files were renamed outside XYplorer) so I had to only change i.e. the extension but when I hit "OK" I see in the status bar "no saving required: tags" then if I choose "Setting special - Save Tags" I get the same message and after closing and reopening XYplorer the orphans return as if I did nothing. Also having the "Delete" option enabled so we can delete the orphans individually would be great, currently is only enabled when editing all tags.

[admin]

You are talking about Configuration | Information | Tags | Options... | Edit Orphans?

[1024mb]

You are talking about Configuration | Information | Tags | Options... | Edit Orphans?

Yes.

[admin]

I cannot reproduce any issue here. Edit Orphans saves any changes to file right away. You don't have to do any additional saving.

Wrong. Edit Orphans saves any changes to memory right away, not to file.

[1024mb]

I cannot reproduce any issue here. Edit Orphans saves any changes to file right away. You don't have to do any additional saving.

I can reproduce this on both instances I have. The exact steps are:

1. Configuration - Information - Tags - Options... - Edit Orphans (doesn't matter which one)
2. Select one entry, press F2, edit the path of one entry even adding just one letter.
3. Hit "OK" in that window, the status bar will say nothing to be saved.
4. Hit "OK" again.
5. File - Settings Special - Save Tags: It also says nothing to be saved.
6. Close XYplorer and reopen it
7. Check orphans, they will be unchanged.

By the way, if I for example apply a label to a file before doing step 6 the tag file does save to disk and the change done in step 2 is stored.
I don't think the amount of tagged files has anything to do here, right? One instance has 14025 and the other 4222 tagged files.

[admin]

I can reproduce this on both instances I have. The exact steps are:

1. Configuration - Information - Tags - Options... - Edit Orphans (doesn't matter which one)
2. Select one entry, press F2, edit the path of one entry even adding just one letter.
3. Hit "OK" in that window, the status bar will say nothing to be saved.
...

Not here. Describe in more detail.

[1024mb]

That's all I have to do to make it happen. What info do you need?
I do have lots of orphans.

OK, I have been doing some testings with a new fresh instance and while with the default settings it was working well (I couldn't reproduce this issue), it seems that after enabling "Save changes to disk immediately" this all starts, after enabling it I can now reproduce all what I said earlier.

Edit: Yes, disabled it on my other instances and they save the changes now.

[admin]

I repeat what I said earlier:
[quote=admin post_id=206188 time=1672770943 user_id=2]
Edit Orphans saves any changes to file right away.
[/quote]

So your claim "Manually edited tags/labels aren't saved to disk" is wrong. When you see "no saving required: tags" in the status bar, that's a logical consequence of enabling "Save changes to disk immediately". Just ignore it.

Wrong. Edit Orphans saves any changes to memory right away, not to file.

[1024mb]

I repeat what I said earlier:

Edit Orphans saves any changes to file right away.

So your claim "Manually edited tags/labels aren't saved to disk" is wrong. When you see "no saving required: tags" in the status bar, that's a logical consequence of enabling "Save changes to disk immediately". Just ignore it.

No, it's not only the notification, the actual tag.dat file isn't modified.
In the fresh instance, if I enable "Save changes to disk immediately" and then I edit orphans, besides getting the notification that there is nothing to be saved, the changes aren't saved to disk, if I reopen XYplorer and check the orphans they are untouched. If I disable that setting I obviously don't get any notification but if I close and reopen XYplorer the changes are saved and I can see the edited entries.

[admin]

Damn, you're right!

Fixed in next beta.

[1024mb]

Yes, now it's working well in that regard but I have another issue.

As the "Delete" button is not enabled when editing orphans in order to delete entries I have to click on the pencil button to enter "Editor Mode" but after deleting any lines and clicking OK, nothing is saved.

For example:

- Enter "Edit Orphans"
- Enter "Editor Mode".
- Delete a line.
- (Optional) Also edit a line i.e. adding a character to the path.
- Click OK
- Re-enter "Edit Orphans"
- You will see no changes were saved, not even the path editing.

But this does works without problems:

- Enter "Edit Orphans"
- Enter "Editor Mode".
- Edit a line i.e. adding a character to the path.
- Click OK
- Re-enter "Edit Orphans"
- You will see the changes were saved this time.

So it seems that deleting lines makes XYplorer not save the changes, I don't know if this is new or not, haven't tried doing this before. Is this intended? Because I would like to delete the orphans I know no longer exist.

[admin]

Yes, the "Delete" button is not enabled... this should tell you something. Delete is not supposed to work here.

[1024mb]

Yes, the "Delete" button is not enabled... this should tell you something. Delete is not supposed to work here.

Aaah, yes, I was suspecting as much, I should have taken the hint .

[1024mb]

It seems this not only applies to editing orphans. I tried the "Edit tagged items..." option and after deleting one entry I get the same behavior than before, "no saving required" message and tag.dat file unmodified.

[admin]

Cannot reproduce.