Catalogue:Rename function

[feeks]

Not certain if this would be regarded as a bug or an annoyance but ...

When performing a catalogue rename of a path-related catalogue item the rename is performed against the path and not the name of the shortcut which invalidates the path and therefore the shortcut.

This function works as I would expect for non-path items

Xyplorer v14.30.0300

[TheQwerty]

I can confirm.

If you have a catalog item with a defined path but empty caption then inline renaming that item within the catalog modifies the path instead of setting the caption.

[LittleBiG]

I can confirm.

If you have a catalog item with a defined path but empty caption then inline renaming that item within the catalog modifies the path instead of setting the caption.

I can't see it as a bug.

But I have 2 related bugs here:
1. If the catalog item doesn't have caption, pressing F2 opens the properties window. But if I choose right-click Rename (F2), I get the inline rename.
2. When the catalog item is a path without caption, and I change the path by inline rename (right-click Rename(F2)), the icon of the catalog item won't be refreshed.

[TheQwerty]

I consider it a bug since I don't believe renaming the item should change where it points.

[admin]

I can confirm.

If you have a catalog item with a defined path but empty caption then inline renaming that item within the catalog modifies the path instead of setting the caption.

I can't see it as a bug.

But I have 2 related bugs here:
1. If the catalog item doesn't have caption, pressing F2 opens the properties window. But if I choose right-click Rename (F2), I get the inline rename.
2. When the catalog item is a path without caption, and I change the path by inline rename (right-click Rename(F2)), the icon of the catalog item won't be refreshed.

Totally agree.

0. The original topic is neither a bug nor a problem IMO. Where would be the problem here?
1. Confirmed, both should open inline rename. Fix comes.
2. Confirmed. Fix comes.

[TheQwerty]

0. The original topic is neither a bug nor a problem IMO. Where would be the problem here?

The inline editor for a catalog item is triggered by the Rename command. Yet, modifying an item which has a location but no caption via this editor does not modify the caption - it changes the target.

This is unexpected behavior and as it is not tracked by the action log it is also potentially destructive since the user cannot undo it when they discover the (likely) broken item. To restore that item the user will have to either restore the entire catalog file (destroying any unsaved changes) or recreate the item (a PITA if they don't remember the location).

In my opinion renaming such an item should add a caption and kept its dirty paws off the location.

[admin]

The reason I made it like this was better workflow. Most of my items have no captions, and I quickly want to edit them without going through the Properties dialog.

Even if it's not the "real" caption written into the field called "Caption" it functions as the caption and looks like a caption. To me it's intuitive that the inline box changes what you see *as* the caption. I don't see where this is surprising.

[PeterH]

Just to say: I'm here with TheQwerty.

If I "rename" something I expect it to change it's name, i.e. caption, but not it's meaning.
And change an empty name means to give it a name.

[TheQwerty]

The reason I made it like this was better workflow. Most of my items have no captions, and I quickly want to edit them without going through the Properties dialog.

I understand why that behavior could be appealing, but I find it non-intuitive and dangerous as the default. That said we cannot just remove behavior which the King desires.

So I propose that either:
1) The default behavior in this case should be to add a caption and require a tweak/option be enabled to relocate on rename instead.

2) Renaming an item without caption should have a confirmation prompt:
This item has no caption.
Would you like to change its location?

Yes - Changes location.
No - Gives it a caption.
Cancel - Cancels

Which can have a corresponding option in Safety Belts: "Confirm relocating catalog items on rename"


I feel option 2 is the better one but it requires translations and you just bumped the MLS ref an hour ago so once again I'm too late.


In either case I hope we eventually see the action log expanded to cover more than just file operations.