admin wrote:So I think the fix/change was good (and from my POV it was definitely a bug because it was never intended like it was before the fix).
Well, here's why I disagree:
- you say it was never intended to work as it used to, yet that's how it worked and the documentation used delimiter for those, but separator for other cases, indicating that was - or could be seen as - the intent. And it was the way it worked.
- it's not a bug that made the value returned not right/formatted as expected on special circumstances, you changed the format of the returned value all the time
- you didn't change that because in a beta 2 days earlier you introduced those, and then realized separator was better than delimiter. You did change this:
Code: Select all
v7.60.0017 - 2008-09-19 09:09
+ Scripting got a new function.
Note: The command getinfo is converted into a function! Since it was
introduced after the last official release it's still considered
BETA so there's no compatibility code. IOW: You have to upgrade your
scripts if they use getinfo.
Name: GetInfo
Action: Get various info into variable.
Syntax: getinfo(info, [param1])
info: [required] sort of info (New: *NOT* case-sensitive!)
param1: [optional] depends on info
return: retrieved info
Possible values for info and param1:
- "CountSelected", [(unused)]
Count of selected items in List.
- "SelectedItemsPathNames", [delimiter=CRLF]
All selected items (full path) in List, delimited by param1.
- "SelectedItemsNames", [delimiter=CRLF]
All selected items (name, no path) in List, delimited by param1.
Examples:
::$a=getinfo("CountSelected"); msg $a;
::$a=getinfo("SelectedItemsPathNames", "|"); msg $a;
::msg getinfo("selecteditemsnames", chr(10));
And actually, one could argue not even since that was based on this:
Code: Select all
v7.60.0005 - 2008-09-12 15:14
+ Scripting got a new command:
- GetInfo
Action: Get various info into variable.
Syntax: getinfo output, info, [param1]
output: [required] variable
info: [required] sort of info (case-sensitive)
param1: [optional] depends on info
Possible values for info and param1:
- "CountSelected", [(unused)]
Count of selected items in List.
- "SelectedItemsPathNames", [delimiter=CRLF]
All selected items (full path/name) in List, delimited by
param1.
Examples:
::getinfo $a, "CountSelected"; msg $a
::getinfo $a, "SelectedItemsPathNames", "|"; msg $a
So what you call "fixing a bug" is changing the way a SC works, the format returned, and that from 7.60.0005 (2008-09-12) to v9.40.0007 (2010-08-10). You really think in during those almost 2 years no one ever got used to that format, that it was intended (since documented as such), and that such a change doesn't fall under "minor bug fix" but something that outta be mentioned (since it
will break things), at the very least on the help under the getinfo (get) function, and maybe on a separated scripting changelog that would list such major/important changes? Come on!
Again, I'm not against the change itself at all, but the way it was "done."