Page 2 of 3

Re: Branch View toolbar icon

Posted: 21 Mar 2019 10:49
by admin
Holy shit, your cherryphobia is disturbing. Anyway, here's my plan B, Cactus!

Re: Branch View toolbar icon

Posted: 21 Mar 2019 10:51
by Leito
Borut wrote:
21 Mar 2019 10:46
I find Leito's first suggestion self explaining, very appealing, and with a kind of certain calming effect, at least on me :)
It's my favorite as well:
  • There's branches → "Branch view"
  • There's horizontal green blocks that remind of elements in a list → List pane

Re: Branch View toolbar icon

Posted: 21 Mar 2019 10:54
by eil
Leito wrote:
21 Mar 2019 10:20
Here are my suggestions if you want to stay close to the nature:

Image
Image
quite like these 2.

Re: Branch View toolbar icon

Posted: 21 Mar 2019 11:00
by Borut
admin wrote:
21 Mar 2019 10:49
Holy shit, your cherryphobia is disturbing. Anyway, here's my plan B, Cactus!
:shock: Is it April 1st already? :mrgreen: Self-explanatory effect -> Zero. No desert around here. Needle-phobia quite omnipresent, I would expect.

Re: Branch View toolbar icon

Posted: 21 Mar 2019 11:04
by highend
I'd like to get the old icon back :/

And the color filters icon isn't really an improvement as well :titter:

Re: Branch View toolbar icon

Posted: 21 Mar 2019 11:13
by admin
Relax, I made something for you hopeless philistines:

Code: Select all

    + Scripting got a new command.
      Name: SetButton
      Action: Replaces a toolbar button image with one from a file.
      Syntax: setbutton(key, [file], [large=3], [flags=1])
        key:    Button key.
        file:   Image file.
                Defaults to the selected/focused file.
        large:  1 = Small image (16 x 16)
                2 = Large image (24 x 24)
                3 = Both [Default]
        flags:    (bit field)
          1 = Refresh the Toolbar when the replacement is done. [Default]
      Remarks:
        - The file can be larger than the image in which case it is
          automatically shrunk.
        - These changes are not permanent but last as long as the session.
      Examples:
        setbutton "flatview"; //replace small and large "flatview" image with the selected image file
        setbutton "flatview", "C:\Cactus.png" , 1;  //replace small "flatview" image with "Cactus.png"
        setbutton "flatview", "C:\Cactus.png" , 1;  //replace large "flatview" image with "Cactus.png"
Wow, apart from getting rid of cherries I see lots of interesting uses for this... :cup:

Re: Branch View toolbar icon

Posted: 21 Mar 2019 11:20
by highend
Wouldn't it make more sense to rename that command to SetButtonImage?

Apart from that: I don't think that people want to execute a button image changing script on each XY start so
can you find a way to let it make its changes permanent (as a flag)?

Re: Branch View toolbar icon

Posted: 21 Mar 2019 11:36
by admin
Yes, SetButtonImage is better.

No, impossible, these images are part of the executable.

Re: Branch View toolbar icon

Posted: 21 Mar 2019 11:36
by SammaySarkar
admin wrote:
21 Mar 2019 11:13
Wow, apart from getting rid of cherries I see lots of interesting uses for this... :cup:
Yay toolbar themes!

ed:
admin wrote:
21 Mar 2019 11:36
Yes, SetButtonImage is better.No, impossible, these images are part of the executable.
No! how about a new section in the ini that maps images to button keys?

Re: Branch View toolbar icon

Posted: 21 Mar 2019 12:09
by admin
SammaySarkar wrote:
21 Mar 2019 11:36
admin wrote:
21 Mar 2019 11:36
Yes, SetButtonImage is better.No, impossible, these images are part of the executable.
No! how about a new section in the ini that maps images to button keys?
Yes, that would work. :tup: Later...

Re: Branch View toolbar icon

Posted: 21 Mar 2019 13:22
by hogaty
Good is the design left, only the stem should be removed.
Borut wrote:
21 Mar 2019 10:46
Leito wrote:
21 Mar 2019 10:20
[...]
Here are my suggestions if you want to stay close to the nature:
Image
[...]
I find Leito's first suggestion self-explanatory enough, very appealing, and with a kind of certain calming effect, at least on me :) Cherries are - in my view - a bit too intrusive and definitely not self-explanatory.

Re: Branch View toolbar icon

Posted: 21 Mar 2019 14:36
by admin
admin wrote:
21 Mar 2019 12:09
SammaySarkar wrote:
21 Mar 2019 11:36
admin wrote:
21 Mar 2019 11:36
Yes, SetButtonImage is better.No, impossible, these images are part of the executable.
No! how about a new section in the ini that maps images to button keys?
Yes, that would work. :tup: Later...
Better idea: You can state folder (relative to <xydata>) in a new tweak, e.g. "PatchImagesPath=Patch", and place image files there, one for each button you want to patch, e.g. "flatview.png". That's it. XY handles the rest on startup.

Re: Branch View toolbar icon

Posted: 21 Mar 2019 14:41
by admin
BTW, I gave up. Before you burn my house I go back to a slightly modernized version of the original icon. Put the pitchforks down...

Re: Branch View toolbar icon

Posted: 21 Mar 2019 14:57
by SammaySarkar
:mrgreen:

At this point, I think calling that folder something like ToolbarTheme / ButtonTheme is okay. Granted that foldername can be changed, but "Patch" as default is a little generic.

Re: Branch View toolbar icon

Posted: 21 Mar 2019 15:03
by admin
Patch was just an example. You call it what you like.