dark theme

Features wanted...
Post Reply
admin
Site Admin
Posts: 60601
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: dark theme

Post by admin »

Leito wrote: 14 Dec 2018 18:12     Can you get rid of the horizontal scrollbar on the preview pane as well?
I don't see that here... :?

All your other issues seem to be Win10 related. Gonna look at that soon...

Leito
Posts: 561
Joined: 26 Sep 2016 15:37
Location: Windows 10 1809 x64

Re: dark theme

Post by Leito »

Screenshot to make sure what I mean:

Image

admin
Site Admin
Posts: 60601
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: dark theme

Post by admin »

The scrollbar disappears when you tick "Word Wrap".

Leito
Posts: 561
Joined: 26 Sep 2016 15:37
Location: Windows 10 1809 x64

Re: dark theme

Post by Leito »

Duuh... sorry. :oops:
Ok, case closed. :mrgreen:

Leito
Posts: 561
Joined: 26 Sep 2016 15:37
Location: Windows 10 1809 x64

Re: dark theme

Post by Leito »

Just so you know, I just tested with another machine, W10 1803 (so not the same version as my main which is 1809), and I don't have the bug #2 (white background on tab bar). I have #3 (white border around tabs) though.

admin
Site Admin
Posts: 60601
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: dark theme

Post by admin »

Was that a fresh installation?

Leito
Posts: 561
Joined: 26 Sep 2016 15:37
Location: Windows 10 1809 x64

Re: dark theme

Post by Leito »

No, an upgrade.

admin
Site Admin
Posts: 60601
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: dark theme

Post by admin »

I just tested it on Win10 (1803) and it looks good. The tab borders are from the theme and they are indeed brighter than in Win8.1. I will take care of this in the next beta...
Attachments
XY-Dark-Win10 (1803).png
XY-Dark-Win10 (1803).png (66.63 KiB) Viewed 1631 times

admin
Site Admin
Posts: 60601
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: dark theme

Post by admin »

Leito wrote: 14 Dec 2018 21:14No, an upgrade.
So it might be some setting... but which? :eh:

Leito
Posts: 561
Joined: 26 Sep 2016 15:37
Location: Windows 10 1809 x64

Re: dark theme

Post by Leito »

admin wrote: 14 Dec 2018 21:23 So it might be some setting... but which? :eh:
Found it!

Code: Select all

TabFlatBack=1 ⇒ No white background
TabFlatBack=0 ⇒ White background
What setting does it corresponds to?

admin
Site Admin
Posts: 60601
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: dark theme

Post by admin »

It's a tweak!

Ok, thanks, and fix coming in next version... :tup:

Leito
Posts: 561
Joined: 26 Sep 2016 15:37
Location: Windows 10 1809 x64

Re: dark theme

Post by Leito »

Hmm, I don't understand when and why I would have set it to 0... :veryconfused:

Anyway, I'll go with TabFlatBack=1 now since it removes some gray lines on the tab bar and those bothered me. :mrgreen:

admin
Site Admin
Posts: 60601
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: dark theme

Post by admin »

I might just remove the whole tweak and hardcode it to TabFlatBack=1.

Any objections anybody?

Leito
Posts: 561
Joined: 26 Sep 2016 15:37
Location: Windows 10 1809 x64

Re: dark theme

Post by Leito »

Don, once again I've discovered that just now because I wasn't using XYplorer Classic Style before, but: in thumbnails view, the selection box background isn't drawn behind the file name. I think it looks better in Windows Theme Style because there's not a "hole" in the selection box where the file name is displayed:

Image

Is that something you could change?

admin
Site Admin
Posts: 60601
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: dark theme

Post by admin »

Isn't that related to Color Filters?

Post Reply