Dark Mode and Toolbar Buttons

Please check the FAQ (https://www.xyplorer.com/faq.php) before posting a question...
LittleBiG
Posts: 1846
Joined: 08 Apr 2011 12:57
Location: Win10x64

Re: Dark Mode and Toolbar Buttons

Post by LittleBiG »

admin wrote: 03 Jan 2019 11:16
LittleBiG wrote: 03 Jan 2019 09:26
admin wrote: 29 Dec 2018 11:57 1. There are indeed some icons (eg Manual Sorting, Customize Keyboard) that turn out almost completely black, you can easily spot them in the Customize Toolbar dialog. I will rework them soon
I would encourage you to do something with the "on" state of the Ghost Filter button as well...
I know what you mean but I found it cute to see just the ghosty eyes... :)
OK :)

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Dark Mode and Toolbar Buttons

Post by admin »

SammaySarkar wrote: 03 Jan 2019 08:33what i'm getting at is that it's possible to have icons that completely hide the bg, making the feature useless. Can we have a rectangular background option, something like the pressed button effect underlay?
Okay, I'll see...

bdeshi
Posts: 4249
Joined: 12 Mar 2014 17:27
Location: Asteroid B-612 / Dhaka
Contact:

Re: Dark Mode and Toolbar Buttons

Post by bdeshi »

admin wrote: 03 Jan 2019 13:00
SammaySarkar wrote: 03 Jan 2019 08:33what i'm getting at is that it's possible to have icons that completely hide the bg, making the feature useless. Can we have a rectangular background option, something like the pressed button effect underlay?
Okay, I'll see...
all good now, thanks.
Icon Names | Onyx | Undocumented Commands | xypcre
[ this user is asleep ]

bdeshi
Posts: 4249
Joined: 12 Mar 2014 17:27
Location: Asteroid B-612 / Dhaka
Contact:

Re: Dark Mode and Toolbar Buttons

Post by bdeshi »

Me stressing on icon background again.
See how the attached icon looks on a rect bg.
btn-bg.png
btn-bg.png (2.92 KiB) Viewed 1352 times
The mouse overlay has equal margins all around though, so maybe add one pixel padding to the right and bottom of icons? (if that doesnt complicate alignments/measurements/other things.)
Attachments
gentleface_align_just.zip
(499 Bytes) Downloaded 69 times
Icon Names | Onyx | Undocumented Commands | xypcre
[ this user is asleep ]

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Dark Mode and Toolbar Buttons

Post by admin »

Well, I'd say these icons are not suitable for dark mode. :ghost:

bdeshi
Posts: 4249
Joined: 12 Mar 2014 17:27
Location: Asteroid B-612 / Dhaka
Contact:

Re: Dark Mode and Toolbar Buttons

Post by bdeshi »

hmm, fair enough this one does look a little larger next to all other button icons, I should probably shrink it; but eyes will keep noticing that tiny misalignment. :|
Icon Names | Onyx | Undocumented Commands | xypcre
[ this user is asleep ]

bdeshi
Posts: 4249
Joined: 12 Mar 2014 17:27
Location: Asteroid B-612 / Dhaka
Contact:

Re: Dark Mode and Toolbar Buttons

Post by bdeshi »

Can you make the backgrounds dark-mode only please?
These backgrounds are featurewise quite unnecessary in light mode. Also, I'm using some medium-dark greys, these look odd in light mode.
Icon Names | Onyx | Undocumented Commands | xypcre
[ this user is asleep ]

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Dark Mode and Toolbar Buttons

Post by admin »

Good point, of course!

bdeshi
Posts: 4249
Joined: 12 Mar 2014 17:27
Location: Asteroid B-612 / Dhaka
Contact:

Re: Dark Mode and Toolbar Buttons

Post by bdeshi »

two small issues:
1. When "XYplorer Classic Style" highlighting is selected in "Customize Toolbar", toolbar buttons get a dark hover effect in dark mode; but statusbar buttons hover effect is always bright. [edit: Not always. This happens only when XYplorer was not started in dark mode.]
statusbtns-bright-hilite.png
statusbtns-bright-hilite.png (1.02 KiB) Viewed 1199 times

2. the blank label icon can be a little lighter. Currently it almost disappears when highlighted.
Here's its current color vs a brighter option.
top: default: #767C94<br />bottom: brighter: #9297CD
top: default: #767C94
bottom: brighter: #9297CD
brighter-blank-label-icon.png (4.46 KiB) Viewed 1199 times
Well, this actually depends on the level of darkness. So maybe this icon can be close to white in dark mode.
Icon Names | Onyx | Undocumented Commands | xypcre
[ this user is asleep ]

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Dark Mode and Toolbar Buttons

Post by admin »

:tup: + :tup:

Post Reply