Undo/Redo

[admin]

On my XP SP3:

Code: Select all

12:19:52.546 >> 4: C:\TEMP\New Textfile_01.txt¿
12:19:52.546 >> SHCNE_DELETE
12:19:52.546 >> SHCNE_DELETE: C:\TEMP\New Textfile_01.txt | New Textfile_01.txt | C:\RECYCLER\S-1-5-21-4269340281-4223954186-2632510487-1005\Dc52.txt | Dc52.txt
12:19:52.546 >> mod 4: C:\TEMP\New Textfile_01.txt|C:\RECYCLER\S-1-5-21-4269340281-4223954186-2632510487-1005\Dc52.txt
12:19:52.546 >> SHCNE_DELETE
12:19:52.546 >> SHCNE_DELETE: C:\TEMP\New Textfile_01.txt | New Textfile_01.txt | C:\RECYCLER\S-1-5-21-4269340281-4223954186-2632510487-1005\Dc52.txt | Dc52.txt
12:19:52.546 >> mod 4: C:\TEMP\New Textfile_01.txt|C:\RECYCLER\S-1-5-21-4269340281-4223954186-2632510487-1005\Dc52.txt

After successful Undo:

Code: Select all

12:19:52.546 >> 4: C:\TEMP\New Textfile_01.txt¿
12:19:52.546 >> SHCNE_DELETE
12:19:52.546 >> SHCNE_DELETE: C:\TEMP\New Textfile_01.txt | New Textfile_01.txt | C:\RECYCLER\S-1-5-21-4269340281-4223954186-2632510487-1005\Dc52.txt | Dc52.txt
12:19:52.546 >> mod 4: C:\TEMP\New Textfile_01.txt|C:\RECYCLER\S-1-5-21-4269340281-4223954186-2632510487-1005\Dc52.txt
12:19:52.546 >> SHCNE_DELETE
12:19:52.546 >> SHCNE_DELETE: C:\TEMP\New Textfile_01.txt | New Textfile_01.txt | C:\RECYCLER\S-1-5-21-4269340281-4223954186-2632510487-1005\Dc52.txt | Dc52.txt
12:19:52.546 >> mod 4: C:\TEMP\New Textfile_01.txt|C:\RECYCLER\S-1-5-21-4269340281-4223954186-2632510487-1005\Dc52.txt

Funny though, I can't see any difference in the logs contents

I'm not surprised. (I know the code) Since on XP the recycle bin names are known I can enter a much faster restoration routine which I did not log. And the old log is not reset.

The big mystery ATM is: Why does VW (Vista/Win7) hide the recycle bin names from me? Or better: where does VW hide them?

[admin]

On my Win 7, if it makes any difference, is what I get:

Once deleted

Code: Select all

09:41:04.581 >> 4: D:\Video\TempBurn\New Textfile.txt¿
09:41:04.608 >> SHCNE_DELETE
09:41:04.608 >> SHCNE_DELETE: D:\Video\TempBurn\New Textfile.txt | New Textfile.txt |  | 

Trying Undo

Code: Select all

09:42:27.430 >> rd 0: Name = New Textfile.txt
09:42:27.430 >> rd 1: Original Location = D:\Video\TempBurn
09:42:27.430 >> rd 2: Date Deleted = ‎25/‎10/‎2009 ‏‎9:41 AM
09:42:27.430 >> rd 3: Size = 0 bytes
09:42:27.430 >> rd 4: Item type = Text Document
09:42:27.430 >> rd 5: Date modified = ‎25/‎10/‎2009 ‏‎9:40 AM
09:42:27.430 >> rd 6: Date created = ‎25/‎10/‎2009 ‏‎9:40 AM
09:42:27.430 >> rd 7: Date accessed = ‎25/‎10/‎2009 ‏‎9:40 AM
09:42:27.430 >> rd 8: Attributes = A
09:42:27.430 >> rd 9: Offline status = 
09:42:27.430 >> rd 10: Offline availability = 

With these data I'm surprised that the undo failed. It looks like it should have been possible with the latest XY version.

EDIT: Oh, when I copy "Date Deleted = ‎25/‎10/‎2009 ‏‎9:41 AM" and paste it into an editor I see the mysterious questionmarks -- that explains it...

[TheQwerty]

EDIT: Oh, when I copy "Date Deleted = ‎25/‎10/‎2009 ‏‎9:41 AM" and paste it into an editor I see the mysterious questionmarks -- that explains it...

And that is what I did yesterday, I pasted it into TextPad first.

Using this script and pasting directly into the reply:

Code: Select all

"File" Global($type,$file);$type="File";$file="New File - <date yyyymmddhhnnss>.txt";Sub("_doit");
"Dir" Global($type,$file);$type="Dir";$file="New Folder - <date yyyymmddhhnnss>";Sub("_doit");
"_doit" Global($type,$file);New("$file","$type");$a=GetInfo("debuglog");Focus();Delete(1,1,"<curpath>\$file");$b=GetInfo("debuglog");#203;$c=GetInfo("debuglog");CopyText("$type Test....<crlf>After New:<crlf>$a<crlf><crlf>After Delete:<crlf>$b<crlf><crlf>After Undo:<crlf>$c");

File Test....
After New:
20:11:56.482 >> 16: Z:\

After Delete:
20:11:57.493 >> 4: Z:\New File - 20091025161156.txt¿
20:11:57.519 >> SHCNE_DELETE
20:11:57.519 >> SHCNE_DELETE: Z:\New File - 20091025161156.txt | New File - 20091025161156.txt | |

After Undo:
20:11:57.531 >> rd 0: Name = New File - 20091025161156.txt
20:11:57.531 >> rd 1: Original Location = Z:\
20:11:57.532 >> rd 2: Date Deleted = ‎10/‎25/‎2009 ‏‎4:11 PM
20:11:57.532 >> rd 3: Size = 0 bytes
20:11:57.532 >> rd 4: Type = Text Document
20:11:57.532 >> rd 5: Date modified = ‎10/‎25/‎2009 ‏‎4:11 PM
20:11:57.532 >> rd 6: Date created = ‎10/‎25/‎2009 ‏‎4:11 PM
20:11:57.532 >> rd 7: Date accessed = ‎10/‎25/‎2009 ‏‎4:11 PM
20:11:57.532 >> rd 8: Attributes = A
20:11:57.532 >> rd 9: Offline status =
20:11:57.532 >> rd 10: Offline availability =

Dir Test....
After New:
20:12:14.219 >> 16: Z:\

After Delete:
20:12:15.228 >> 4: Z:\New Folder - 20091025161214¿
20:12:15.333 >> SHCNE_MKDIR
20:12:15.333 >> SHCNE_MKDIR: Z:\$RECYCLE.BIN\S-1-5-21-1228544555-2450258989-2244176320-1000\$RWLVGZ7 | $RWLVGZ7 | |
20:12:15.333 >> SHCNE_RMDIR
20:12:15.333 >> SHCNE_RMDIR: Z:\New Folder - 20091025161214 | New Folder - 20091025161214 | |
20:12:15.333 >> SHCNE_MKDIR
20:12:15.333 >> SHCNE_MKDIR: Z:\$RECYCLE.BIN\S-1-5-21-1228544555-2450258989-2244176320-1000\$RWLVGZ7 | $RWLVGZ7 | |

After Undo:
20:12:15.349 >> rd 0: Name = New Folder - 20091025161214
20:12:15.349 >> rd 1: Original Location = Z:\
20:12:15.349 >> rd 2: Date Deleted = ‎10/‎25/‎2009 ‏‎4:12 PM
20:12:15.349 >> rd 3: Size = 0 bytes
20:12:15.349 >> rd 4: Type = File Folder
20:12:15.349 >> rd 5: Date modified = ‎10/‎25/‎2009 ‏‎4:12 PM
20:12:15.349 >> rd 6: Date created = ‎10/‎25/‎2009 ‏‎4:12 PM
20:12:15.349 >> rd 7: Date accessed = ‎10/‎25/‎2009 ‏‎4:12 PM
20:12:15.349 >> rd 8: Attributes =
20:12:15.349 >> rd 9: Offline status =
20:12:15.349 >> rd 10: Offline availability =

[admin]

Thanks, I found it. It's Unicode Character 'LEFT-TO-RIGHT MARK' (U+200E). Invisible but existing. But I trapped it.

[admin]

Thanks, I found it. It's Unicode Character 'LEFT-TO-RIGHT MARK' (U+200E). Invisible but existing. But I trapped it.

OK, I added the LTRM trapper in v8.50.0026. Undo Delete might work better now in VW (Vista/Win7)...

I also changed something else in search of the recycled item names. Please delete/recycle a file and a folder again under Vista/Win7 and show me the debuglog. Thanks!

[zer0]

Still fails

Deleting a file:

Code: Select all

21:57:54.283 >> 4: D:\Video\TempBurn\TrueCrypt Setup 6.3.exe¿
21:57:54.298 >> SHCNE_UPDATEDIR, 1=74055744, 2=0
21:57:54.298 >> SHCNE_UPDATEDIR:  | Recycle Bin |  | 
21:57:54.298 >> SHCNE_DELETE, 1=74055744, 2=0
21:57:54.298 >> SHCNE_DELETE: D:\Video\TempBurn\TrueCrypt Setup 6.3.exe | TrueCrypt Setup 6.3.exe |  | 
21:57:54.298 >> SHCNE_CREATE, 1=74055744, 2=0
21:57:54.298 >> SHCNE_UPDATEIMAGE, 1=74055744, 2=74055760

Undoing a delete:

Code: Select all

21:59:16.245 >> rd 0: Name = TrueCrypt Setup 6.3.exe
21:59:16.245 >> rd 1: Original Location = D:\Video\TempBurn
21:59:16.245 >> rd 2: Date Deleted = ‎25/‎10/‎2009 ‏‎9:57 PM
21:59:16.245 >> rd 3: Size = 3.20 MB
21:59:16.245 >> rd 4: Item type = Application
21:59:16.245 >> rd 5: Date modified = ‎22/‎10/‎2009 ‏‎10:18 PM
21:59:16.245 >> rd 6: Date created = ‎22/‎10/‎2009 ‏‎10:17 PM
21:59:16.245 >> rd 7: Date accessed = ‎22/‎10/‎2009 ‏‎10:17 PM
21:59:16.245 >> rd 8: Attributes = A
21:59:16.245 >> rd 9: Offline status = 
21:59:16.245 >> rd 10: Offline availability =

[nas8e9]

No luck with 8.50.0026 beta on Windows 7 x64 RTM:

Delete:

Code: Select all

22:06:29.112 >> 4: J:\Tmp\Download\Prg\WDTV_FW_1_02_10\release_notes_1_02_10.txt¿
22:06:29.135 >> SHCNE_DELETE, 1=78315584, 2=0
22:06:29.135 >> SHCNE_DELETE: J:\Tmp\Download\Prg\WDTV_FW_1_02_10\release_notes_1_02_10.txt | release_notes_1_02_10.txt |  | 
22:06:29.135 >> SHCNE_CREATE, 1=78315584, 2=0
22:06:29.135 >> SHCNE_UPDATEIMAGE, 1=78315584, 2=78315600
22:06:29.137 >> SHCNE_CREATE, 1=78315584, 2=0

Undelete (failed with message: "Undo failed! Item(s) not found in recycler.")

Code: Select all

22:10:59.250 >> rd 0: Name = release_notes_1_02_10.txt
22:10:59.250 >> rd 1: Original Location = J:\Tmp\Download\Prg\WDTV_FW_1_02_10
22:10:59.250 >> rd 2: Date Deleted = ‎25-‎10-‎2009 22:06
22:10:59.250 >> rd 3: Size = 633 bytes
22:10:59.250 >> rd 4: Item type = Text Document
22:10:59.250 >> rd 5: Date modified = ‎16-‎6-‎2009 ‏‎15:45
22:10:59.250 >> rd 6: Date created = ‎25-‎10-‎2009 ‏‎16:34
22:10:59.250 >> rd 7: Date accessed = ‎25-‎10-‎2009 ‏‎16:34
22:10:59.250 >> rd 8: Attributes = A
22:10:59.250 >> rd 9: Offline status = 
22:10:59.250 >> rd 10: Offline availability = 

[admin]

Thanks for all the debug logs, folks! I'm getting nearer to the solution, but there are still some questions. Please do it once more! Send me your debug logs for deleting and restoring files and folders in Vista/Win7, with the latest version v8.50.0027.

[nas8e9]

Thanks for all the debug logs, folks! I'm getting nearer to the solution, but there are still some questions. Please do it once more! Send me your debug logs for deleting and restoring files and folders in Vista/Win7, with the latest version v8.50.0027.

8.50.0027 beta on Windows 7 x64 RTM:

Delete:

Code: Select all

09:19:42.537 >> 4: J:\Tmp\Download\Prg\Downloadindex.txt¿
09:19:42.553 >> SHCNE_DELETE, 1=53477440, 2=0
09:19:42.554 >> SHCNE_DELETE: J:\Tmp\Download\Prg\Downloadindex.txt | Downloadindex.txt |  | 
09:19:42.554 >> SHCNE_CREATE, 1=53477440, 2=0
09:19:42.554 >> SHCNE_CREATE: J:\$RECYCLE.BIN\S-1-5-21-1809554351-3682586006-3281551331-1001\$RKR8GF1.txt | $RKR8GF1.txt |  | 
09:19:42.554 >> SHCNE_UPDATEIMAGE, 1=53477440, 2=53477456
09:20:17.039 >> SHCNE_MKDIR, 1=57868352, 2=0
09:20:17.039 >> SHCNE_MKDIR:  | AMD |  | 
09:20:19.973 >> SHCNE_UPDATEITEM, 1=57868352, 2=0

Failed undelete:

Code: Select all

09:21:11.639 >> rd 0: Name = Downloadindex.txt
09:21:11.639 >> rd 1: Original Location = J:\Tmp\Download\Prg
09:21:11.648 >> rd 2: Date Deleted = ‎26-‎10-‎2009 ‏‎10:19
09:21:11.649 >> rd 3: Size = 0 bytes
09:21:11.649 >> rd 4: Item type = Text Document
09:21:11.649 >> rd 5: Date modified = ‎24-‎10-‎2009 ‏‎20:43
09:21:11.649 >> rd 6: Date created = ‎10-‎10-‎2008 ‏‎22:17
09:21:11.649 >> rd 7: Date accessed = ‎24-‎5-‎2009 ‏‎16:56
09:21:11.649 >> rd 8: Attributes = A
09:21:11.649 >> rd 9: Offline status = 
09:21:11.649 >> rd 10: Offline availability = 
09:21:11.649 >> EP 26-10-2009 9:19:42
09:21:11.649 >> IsSame
09:21:11.649 >> DDf 0:00:00 | 26-10-2009 10:19:42

[admin]

Thanks for all the debug logs, folks! I'm getting nearer to the solution, but there are still some questions. Please do it once more! Send me your debug logs for deleting and restoring files and folders in Vista/Win7, with the latest version v8.50.0027.

8.50.0027 beta on Windows 7 x64 RTM:

Delete:

Code: Select all

09:19:42.537 >> 4: J:\Tmp\Download\Prg\Downloadindex.txt¿
09:19:42.553 >> SHCNE_DELETE, 1=53477440, 2=0
09:19:42.554 >> SHCNE_DELETE: J:\Tmp\Download\Prg\Downloadindex.txt | Downloadindex.txt |  | 
09:19:42.554 >> SHCNE_CREATE, 1=53477440, 2=0
09:19:42.554 >> SHCNE_CREATE: J:\$RECYCLE.BIN\S-1-5-21-1809554351-3682586006-3281551331-1001\$RKR8GF1.txt | $RKR8GF1.txt |  | 
09:19:42.554 >> SHCNE_UPDATEIMAGE, 1=53477440, 2=53477456
09:20:17.039 >> SHCNE_MKDIR, 1=57868352, 2=0
09:20:17.039 >> SHCNE_MKDIR:  | AMD |  | 
09:20:19.973 >> SHCNE_UPDATEITEM, 1=57868352, 2=0

Failed undelete:

Code: Select all

09:21:11.639 >> rd 0: Name = Downloadindex.txt
09:21:11.639 >> rd 1: Original Location = J:\Tmp\Download\Prg
09:21:11.648 >> rd 2: Date Deleted = ‎26-‎10-‎2009 ‏‎10:19
09:21:11.649 >> rd 3: Size = 0 bytes
09:21:11.649 >> rd 4: Item type = Text Document
09:21:11.649 >> rd 5: Date modified = ‎24-‎10-‎2009 ‏‎20:43
09:21:11.649 >> rd 6: Date created = ‎10-‎10-‎2008 ‏‎22:17
09:21:11.649 >> rd 7: Date accessed = ‎24-‎5-‎2009 ‏‎16:56
09:21:11.649 >> rd 8: Attributes = A
09:21:11.649 >> rd 9: Offline status = 
09:21:11.649 >> rd 10: Offline availability = 
09:21:11.649 >> EP 26-10-2009 9:19:42
09:21:11.649 >> IsSame
09:21:11.649 >> DDf 0:00:00 | 26-10-2009 10:19:42

Ah, very good. Are you in the same time zone as Germany?

[nas8e9]

Ah, very good. Are you in the same time zone as Germany?

I believe so: Windows 7's Time Zone is (UTC+01:00) Amsterdam, Berlin, Bern, Rome, Stockholm, Vienna.

[zer0]

I have encountered a couple of issues, they revolves around extracting from ZIP files and undoing of such actions. As you may now, Windows XP/Vista/Win7 handle ZIP files natively, so they may be opened as a compressed folder in Windows Explorer. This leads to a hiccup with XYplorer.

To reproduce:
1. Open a ZIP file from within Windows Explorer.
2. DnD at least one (1) file from that ZIP file into XY's List.
3. Action Log shows a Move operation. Trying to undo this operation fails with no error message.

Two gripes about this:
a) Action Log shouldn't show DnDing from a ZIP archive as a move operation, because that file remains in that archive. DnDing in WE shows a "Copying" pop-up, which is correct.
b) No error pop-up when not able to do undo. Granted, XY doesn't support ZIP files natively (will it ever? ), so it can't put that file back, but a message stating such would be nice.

Even further, delete a file in a folder, then delete that folder and then undo deletion of that file. Obviously, that folder is recreated and that file is back in it, but in the Action Log only undoing of the file deletion is shown as undone while it is undoing of both the file deletion and the folder deletion that are undone. Action Log doesn't show this. May I ask why?

[admin]

Excuse the frequent updates but this is hard to fix: Virtually no documentation anywhere, no Vista/Win7 here, and Windows changing its behavior dramatically with every new release. Freaking.

Anyway, please try again and send me your logs (unless it works! ). Also please try with 2 files, and then with 6 files (delete to Recycler from Vista/Win7 I mean). Also look at the action log if everything looks better now or still "unknown" all over the place...

[nas8e9]

With 8.50.0028 beta on Windows 7 x64 RTM, undelete works!

Not to put a damper on things, but: Change Log for the latest XYplorer BETA version (v8.50.0028, 27-oct-2009)?

Edit:

Anyway, please try again and send me your logs (unless it works! ). Also please try with 2 files, and then with 6 files (delete to Recycler from Vista/Win7 I mean). Also look at the action log if everything looks better now or still "unknown" all over the place...

Deleting either 1, 2 or 6 files works. Also, deleting and undeleting a folder with files works.

[admin]

I have encountered a couple of issues, they revolves around extracting from ZIP files and undoing of such actions. As you may now, Windows XP/Vista/Win7 handle ZIP files natively, so they may be opened as a compressed folder in Windows Explorer. This leads to a hiccup with XYplorer.

To reproduce:
1. Open a ZIP file from within Windows Explorer.
2. DnD at least one (1) file from that ZIP file into XY's List.
3. Action Log shows a Move operation. Trying to undo this operation fails with no error message.

Two gripes about this:
a) Action Log shouldn't show DnDing from a ZIP archive as a move operation, because that file remains in that archive. DnDing in WE shows a "Copying" pop-up, which is correct.
b) No error pop-up when not able to do undo. Granted, XY doesn't support ZIP files natively (will it ever? ), so it can't put that file back, but a message stating such would be nice.

Even further, delete a file in a folder, then delete that folder and then undo deletion of that file. Obviously, that folder is recreated and that file is back in it, but in the Action Log only undoing of the file deletion is shown as undone while it is undoing of both the file deletion and the folder deletion that are undone. Action Log doesn't show this. May I ask why?

Conc. the first gripe: When I drop something from WinZip I get a Copy logged, not a Move. You sure you get a Move? Undoing this copy (which is a copy from my Temp folder, where WinZip has extracted the archive to) works of course (it's simply deleted). Redo does not work since the temp files have been deleted by WinZip in the meantime.

Anyway, I will see whether I can improve this.

Conc. the 2nd gripe: I assume you talk about non-seq undo. It looks like the shell silently restores the missing folder when it restores the file from recycle bin. It's impossible to track this kind of covert actions. I recommend cumulative undo or live with the consequences.