recent colorfilter change

Things you’d like to miss in the future...
Post Reply
jupe
Posts: 2757
Joined: 20 Oct 2017 21:14
Location: Win10 22H2 120dpi

recent colorfilter change

Post by jupe »

I noticed new behavior, not sure it's intentional, now my ICF entries (that use |b) are making the columns besides the name column have grey text in my normal profile, eg. goto <xypath>; colorfilter("xy|b>FF0080,000000"); results in this (notice the bottom 2 entries grey text color):

2022-08-12_164324.png
2022-08-12_164324.png (3.08 KiB) Viewed 628 times

Were the recent changes meant to do that? I haven't rolled back to double check old ver, but I am pretty sure this is new behavior, from fresh these config changes are needed:

Configuration | Colors and Styles | Color Filters | [x] Enable color filters
uncheck all default CF's

Configuration | Colors and Styles | Color Filters | [ ] Apply text colors to the Name column only
Configuration | Colors and Styles | Styles | Columns | [ ] Lighter text in details columns

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: recent colorfilter changes

Post by admin »

Indeed, that was a side-effect of yesterday's fix. Next beta tries to fix both.

jupe
Posts: 2757
Joined: 20 Oct 2017 21:14
Location: Win10 22H2 120dpi

Re: recent colorfilter changes

Post by jupe »

I still get the grey text when using |bp and |fp in 23.50.0008

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: recent colorfilter change

Post by admin »

Fixed for Light Mode in next beta. In Dark Mode it runs into readability issues depending on the colors.

jupe
Posts: 2757
Joined: 20 Oct 2017 21:14
Location: Win10 22H2 120dpi

Re: recent colorfilter change

Post by jupe »

Before any of the recent changes a |fp filter used to always have black text in the other columns, now since the last modification it uses the first color of the filter, like you mentioned that can present terrible readability issues, personally I think if you aren't going to go back to how it was originally with black text (that would be preferential), I'd even prefer the grey you had in .0008 over the current situation. Below is a quick rough comparison of new version and old.

2022-08-14_035643.png
2022-08-14_035643.png (5.35 KiB) Viewed 565 times

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: recent colorfilter change

Post by admin »

Isn't that grey text related to Configuration | Colors and Styles | Styles | Columns | Lighter text in details columns?

jupe
Posts: 2757
Joined: 20 Oct 2017 21:14
Location: Win10 22H2 120dpi

Re: recent colorfilter change

Post by jupe »

No the grey isn't related to that, if you read my original post (and look at the original screenshot, top item normal), I mentioned that setting needs to be disabled for repro-ing, there is no grey text currently anyway, there was in .0008.

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: recent colorfilter change

Post by admin »

Next beta. :)

jupe
Posts: 2757
Joined: 20 Oct 2017 21:14
Location: Win10 22H2 120dpi

Re: recent colorfilter change

Post by jupe »

:oops:

Sorry, I just realized in light mode it is already back to normal again in .0009+, in the old version I was comparing with to refresh my memory, I had neglected to set "Apply text colors to the Name column only", so now the only behavior change I can notice is in dark mode, and you said that was intentional.

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: recent colorfilter change

Post by admin »

No problem, I have backups. Anyway, I made some changes again, and let's see who is complaining next. :) This color stuff is surprisingly complex sometimes.

jupe
Posts: 2757
Joined: 20 Oct 2017 21:14
Location: Win10 22H2 120dpi

Re: recent colorfilter change

Post by jupe »

I guess it came across as complaining, but originally when the text turned grey I was just trying to make sure that the changes were intentional, then admittedly I made a config mistake when comparing to old ver once that was fixed.

It might not have seemed like it but just to be clear I was just trying to point out things that had changed from the original display style, and it was back to normal in .0009, but now it looks like there are major changes to how it used to be, the color filter only applies to the Name column for those modes now, I think people will notice that.

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: recent colorfilter change

Post by admin »

I meant it in a joking way (see the :) ). I personally see no major changes in my color filters. But I'm ready for the reports.

jupe
Posts: 2757
Joined: 20 Oct 2017 21:14
Location: Win10 22H2 120dpi

Re: recent colorfilter change

Post by jupe »

I have also noticed a different unrelated issue that has occurred since the recent colorfilter caching change, now colorfilters don't always react to changes immediately, and require a refresh.

fresh repro steps.
  1. Configuration | Colors and Styles | Color Filters | [x] Enable color filters
  2. Disable all default entries, select first item to retain its color
  3. edit entry to cmt:?* and enable it
  4. select file and add comment
  5. result = no colorfilter visible until refresh
The same in reverse too, ie. rem cmt = no list update. I am only using cmt as an example, other things are affected too.

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: recent colorfilter change

Post by admin »

Yep. :tup: Fixed in next beta. Probably also fixes VeeGee's bug.

Post Reply