tab bar new tab button sometimes visible when not enabled

[jupe]

This might be a bit finicky to repeat, but after disabling the new tab button under certain conditions it is still visible but overlayed on top of the tab bar, as pictured:

2021-03-24_170820.png (773 Bytes) Viewed 378 times

Here are the steps I can get it to happen with, from fresh, setup tabs config as so (not sure exactly all which are relevant but definitely with this combination it makes it easier to produce fault):

2021-03-24_192048.png (122.54 KiB) Viewed 378 times

Close dialog, open a few new tabs, then go back into config and uncheck the focused setting from above screenshot "Show new tab button" close dialog again,and then when switching tabs/mouse over 1st tabs tabicon you should encounter a situation like original screenshot. That last step of enabling disabling the newtab button might take a few repetitions of changing and then open+close config dialog, test tab switching to invoke issue, but I was able to repeat this at least 10 times in 10 different fresh instances with a little fiddling, but it is no big deal if you can't.

BTW the issue only is visible in the first pane, and if you swap panes it is only in the 2nd pane, the other pane sometimes just has a blank space where the new tab button would normally be. (it doesn't overlay 1st tab) other times it is normal.

newtabbtn.gif (69.48 KiB) Viewed 367 times

[admin]

Yep, saw it and fixed it.

[jupe]

oh cool, it took a while to get repro steps locked down, so I am glad it wasn't in vain.